Merge pull request #314 from github/fixes/311-objectdisposedexception-on-cancelled

shana · shana · commit 7a6586fbf1c7 · 2016-05-19T16:54:47.000-05:00
Don't call cancel.OnCompleted after disposal.
diff --git a/src/GitHub.UI.Reactive/Controls/SimpleViewUserControl.cs b/src/GitHub.UI.Reactive/Controls/SimpleViewUserControl.cs
@@ -56,7 +56,6 @@ protected void NotifyCancel()
                 return;
 
             cancel.OnNext(null);
-            cancel.OnCompleted();
         }
 
         protected void NotifyIsBusy(bool busy)

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,6 @@ protected void NotifyCancel()`
`56`	`56`	`return;`
`57`	`57`
`58`	`58`	`cancel.OnNext(null);`
`59`		`- cancel.OnCompleted();`
`60`	`59`	`}`
`61`	`60`
`62`	`61`	`protected void NotifyIsBusy(bool busy)`