Disable warnings for known obsolete calls

Author: jcansdale

src/GitHub.App/Api/ApiClient.cs

@@ -242,7 +242,8 @@ public IObservable<PullRequest> GetPullRequestsForRepository(string owner, strin
             Guard.ArgumentNotEmptyString(name, nameof(name));
 
             return gitHubClient.PullRequest.GetAllForRepository(owner, name,
-                new PullRequestRequest {
+                new PullRequestRequest
+                {
                     State = ItemStateFilter.All,
                     SortProperty = PullRequestSort.Updated,
                     SortDirection = SortDirection.Descending
@@ -268,7 +269,7 @@ public IObservable<Branch> GetBranches(string owner, string repo)
             Guard.ArgumentNotEmptyString(owner, nameof(owner));
             Guard.ArgumentNotEmptyString(repo, nameof(repo));
 
-#pragma warning disable CS0618
+#pragma warning disable 618
             // GetAllBranches is obsolete, but don't want to introduce the change to fix the
             // warning in the PR, so disabling for now.
             return gitHubClient.Repository.GetAllBranches(owner, repo);

test/GitHub.InlineReviews.UnitTests/TestDoubles/FakeDiffService.cs

@@ -39,7 +39,9 @@ public string AddFile(string path, string contents)
             var directory = Path.GetDirectoryName(fullPath);
             Directory.CreateDirectory(directory);
             File.WriteAllText(fullPath, contents);
+#pragma warning disable 618 // Type or member is obsolete
             repository.Stage(path);
+#pragma warning restore 618 // Type or member is obsolete
             repository.Commit("Added " + path, signature, signature);
             return repository.Head.Tip.Sha;
         }
@@ -106,7 +108,9 @@ static IRepository CreateRepository()
             var signature = new Signature("user", "user@user", DateTimeOffset.Now);
 
             File.WriteAllText(Path.Combine(tempPath, ".gitattributes"), "* text=auto");
+#pragma warning disable 618 // Type or member is obsolete
             result.Stage("*");
+#pragma warning restore 618 // Type or member is obsolete
             result.Commit("Initial commit", signature, signature);
 
             return result;

test/UnitTests/GitHub.App/Services/GitClientTests.cs

@@ -250,7 +250,9 @@ public async Task LocalBaseHeadAndMergeBase_DontFetch()
 
             var mergeBaseSha = await gitClient.GetPullRequestMergeBase(repo, targetCloneUrl, baseSha, headSha, baseRef, pullNumber);
 
+#pragma warning disable 618 // Type or member is obsolete
             repo.Network.DidNotReceiveWithAnyArgs().Fetch(null as Remote, null, null as FetchOptions);
+#pragma warning restore 618 // Type or member is obsolete
             Assert.That(expectMergeBaseSha, Is.EqualTo(mergeBaseSha));
         }
 
@@ -274,7 +276,9 @@ public async Task WhenToFetch(string baseSha, string headSha, string mergeBaseSh
             }
             catch (NotFoundException) { /* We're interested in calls to Fetch even if it throws */ }
 
+#pragma warning disable 618 // Type or member is obsolete
             repo.Network.Received(receivedFetch).Fetch(Arg.Any<Remote>(), Arg.Any<string[]>(), Arg.Any<FetchOptions>());
+#pragma warning restore 618 // Type or member is obsolete
         }
 
         [TestCase("baseSha", null, "mergeBaseSha", "baseRef", 777, "refs/pull/777/head")]
@@ -295,7 +299,9 @@ public async Task WhatToFetch(string baseSha, string headSha, string mergeBaseSh
             }
             catch (NotFoundException) { /* We're interested in calls to Fetch even if it throws */ }
 
+#pragma warning disable 618 // Type or member is obsolete
             repo.Network.Received(1).Fetch(Arg.Any<Remote>(), Arg.Is<IEnumerable<string>>(x => x.Contains(expectRefSpec)), Arg.Any<FetchOptions>());
+#pragma warning restore 618 // Type or member is obsolete
         }
 
         static IRepository MockRepo(string baseSha, string headSha, string mergeBaseSha)

test/UnitTests/TestDoubles/FakeCommitLog.cs

@@ -32,10 +32,12 @@ public ICommitLog QueryBy(CommitFilter filter)
         throw new NotImplementedException();
     }
 
+#pragma warning disable 618 // Type or member is obsolete
     public IEnumerable<LogEntry> QueryBy(string path, FollowFilter filter)
     {
         throw new NotImplementedException();
     }
+#pragma warning restore 618 // Type or member is obsolete
 
     public IEnumerable<LogEntry> QueryBy(string path, CommitFilter filter)
     {