Update test to reflect no duplicate change events

Author: jcansdale

test/UnitTests/GitHub.TeamFoundation/VSGitExtTests.cs

@@ -76,10 +76,10 @@ public void GitExtPropertyChangedEvent_ActiveRepositoriesChangedIsFired()
         }
 
         [Test]
-        public void ExceptionReadingActiveRepositories_ActiveRepositoriesChangedIsFired()
+        public void ExceptionReadingActiveRepositories_StillEmptySoNoEvent()
         {
             var context = CreateVSUIContext(true);
-            var gitExt = CreateGitExt();
+            var gitExt = CreateGitExt(new[] { "repoPath" });
             gitExt.ActiveRepositories.Returns(x => { throw new Exception("Boom!"); });
 
             var target = CreateVSGitExt(context, gitExt);
@@ -89,8 +89,8 @@ public void ExceptionReadingActiveRepositories_ActiveRepositoriesChangedIsFired(
             var eventArgs = new PropertyChangedEventArgs(nameof(gitExt.ActiveRepositories));
             gitExt.PropertyChanged += Raise.Event<PropertyChangedEventHandler>(gitExt, eventArgs);
 
-            Assert.That(wasFired, Is.True);
             Assert.That(target.ActiveRepositories, Is.Empty);
+            Assert.That(wasFired, Is.False);
         }
 
         [Test]
@@ -205,7 +205,7 @@ static VSGitExt CreateVSGitExt(IVSUIContext context = null, IGitExt gitExt = nul
 
     static IGitExt CreateGitExt(IList<string> repositoryPaths = null)
     {
-        repositoryPaths = repositoryPaths ?? new string[0];
+        repositoryPaths = repositoryPaths ?? Array.Empty<string>();
         var gitExt = Substitute.For<IGitExt>();
         var repoList = CreateActiveRepositories(repositoryPaths);
         gitExt.ActiveRepositories.Returns(repoList);