Hide PR count when list is loading.

Author: grokys

src/GitHub.App/SampleData/PullRequestListViewModelDesigner.cs

@@ -59,6 +59,7 @@ public PullRequestListViewModelDesigner()
         public IReadOnlyList<IRepositoryModel> Forks { get; }
         public string SearchQuery { get; set; }
         public string SelectedState { get; set; }
+        public string StateCaption { get; set; }
         public IReadOnlyList<string> States { get; }
         public Uri WebUrl => null;
         public ReactiveCommand<object> CreatePullRequest { get; }

src/GitHub.App/ViewModels/GitHubPane/IssueListViewModelBase.cs

@@ -30,6 +30,7 @@ public abstract class IssueListViewModelBase : PanePageViewModelBase, IIssueList
         IReadOnlyList<IRepositoryModel> forks;
         string searchQuery;
         string selectedState;
+        ObservableAsPropertyHelper<string> stateCaption;
         string stringFilter;
         int numberFilter;
         IUserFilterViewModel authorFilter;
@@ -42,6 +43,13 @@ public IssueListViewModelBase(IRepositoryService repositoryService)
         {
             this.repositoryService = repositoryService;
             OpenItem = ReactiveCommand.CreateAsyncTask(OpenItemImpl);
+            stateCaption = this.WhenAnyValue(
+                x => x.Items.Count,
+                x => x.SelectedState,
+                x => x.IsBusy,
+                x => x.IsLoading,
+                (count, state, busy, loading) => busy || loading ? state : count + " " + state)
+                .ToProperty(this, x => x.StateCaption);
         }
 
         /// <inheritdoc/>
@@ -106,6 +114,9 @@ public string SelectedState
         /// <inheritdoc/>
         public abstract IReadOnlyList<string> States { get; }
 
+        /// <inheritdoc/>
+        public string StateCaption => stateCaption.Value;
+
         /// <inheritdoc/>
         public ReactiveCommand<Unit> OpenItem { get; }
 

src/GitHub.Exports.Reactive/ViewModels/GitHubPane/IIssueListViewModelBase.cs

@@ -89,6 +89,11 @@ public interface IIssueListViewModelBase : ISearchablePageViewModel
         /// </summary>
         IReadOnlyList<string> States { get; }
 
+        /// <summary>
+        /// Gets the caption to display as the header on the <see cref="States"/> dropdown.
+        /// </summary>
+        string StateCaption { get; }
+
         /// <summary>
         /// Gets a command which opens the item passed as a parameter.
         /// </summary>

src/GitHub.VisualStudio/Views/GitHubPane/PullRequestListView.xaml

@@ -11,7 +11,7 @@
              mc:Ignorable="d" d:DesignHeight="300" d:DesignWidth="300"
              AutomationProperties.AutomationId="{x:Static ghfvs:AutomationIDs.PullRequestListViewCustom}">
     <d:DesignProperties.DataContext>
-        <ghfvs:PullRequestListViewModelDesigner Message="None"/>
+        <ghfvs:PullRequestListViewModelDesigner Message="None" StateCaption="3 Open"/>
     </d:DesignProperties.DataContext>
 
     <UserControl.Resources>
@@ -40,8 +40,7 @@
                 </ghfvs:DropDownButton.DropDownContent>
                 <TextBlock>
                     <Hyperlink Foreground="{DynamicResource GitHubActionLinkItemBrush}">
-                        <Run Text="{Binding Items.Count, Mode=OneWay}"/>
-                        <Run Text="{Binding SelectedState, Mode=OneWay}"/>
+                        <Run Text="{Binding StateCaption, Mode=OneWay}"/>
                     </Hyperlink>
                 </TextBlock>
             </ghfvs:DropDownButton>