Merge pull request #1386 from github/fixes/1385-checked-isloggedin

Check Connection.IsLoggedIn.

Author: grokys

src/GitHub.App/ViewModels/GitHubPane/GitHubPaneViewModel.cs

@@ -370,7 +370,7 @@ async Task UpdateContent(ILocalRepositoryModel repository)
 
                 Connection = await connectionManager.GetConnection(hostAddress);
 
-                if (Connection != null)
+                if (Connection?.IsLoggedIn == true)
                 {
                     navigator.Clear();
                     Content = navigator;

test/UnitTests/GitHub.App/ViewModels/GitHubPane/GitHubPaneViewModelTests.cs

@@ -94,7 +94,8 @@ public async Task LoggedOutShownWhenNotLoggedInToEnterprise()
         public async Task NavigatorShownWhenRepositoryIsAGitHubRepo()
         {
             var te = CreateTeamExplorerServiceHolder(ValidGitHubRepo);
-            var target = CreateTarget(teServiceHolder: te);
+            var cm = CreateConnectionManager("https://github.com");
+            var target = CreateTarget(teServiceHolder: te, connectionManager: cm);
 
             await Initialize(target);
 
@@ -105,7 +106,8 @@ public async Task NavigatorShownWhenRepositoryIsAGitHubRepo()
         public async Task NavigatorShownWhenRepositoryIsAnEnterpriseRepo()
         {
             var te = CreateTeamExplorerServiceHolder(ValidEnterpriseRepo);
-            var target = CreateTarget(teServiceHolder: te);
+            var cm = CreateConnectionManager("https://enterprise.com");
+            var target = CreateTarget(teServiceHolder: te, connectionManager: cm);
 
             await Initialize(target);
 
@@ -249,6 +251,7 @@ static void AddConnection(IConnectionManager connectionManager, string address)
         var hostAddress = HostAddress.Create(address);
         var connections = (ObservableCollectionEx<IConnection>)connectionManager.Connections;
         connection.HostAddress.Returns(hostAddress);
+        connection.IsLoggedIn.Returns(true);
         connectionManager.GetConnection(hostAddress).Returns(connection);
         connections.Add(connection);
     }