Merge pull request #190 from github/shana/fix-delays-loading-connect

Fix a delay in loading the connect page

Author: haacked

src/GitHub.Exports/Models/IConnectionManager.cs

@@ -2,7 +2,7 @@
 using System.Collections.ObjectModel;
 using System.Diagnostics.CodeAnalysis;
 using GitHub.Primitives;
-using GitHub.Services;
+using System.Threading.Tasks;
 
 namespace GitHub.Models
 {
@@ -19,6 +19,6 @@ public interface IConnectionManager
         // for telling IRepositoryHosts that we need to login from cache
         [SuppressMessage("Microsoft.Design", "CA1009:DeclareEventHandlersCorrectly")]
         event Func<IConnection, IObservable<IConnection>> DoLogin;
-        void RefreshRepositories();
+        Task RefreshRepositories();
     }
 }

src/GitHub.Exports/Services/VSServices.cs

@@ -124,9 +124,9 @@ static IEnumerable<ISimpleRepositoryModel> PokeTheRegistryForRepositoryList()
                             if (path != null)
                                 return new SimpleRepositoryModel(path);
                         }
-                        catch (Exception ex)
+                        catch (Exception)
                         {
-                            VsOutputLogger.WriteLine(string.Format(CultureInfo.CurrentCulture, "Error loading the repository from the registry '{0}'", ex));
+                            // no sense spamming the log, the registry might have ton of stale things we don't care about
                         }
                         return null;
                     }
@@ -257,4 +257,4 @@ public void ActivityLogWarning(string message)
             }
         }
     }
-}
+}

src/GitHub.VisualStudio/Services/ConnectionManager.cs

@@ -8,6 +8,7 @@
 using GitHub.Models;
 using GitHub.Services;
 using GitHub.Primitives;
+using System.Threading.Tasks;
 
 namespace GitHub.VisualStudio
 {
@@ -126,9 +127,9 @@ public void RequestLogout(IConnection connection)
             Connections.Remove(connection);
         }
 
-        public void RefreshRepositories()
+        public async Task RefreshRepositories()
         {
-            var list = vsServices.GetKnownRepositories();
+            var list = await Task.Run(() => vsServices.GetKnownRepositories());
             list.GroupBy(r => Connections.FirstOrDefault(c => r.CloneUrl != null && c.HostAddress.Equals(HostAddress.Create(r.CloneUrl))))
                 .Where(g => g.Key != null)
                 .ForEach(g =>

src/GitHub.VisualStudio/TeamExplorer/Connect/GitHubConnectSection.cs

@@ -17,6 +17,7 @@
 using Microsoft.VisualStudio;
 using NullGuard;
 using ReactiveUI;
+using System.Threading.Tasks;
 
 namespace GitHub.VisualStudio.TeamExplorer.Connect
 {
@@ -148,7 +149,7 @@ protected void Refresh(IConnection connection)
                     IsVisible = true;
                     LoggedIn = true;
                     if (ServiceProvider != null)
-                        RefreshRepositories();
+                        RefreshRepositories().Forget();
                 }
             }
         }
@@ -271,9 +272,9 @@ void ShowNotification(ISimpleRepositoryModel newrepo, string msg)
 #endif
         }
 
-        void RefreshRepositories()
+        async Task RefreshRepositories()
         {
-            connectionManager.RefreshRepositories();
+            await connectionManager.RefreshRepositories();
             RaisePropertyChanged("Repositories"); // trigger a re-check of the visibility of the listview based on item count
         }
 
@@ -362,7 +363,7 @@ enum SectionState
             readonly Stateless.StateMachine<SectionState, string> machine;
             readonly ITeamExplorerSection section;
 
-            public SectionStateTracker(ITeamExplorerSection section, Action onRefreshed)
+            public SectionStateTracker(ITeamExplorerSection section, Func<Task> onRefreshed)
             {
                 this.section = section;
                 machine = new Stateless.StateMachine<SectionState, string>(SectionState.Idle);
@@ -377,7 +378,7 @@ public SectionStateTracker(ITeamExplorerSection section, Action onRefreshed)
                     .Ignore("Title")
                     .PermitIf("IsBusy", SectionState.Idle, () => !this.section.IsBusy)
                     .IgnoreIf("IsBusy", () => this.section.IsBusy)
-                    .OnExit(onRefreshed);
+                    .OnExit(() => onRefreshed());
 
                 section.PropertyChanged += TrackState;
             }