Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit 844e586

Browse files
committed
Optionally create a VSIX that can be packaged with VS
1 parent 9051bf6 commit 844e586

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

scripts/build.ps1

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,10 +80,10 @@ if ($Package) {
8080
Write-Output "Building GitHub for Visual Studio"
8181
}
8282

83-
Build-Solution GitHubVs.sln "Build" $config -Deploy:$Package -ForVSInstaller:$ForVSInstaller
83+
Build-Solution GitHubVs.sln "Build" $config -Deploy:$Package -ForVSInstaller:$ForVSInstaller -VsixFileName:GitHub.VisualStudio.vsix
8484

8585
Push-Location src
86-
Build-Solution GitHub.VisualStudio.16.sln "Build" $config -Deploy:$Package
86+
Build-Solution GitHub.VisualStudio.16.sln "Build" $config -Deploy:$Package -ForVSInstaller:$ForVSInstaller -VsixFileName:GitHub.VisualStudio.16.vsix
8787
Pop-Location
8888

8989
Pop-Location

scripts/modules.ps1

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,15 +108,15 @@ New-Module -ScriptBlock {
108108
$msbuild
109109
}
110110

111-
function Build-Solution([string]$solution, [string]$target, [string]$configuration, [switch]$ForVSInstaller = $false, [bool]$Deploy = $false) {
111+
function Build-Solution([string]$solution, [string]$target, [string]$configuration, [switch]$ForVSInstaller = $false, [string]$VsixFileName, [bool]$Deploy = $false) {
112112
$msbuild = Find-MSBuild
113113

114114
Run-Command -Fatal { & $nuget restore $solution -NonInteractive -Verbosity detailed -MSBuildPath (Split-Path -parent $msbuild) }
115115
$flag1 = ""
116116
$flag2 = ""
117117
if ($ForVSInstaller) {
118118
$flag1 = "/p:IsProductComponent=true"
119-
$flag2 = "/p:TargetVsixContainer=$rootDirectory\build\vsinstaller\GitHub.VisualStudio.vsix"
119+
$flag2 = "/p:TargetVsixContainer=$rootDirectory\build\vsinstaller\$VsixFileName"
120120
new-item -Path $rootDirectory\build\vsinstaller -ItemType Directory -Force | Out-Null
121121
} elseif (!$Deploy) {
122122
$configuration += "WithoutVsix"

0 commit comments

Comments
 (0)