Ensure that the GitHubPaneViewModel is initalized.

- Renamed `IGitHubToolWindowManager.ShowHomePane` to `ShowGitHubPane` because the latter is what we call it these days
- Make `IGitHubToolWindowManager.ShowGitHubPane` async to make sure that `GitHubPaneViewModel.InitializeAsync` has finished before passing back a refrence to the `GitHubPaneViewModel`
- Make the methods that call `IGitHubToolWindowManager.ShowGitHubPane` `void async` with logging when they fail

Author: grokys

src/GitHub.VisualStudio/GitHubPackage.cs

@@ -156,7 +156,7 @@ protected override Task InitializeAsync(CancellationToken cancellationToken, IPr
             return Task.CompletedTask;
         }
 
-        public IGitHubPaneViewModel ShowHomePane()
+        public async Task<IGitHubPaneViewModel> ShowGitHubPane()
         {
             var pane = ShowToolWindow(new Guid(GitHubPane.GitHubPaneGuid));
             if (pane == null)
@@ -166,7 +166,10 @@ public IGitHubPaneViewModel ShowHomePane()
             {
                 ErrorHandler.Failed(frame.Show());
             }
-            return (IGitHubPaneViewModel)((FrameworkElement)pane.Content).DataContext;
+
+            var viewModel = (IGitHubPaneViewModel)((FrameworkElement)pane.Content).DataContext;
+            await viewModel.InitializeAsync(pane);
+            return viewModel;
         }
 
         static ToolWindowPane ShowToolWindow(Guid windowGuid)

src/GitHub.VisualStudio/IServiceProviderPackage.cs

@@ -1,5 +1,6 @@
 using System;
 using System.Runtime.InteropServices;
+using System.Threading.Tasks;
 using GitHub.ViewModels.GitHubPane;
 
 namespace GitHub.VisualStudio
@@ -12,6 +13,6 @@ public interface IServiceProviderPackage : IServiceProvider, Microsoft.VisualStu
     [ComVisible(true)]
     public interface IGitHubToolWindowManager
     {
-        IGitHubPaneViewModel ShowHomePane();
+        Task<IGitHubPaneViewModel> ShowGitHubPane();
     }
 }

src/GitHub.VisualStudio/Menus/OpenPullRequests.cs

@@ -1,15 +1,17 @@
-using GitHub.Exports;
-using GitHub.UI;
-using GitHub.VisualStudio.UI;
-using System;
-using GitHub.Services;
+using System;
+using GitHub.Exports;
 using GitHub.Extensions;
+using GitHub.Logging;
+using GitHub.Services;
+using Serilog;
 
 namespace GitHub.VisualStudio.Menus
 {
     [ExportMenu(MenuType = MenuType.OpenPullRequests)]
     public class OpenPullRequests : MenuBase, IMenuHandler
     {
+        static readonly ILogger log = LogManager.ForContext<ShowCurrentPullRequest>();
+
         public OpenPullRequests(IGitHubServiceProvider serviceProvider)
             : base(serviceProvider)
         {
@@ -19,10 +21,17 @@ public OpenPullRequests(IGitHubServiceProvider serviceProvider)
         public Guid Guid => Guids.guidGitHubCmdSet;
         public int CmdId => PkgCmdIDList.openPullRequestsCommand;
 
-        public void Activate(object data = null)
+        public async void Activate(object data = null)
         {
-            var host = ServiceProvider.TryGetService<IGitHubToolWindowManager>().ShowHomePane();
-            host.ShowPullRequests().Forget();
+            try
+            {
+                var host = await ServiceProvider.TryGetService<IGitHubToolWindowManager>().ShowGitHubPane();
+                await host.ShowPullRequests();
+            }
+            catch (Exception ex)
+            {
+                log.Error(ex, "Error showing opening pull requests");
+            }
         }
     }
 }

src/GitHub.VisualStudio/Menus/ShowCurrentPullRequest.cs

@@ -1,15 +1,17 @@
 using System;
 using GitHub.Exports;
-using GitHub.UI;
-using GitHub.Services;
 using GitHub.Extensions;
-using GitHub.Models;
+using GitHub.Logging;
+using GitHub.Services;
+using Serilog;
 
 namespace GitHub.VisualStudio.Menus
 {
     [ExportMenu(MenuType = MenuType.OpenPullRequests)]
     public class ShowCurrentPullRequest : MenuBase, IMenuHandler
     {
+        static readonly ILogger log = LogManager.ForContext<ShowCurrentPullRequest>();
+
         public ShowCurrentPullRequest(IGitHubServiceProvider serviceProvider)
             : base(serviceProvider)
         {
@@ -19,19 +21,26 @@ public ShowCurrentPullRequest(IGitHubServiceProvider serviceProvider)
         public Guid Guid => Guids.guidGitHubCmdSet;
         public int CmdId => PkgCmdIDList.showCurrentPullRequestCommand;
 
-        public void Activate(object data = null)
+        public async void Activate(object data = null)
         {
-            var pullRequestSessionManager = ServiceProvider.ExportProvider.GetExportedValueOrDefault<IPullRequestSessionManager>();
-            var session = pullRequestSessionManager?.CurrentSession;
-            if (session == null)
+            try
             {
-                return; // No active PR session.
-            }
+                var pullRequestSessionManager = ServiceProvider.ExportProvider.GetExportedValueOrDefault<IPullRequestSessionManager>();
+                var session = pullRequestSessionManager?.CurrentSession;
+                if (session == null)
+                {
+                    return; // No active PR session.
+                }
 
-            var pullRequest = session.PullRequest;
-            var manager = ServiceProvider.TryGetService<IGitHubToolWindowManager>();
-            var host = manager.ShowHomePane();
-            host.ShowPullRequest(session.RepositoryOwner, host.LocalRepository.Name, pullRequest.Number);
+                var pullRequest = session.PullRequest;
+                var manager = ServiceProvider.TryGetService<IGitHubToolWindowManager>();
+                var host = await manager.ShowGitHubPane();
+                await host.ShowPullRequest(session.RepositoryOwner, host.LocalRepository.Name, pullRequest.Number);
+            }
+            catch (Exception ex)
+            {
+                log.Error(ex, "Error showing current pull request");
+            }
         }
     }
 }

src/GitHub.VisualStudio/Menus/ShowGitHubPane.cs

@@ -17,7 +17,7 @@ public ShowGitHubPane(IGitHubServiceProvider serviceProvider)
 
         public void Activate(object data = null)
         {
-            ServiceProvider.TryGetService<IGitHubToolWindowManager>()?.ShowHomePane();
+            ServiceProvider.TryGetService<IGitHubToolWindowManager>()?.ShowGitHubPane();
         }
     }
 }

src/GitHub.VisualStudio/UI/GitHubPane.cs

@@ -89,7 +89,6 @@ public void Initialize(IServiceProvider serviceProvider)
 
                 var factory = provider.GetService<IViewViewModelFactory>();
                 viewModel = provider.ExportProvider.GetExportedValue<IGitHubPaneViewModel>();
-                viewModel.InitializeAsync(this).Forget();
 
                 View = factory.CreateView<IGitHubPaneViewModel>();
                 View.DataContext = viewModel;