Don't display duplicate gitignore and licences.

When akavache refreshes its cache, duplicate items are produced. This should really be fixed at a lower level, but for the moment just remove duplicates in the view model. Also fix sorting.

Author: grokys

src/GitHub.App/ViewModels/Dialog/RepositoryCreationViewModel.cs

@@ -197,7 +197,8 @@ public async Task InitializeAsync(IConnection connection)
                 .Subscribe(x =>
                 {
                     var sorted = x
-                        .OrderByDescending(item => GitIgnoreItem.IsRecommended(item.Name))
+                        .Distinct()
+                        .OrderByDescending(item => item.Recommended)
                         .ThenBy(item => item.Name);
                     GitIgnoreTemplates = new[] { GitIgnoreItem.None }.Concat(sorted).ToList();
 
@@ -212,8 +213,9 @@ public async Task InitializeAsync(IConnection connection)
                 .Subscribe(x =>
                 {
                     var sorted = x
-                        .OrderByDescending(item => LicenseItem.IsRecommended(item.Name))
-                        .ThenBy(item => item.Name);
+                        .Distinct()
+                        .OrderByDescending(item => item.Recommended)
+                        .ThenBy(item => item.Key);
                     Licenses = new[] { LicenseItem.None }.Concat(sorted).ToList();
                 });
         }

src/GitHub.Exports.Reactive/Models/GitIgnoreItem.cs

@@ -1,13 +1,14 @@
 using GitHub.Collections;
 using System;
+using System.Collections.Generic;
 using System.Diagnostics;
 using System.Globalization;
 using System.Linq;
 
 namespace GitHub.Models
 {
     [DebuggerDisplay("{DebuggerDisplay,nq}")]
-    public sealed class GitIgnoreItem : ICopyable<GitIgnoreItem>
+    public sealed class GitIgnoreItem : ICopyable<GitIgnoreItem>, IEquatable<GitIgnoreItem>
     {
         static readonly string[] recommendedIgnoreFiles = { "None", "VisualStudio", "Node", "Eclipse", "C++", "Windows" };
 
@@ -40,6 +41,16 @@ public static bool IsRecommended(string name)
             return recommendedIgnoreFiles.Any(item => item.Equals(name, StringComparison.OrdinalIgnoreCase));
         }
 
+        bool IEquatable<GitIgnoreItem>.Equals(GitIgnoreItem other) => Name == other.Name;
+
+        public override bool Equals(object obj)
+        {
+            var item = obj as GitIgnoreItem;
+            return item != null && Name == item.Name;
+        }
+
+        public override int GetHashCode() => 539060726 + EqualityComparer<string>.Default.GetHashCode(Name);
+
         internal string DebuggerDisplay
         {
             get

src/GitHub.Exports.Reactive/Models/LicenseItem.cs

@@ -2,10 +2,11 @@
 using Octokit;
 using GitHub.Collections;
 using System;
+using System.Collections.Generic;
 
 namespace GitHub.Models
 {
-    public class LicenseItem : ICopyable<LicenseItem>
+    public class LicenseItem : ICopyable<LicenseItem>, IEquatable<LicenseItem>
     {
         static readonly LicenseItem none = new LicenseItem();
         public static LicenseItem None { get { return none; } }
@@ -36,6 +37,19 @@ public void CopyFrom(LicenseItem other)
             Recommended = other.Recommended;
         }
 
+        bool IEquatable<LicenseItem>.Equals(LicenseItem other) => Key == other.Key;
+
+        public override bool Equals(object obj)
+        {
+            var item = obj as LicenseItem;
+            return item != null && Key == item.Key;
+        }
+
+        public override int GetHashCode()
+        {
+            return 539060726 + EqualityComparer<string>.Default.GetHashCode(Key);
+        }
+
         public string Key { get; private set; }
 
         public string Name { get; private set; }

test/GitHub.App.UnitTests/ViewModels/Dialog/RepositoryCreationViewModelTests.cs

@@ -419,11 +419,11 @@ public async Task IsPopulatedByTheModelServiceAsync()
             Assert.True(result[0].Recommended);
             Assert.That("apache-2.0", Is.EqualTo(result[1].Key));
             Assert.True(result[1].Recommended);
-            Assert.That("artistic-2.0", Is.EqualTo(result[2].Key));
+            Assert.That("mit", Is.EqualTo(result[2].Key));
             Assert.True(result[2].Recommended);
             Assert.That("agpl-3.0", Is.EqualTo(result[3].Key));
             Assert.False(result[3].Recommended);
-            Assert.That("mit", Is.EqualTo(result[4].Key));
+            Assert.That("artistic-2.0", Is.EqualTo(result[4].Key));
             Assert.False(result[4].Recommended);
             Assert.That(result[0], Is.EqualTo(vm.SelectedLicense));
         }