Merge pull request #943 from github/grokys/pr-list-busy

Display busy indicator in PR list.

Author: shana

src/GitHub.App/SampleData/PullRequestListViewModelDesigner.cs

@@ -67,6 +67,7 @@ public PullRequestListViewModelDesigner()
         public ObservableCollection<IAccount> Assignees { get; set; }
         public IAccount SelectedAssignee { get; set; }
         public IObservable<ViewWithData> Navigate { get; }
+        public bool IsBusy { get; }
 
         public ReactiveCommand<object> OpenPullRequest { get; }
         public ReactiveCommand<object> CreatePullRequest { get; }

src/GitHub.App/ViewModels/PullRequestListViewModel.cs

@@ -5,7 +5,6 @@
 using System.Linq;
 using System.Reactive.Linq;
 using System.Reactive.Subjects;
-using System.Windows.Input;
 using System.Windows.Media.Imaging;
 using GitHub.App;
 using GitHub.Collections;
@@ -82,11 +81,11 @@ public PullRequestListViewModel(
                 .Subscribe(s => UpdateFilter(s, SelectedAssignee, SelectedAuthor));
 
             this.WhenAny(x => x.SelectedAssignee, x => x.Value)
-                .Where(x => PullRequests != null && x != EmptyUser && IsLoaded)
+                .Where(x => PullRequests != null && x != EmptyUser && !IsBusy)
                 .Subscribe(a => UpdateFilter(SelectedState, a, SelectedAuthor));
 
             this.WhenAny(x => x.SelectedAuthor, x => x.Value)
-                .Where(x => PullRequests != null && x != EmptyUser && IsLoaded)
+                .Where(x => PullRequests != null && x != EmptyUser && !IsBusy)
                 .Subscribe(a => UpdateFilter(SelectedState, SelectedAssignee, a));
 
             SelectedState = States.FirstOrDefault(x => x.Name == listSettings.SelectedState) ?? States[0];
@@ -100,7 +99,7 @@ public override void Initialize([AllowNull] ViewWithData data)
         {
             base.Initialize(data);
 
-            IsLoaded = false;
+            IsBusy = true;
 
             PullRequests = repositoryHost.ModelService.GetPullRequests(repository, pullRequests);
             pullRequests.Subscribe(pr =>
@@ -134,7 +133,7 @@ public override void Initialize([AllowNull] ViewWithData data)
                         SelectedAssignee = Assignees.FirstOrDefault(x => x.Login == listSettings.SelectedAssignee);
                     }
 
-                    IsLoaded = true;
+                    IsBusy = false;
                     UpdateFilter(SelectedState, SelectedAssignee, SelectedAuthor);
                 });
         }
@@ -149,11 +148,11 @@ void UpdateFilter(PullRequestState state, [AllowNull]IAccount ass, [AllowNull]IA
                      (aut == null || aut.Equals(pr.Author));
         }
 
-        bool isLoaded;
-        public bool IsLoaded
+        bool isBusy;
+        public bool IsBusy
         {
-            get { return isLoaded; }
-            private set { this.RaiseAndSetIfChanged(ref isLoaded, value); }
+            get { return isBusy; }
+            private set { this.RaiseAndSetIfChanged(ref isBusy, value); }
         }
 
         ITrackingCollection<IPullRequestModel> pullRequests;

src/GitHub.Exports.Reactive/ViewModels/IPullRequestListViewModel.cs

@@ -27,7 +27,7 @@ public override string ToString()
         }
     }
 
-    public interface IPullRequestListViewModel : IViewModel, ICanNavigate
+    public interface IPullRequestListViewModel : IViewModel, ICanNavigate, IHasBusy
     {
         ITrackingCollection<IPullRequestModel> PullRequests { get; }
         IPullRequestModel SelectedPullRequest { get; }

src/GitHub.VisualStudio/UI/Views/PullRequestListView.xaml

@@ -115,23 +115,23 @@
 
       <WrapPanel Grid.Column="0" HorizontalAlignment="Stretch">
 
-        <ui:LinkDropDown IsEnabled="{Binding IsLoaded}"
+        <ui:LinkDropDown IsEnabled="{Binding IsBusy, Converter={ui:InverseBooleanConverter}}"
                          ItemsSource="{Binding States}"
                          SelectedItem="{Binding SelectedState}"
                          AutomationProperties.AutomationId="{x:Static automation:AutomationIDs.PullRequestListStatusFilterComboBox}" />
 
         <Separator Style="{StaticResource VerticalSeparator}" />
 
         <ui:LinkDropDown Header="Assignee"
-                         IsEnabled="{Binding IsLoaded}"
+                         IsEnabled="{Binding IsBusy, Converter={ui:InverseBooleanConverter}}"
                          ItemsSource="{Binding Source={StaticResource AssigneeCollectionViewSource}}"
                          SelectedItem="{Binding SelectedAssignee}"
                          AutomationProperties.AutomationId="{x:Static automation:AutomationIDs.PullRequestListAssigneeFilterComboBox}"/>
 
         <Separator Style="{StaticResource VerticalSeparator}" />
 
         <ui:LinkDropDown Header="Author"
-                         IsEnabled="{Binding IsLoaded}"
+                         IsEnabled="{Binding IsBusy, Converter={ui:InverseBooleanConverter}}"
                          ItemsSource="{Binding Source={StaticResource AuthorCollectionViewSource}}"
                          SelectedItem="{Binding SelectedAuthor}"
                          AutomationProperties.AutomationId="{x:Static automation:AutomationIDs.PullRequestListAuthorFilterComboBox}" />