Merge pull request #1703 from jcansdale/fixes/newPullRequest-null-check

jcansdale · web-flow · commit 8a53fe33c12f · 2018-05-22T17:08:28.000+01:00
Don't pass null to GetPullRequestForCurrentBranch
diff --git a/src/GitHub.App/Services/TeamExplorerContext.cs b/src/GitHub.App/Services/TeamExplorerContext.cs
@@ -78,7 +78,7 @@ async void Refresh()
                     var newBranchName = repo?.CurrentBranch?.Name;
                     var newHeadSha = repo?.CurrentBranch?.Sha;
                     var newTrackedSha = repo?.CurrentBranch?.TrackedSha;
-                    var newPullRequest = await pullRequestService.GetPullRequestForCurrentBranch(repo);
+                    var newPullRequest = repo != null ? await pullRequestService.GetPullRequestForCurrentBranch(repo) : null;
 
                     if (newRepositoryPath != repositoryPath)
                     {

Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ async void Refresh()`
`78`	`78`	`var newBranchName = repo?.CurrentBranch?.Name;`
`79`	`79`	`var newHeadSha = repo?.CurrentBranch?.Sha;`
`80`	`80`	`var newTrackedSha = repo?.CurrentBranch?.TrackedSha;`
`81`		`- var newPullRequest = await pullRequestService.GetPullRequestForCurrentBranch(repo);`
	`81`	`+ var newPullRequest = repo != null ? await pullRequestService.GetPullRequestForCurrentBranch(repo) : null;`
`82`	`82`
`83`	`83`	`if (newRepositoryPath != repositoryPath)`
`84`	`84`	`{`