Cleaning up graphql query

Author: StanleyGoldman

src/GitHub.App/Services/IssuesAutoCompleteSource.cs

@@ -9,6 +9,7 @@
 using GitHub.Models;
 using GitHub.Primitives;
 using Octokit.GraphQL;
+using static Octokit.GraphQL.Variable;
 
 namespace GitHub.Services
 {
@@ -18,6 +19,7 @@ public class IssuesAutoCompleteSource : IAutoCompleteSource
     {
         readonly ITeamExplorerContext teamExplorerContext;
         readonly IGraphQLClientFactory graphqlFactory;
+        ICompiledQuery<List<SuggestionItem>> query;
 
         [ImportingConstructor]
         public IssuesAutoCompleteSource(ITeamExplorerContext teamExplorerContext, IGraphQLClientFactory graphqlFactory)
@@ -32,17 +34,32 @@ public IssuesAutoCompleteSource(ITeamExplorerContext teamExplorerContext, IGraph
         public IObservable<AutoCompleteSuggestion> GetSuggestions()
         {
             var localRepositoryModel = teamExplorerContext.ActiveRepository;
-            var query = new Query().Repository(owner: localRepositoryModel.Owner, name: localRepositoryModel.Name)
-                .Select(repository =>
-                    repository.Issues(null, null, null, null, null, null, null)
-                        .AllPages()
-                        .Select(issue => new SuggestionItem("#" + issue.Number, issue.Title))
-                        .ToList());
+
+            var hostAddress = HostAddress.Create(localRepositoryModel.CloneUrl.Host);
+            var owner = localRepositoryModel.Owner;
+            var name = localRepositoryModel.Name;
+
+            if (query == null)
+            {
+                query = new Query().Repository(owner: Var(nameof(owner)), name: Var(nameof(name)))
+                    .Select(repository =>
+                        repository.Issues(null, null, null, null, null, null, null)
+                            .AllPages()
+                            .Select(issue => new SuggestionItem("#" + issue.Number, issue.Title))
+                            .ToList())
+                    .Compile();
+            }
+
+            var variables = new Dictionary<string, object>
+            {
+                {nameof(owner), owner },
+                {nameof(name), name },
+            };
 
             return Observable.FromAsync(async () =>
                 {
-                    var connection = await graphqlFactory.CreateConnection(HostAddress.Create(localRepositoryModel.CloneUrl.Host));
-                    var suggestions = await connection.Run(query);
+                    var connection = await graphqlFactory.CreateConnection(hostAddress);
+                    var suggestions = await connection.Run(query, variables);
                     return suggestions.Select(suggestion => new IssueAutoCompleteSuggestion(suggestion, Prefix));
                 }).SelectMany(enumerable => enumerable);
         }

src/GitHub.App/Services/MentionsAutoCompleteSource.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Collections.Generic;
 using System.ComponentModel.Composition;
 using System.Linq;
 using System.Reactive.Linq;
@@ -10,6 +11,7 @@
 using GitHub.Models;
 using GitHub.Primitives;
 using Octokit.GraphQL;
+using static Octokit.GraphQL.Variable;
 
 namespace GitHub.Services
 {
@@ -23,6 +25,7 @@ public class MentionsAutoCompleteSource : IAutoCompleteSource
         readonly ITeamExplorerContext teamExplorerContext;
         readonly IGraphQLClientFactory graphqlFactory;
         readonly IAvatarProvider avatarProvider;
+        ICompiledQuery<List<SuggestionItem>> query;
 
         [ImportingConstructor]
         public MentionsAutoCompleteSource(ITeamExplorerContext teamExplorerContext, 
@@ -41,20 +44,35 @@ public MentionsAutoCompleteSource(ITeamExplorerContext teamExplorerContext,
         public IObservable<AutoCompleteSuggestion> GetSuggestions()
         {
             var localRepositoryModel = teamExplorerContext.ActiveRepository;
-            var query = new Query().Repository(owner: localRepositoryModel.Owner, name: localRepositoryModel.Name)
+
+            var hostAddress = HostAddress.Create(localRepositoryModel.CloneUrl.Host);
+            var owner = localRepositoryModel.Owner;
+            var name = localRepositoryModel.Name;
+
+            if (query == null)
+            {
+                query = new Query().Repository(owner: Var(nameof(owner)), name: Var(nameof(name)))
                 .Select(repository =>
                     repository.MentionableUsers(null, null, null, null)
                         .AllPages()
                         .Select(sourceItem => 
                             new SuggestionItem(sourceItem.Login, 
                                 sourceItem.Name ?? "(unknown)", 
                                 GetUrlSafe(sourceItem.AvatarUrl(null))))
-                        .ToList());
+                        .ToList())
+                .Compile();
+            }
+
+            var variables = new Dictionary<string, object>
+            {
+                {nameof(owner), owner },
+                {nameof(name), name },
+            };
 
             return Observable.FromAsync(async () =>
             {
-                var connection = await graphqlFactory.CreateConnection(HostAddress.Create(localRepositoryModel.CloneUrl.Host));
-                var suggestions = await connection.Run(query);
+                var connection = await graphqlFactory.CreateConnection(hostAddress);
+                var suggestions = await connection.Run(query, variables);
                 return suggestions.Select(suggestion => new AutoCompleteSuggestion(suggestion.Name,
                     suggestion.Description,
                     ResolveImage(suggestion.IconKey.ToString()),

src/GitHub.Exports.Reactive/ViewModels/GitHubPane/IPullRequestCreationViewModel.cs

@@ -17,7 +17,6 @@ public interface IPullRequestCreationViewModel : IPanePageViewModel
         ReactiveCommand<Unit, Unit> Cancel { get; }
         string PRTitle { get; set; }
         ReactivePropertyValidator TitleValidator { get; }
-        IAutoCompleteAdvisor AutoCompleteAdvisor { get; }
 
         Task InitializeAsync(LocalRepositoryModel repository, IConnection connection);
     }