Add guards to HasChangesInWorkingDirectory

jcansdale · jcansdale · commit 8c5d1f7e9f81 · 2019-01-09T19:56:27.000Z
diff --git a/src/GitHub.App/Services/GitHubContextService.cs b/src/GitHub.App/Services/GitHubContextService.cs
@@ -386,6 +386,10 @@ public string FindObjectishForTFSTempFile(string tempFile)
         /// <inheritdoc/>
         public bool HasChangesInWorkingDirectory(string repositoryDir, string commitish, string path)
         {
+            Guard.ArgumentNotNull(path, nameof(repositoryDir));
+            Guard.ArgumentNotNull(path, nameof(commitish));
+            Guard.ArgumentIsGitPath(path, nameof(path));
+
             using (var repo = gitService.GetRepository(repositoryDir))
             {
                 var commit = repo.Lookup<Commit>(commitish);

Original file line number	Diff line number	Diff line change
`@@ -386,6 +386,10 @@ public string FindObjectishForTFSTempFile(string tempFile)`
`386`	`386`	`/// <inheritdoc/>`
`387`	`387`	`public bool HasChangesInWorkingDirectory(string repositoryDir, string commitish, string path)`
`388`	`388`	`{`
	`389`	`+ Guard.ArgumentNotNull(path, nameof(repositoryDir));`
	`390`	`+ Guard.ArgumentNotNull(path, nameof(commitish));`
	`391`	`+ Guard.ArgumentIsGitPath(path, nameof(path));`
	`392`	`+`
`389`	`393`	`using (var repo = gitService.GetRepository(repositoryDir))`
`390`	`394`	`{`
`391`	`395`	`var commit = repo.Lookup<Commit>(commitish);`