Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit 8ddc0e9

Browse files
committed
Suppress VSTHRD200 for the moment.
We don't currently follow the "Async" suffix pattern for async methods. We may want to revisit this later.
1 parent ba83824 commit 8ddc0e9

File tree

6 files changed

+23
-3
lines changed

6 files changed

+23
-3
lines changed

src/GitHub.InlineReviews/GitHub.InlineReviews.csproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@
5959
<Compile Include="Commands\InlineCommentNavigationCommand.cs" />
6060
<Compile Include="Commands\PreviousInlineCommentCommand.cs" />
6161
<Compile Include="Commands\NextInlineCommentCommand.cs" />
62+
<Compile Include="GlobalSuppressions.cs" />
6263
<Compile Include="Margins\InlineCommentTextViewOptions.cs" />
6364
<Compile Include="Margins\PullRequestFileMargin.cs" />
6465
<Compile Include="Margins\PullRequestFileMarginProvider.cs" />
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+

2+
// This file is used by Code Analysis to maintain SuppressMessage
3+
// attributes that are applied to this project.
4+
// Project-level suppressions either have no target or are given
5+
// a specific target and scoped to a namespace, type, member, etc.
6+
7+
[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Style", "VSTHRD200:Use \"Async\" suffix for async methods")]
8+

src/GitHub.StartPage/GitHub.StartPage.csproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@
5555
<Compile Include="..\common\SolutionInfo.cs">
5656
<Link>Properties\SolutionInfo.cs</Link>
5757
</Compile>
58+
<Compile Include="GlobalSuppressions.cs" />
5859
<Compile Include="Properties\AssemblyInfo.cs" />
5960
<Compile Include="StartPagePackage.cs" />
6061
</ItemGroup>
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+

2+
// This file is used by Code Analysis to maintain SuppressMessage
3+
// attributes that are applied to this project.
4+
// Project-level suppressions either have no target or are given
5+
// a specific target and scoped to a namespace, type, member, etc.
6+
7+
[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Style", "VSTHRD200:Use \"Async\" suffix for async methods")]
8+

src/GitHub.StartPage/StartPagePackage.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,17 +40,17 @@ public class GitHubContainerProvider : ICodeContainerProvider
4040
public async Task<CodeContainer> AcquireCodeContainerAsync(IProgress<ServiceProgressData> downloadProgress, CancellationToken cancellationToken)
4141
{
4242

43-
return await RunAcquisition(downloadProgress, cancellationToken, null);
43+
return await RunAcquisition(downloadProgress, null, cancellationToken);
4444
}
4545

4646
public async Task<CodeContainer> AcquireCodeContainerAsync(RemoteCodeContainer onlineCodeContainer, IProgress<ServiceProgressData> downloadProgress, CancellationToken cancellationToken)
4747
{
4848
var repository = new RepositoryModel(onlineCodeContainer.Name, UriString.ToUriString(onlineCodeContainer.DisplayUrl));
49-
return await RunAcquisition(downloadProgress, cancellationToken, repository);
49+
return await RunAcquisition(downloadProgress, repository, cancellationToken);
5050
}
5151

5252
[System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "cancellationToken")]
53-
async Task<CodeContainer> RunAcquisition(IProgress<ServiceProgressData> downloadProgress, CancellationToken cancellationToken, RepositoryModel repository)
53+
async Task<CodeContainer> RunAcquisition(IProgress<ServiceProgressData> downloadProgress, RepositoryModel repository, CancellationToken cancellationToken)
5454
{
5555
CloneDialogResult request = null;
5656

src/GitHub.VisualStudio/GlobalSuppressions.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,3 +9,5 @@
99
// file manually.
1010

1111
[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Naming", "CA1701:ResourceStringCompoundWordsShouldBeCasedCorrectly", MessageId = "GitHub", Scope = "resource", Target = "VSPackage.resources")]
12+
[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Style", "VSTHRD200:Use \"Async\" suffix for async methods")]
13+

0 commit comments

Comments
 (0)