Adding a CanEditOrDelete property

Author: StanleyGoldman

src/GitHub.InlineReviews/SampleData/CommentViewModelDesigner.cs

@@ -24,6 +24,7 @@ public CommentViewModelDesigner()
         public CommentEditState EditState { get; set; }
         public bool IsReadOnly { get; set; }
         public bool IsSubmitting { get; set; }
+        public bool CanEditOrDelete { get; } = true;
         public ICommentThreadViewModel Thread { get; }
         public DateTimeOffset UpdatedAt => DateTime.Now.Subtract(TimeSpan.FromDays(3));
         public IAccount User { get; set; }

src/GitHub.InlineReviews/ViewModels/CommentViewModel.cs

@@ -24,6 +24,7 @@ public class CommentViewModel : ReactiveObject, ICommentViewModel
         CommentEditState state;
         DateTimeOffset updatedAt;
         string undoBody;
+        private bool canEditOrDelete;
 
         /// <summary>
         /// Initializes a new instance of the <see cref="CommentViewModel"/> class.
@@ -60,17 +61,15 @@ protected CommentViewModel(
             User = user;
             UpdatedAt = updatedAt;
 
-            var canDelete = this.WhenAnyValue(
+            var canEditOrDeleteObservable = this.WhenAnyValue(
                 x => x.EditState,
                 x => x == CommentEditState.None && user.Login.Equals(currentUser.Login));
 
-            Delete = ReactiveCommand.CreateAsyncTask(canDelete, DoDelete);
+            canEditOrDeleteObservable.Subscribe(b => CanEditOrDelete = b);
 
-            var canEdit = this.WhenAnyValue(
-                x => x.EditState,
-                x => x == CommentEditState.None && user.Login.Equals(currentUser.Login));
+            Delete = ReactiveCommand.CreateAsyncTask(canEditOrDeleteObservable, DoDelete);
 
-            BeginEdit = ReactiveCommand.Create(canEdit);
+            BeginEdit = ReactiveCommand.Create(canEditOrDeleteObservable);
             BeginEdit.Subscribe(DoBeginEdit);
             AddErrorHandler(BeginEdit);
 
@@ -283,6 +282,12 @@ public bool IsSubmitting
             protected set { this.RaiseAndSetIfChanged(ref isSubmitting, value); }
         }
 
+        public bool CanEditOrDelete
+        {
+            get { return canEditOrDelete; }
+            private set { this.RaiseAndSetIfChanged(ref canEditOrDelete, value); }
+        }
+
         /// <inheritdoc/>
         public DateTimeOffset UpdatedAt
         {

src/GitHub.InlineReviews/ViewModels/ICommentViewModel.cs

@@ -55,6 +55,11 @@ public interface ICommentViewModel : IViewModel
         /// </summary>
         bool IsSubmitting { get; }
 
+        /// <summary>
+        /// Gets a value indicating whether the comment can be edited or deleted by the current user
+        /// </summary>
+        bool CanEditOrDelete { get; }
+
         /// <summary>
         /// Gets the modified date of the comment.
         /// </summary>

src/GitHub.InlineReviews/Views/CommentView.xaml

@@ -12,7 +12,7 @@
              xmlns:views="clr-namespace:GitHub.InlineReviews.Views"
              mc:Ignorable="d" d:DesignWidth="300">
     <d:DesignProperties.DataContext>
-        <sample:CommentViewModelDesigner EditState="Editing">
+        <sample:CommentViewModelDesigner EditState="None">
             <sample:CommentViewModelDesigner.Body>
                 You can use a `CompositeDisposable` type here, it's designed to handle disposables in an optimal way (you can just call `Dispose()` on it and it will handle disposing everything it holds).
             </sample:CommentViewModelDesigner.Body>
@@ -51,46 +51,45 @@
             </StackPanel.Style>
 
             <DockPanel>
+
+              <StackPanel Orientation="Horizontal" DockPanel.Dock="Left" >
                 <controls:AccountAvatar Width="16" 
-                                        Height="16" 
-                                        Account="{Binding User}"
-                                        DockPanel.Dock="Left" />
+                                Height="16" 
+                                Account="{Binding User}"/>
 
-                <TextBlock Foreground="{DynamicResource GitHubVsToolWindowText}" FontWeight="Bold" Text="{Binding User.Login}" Margin="4 0"
-                           DockPanel.Dock="Left" />
+                <TextBlock Foreground="{DynamicResource GitHubVsToolWindowText}" FontWeight="Bold" Text="{Binding User.Login}" Margin="4 0"/>
                 <ui:GitHubActionLink Content="{Binding UpdatedAt, Converter={ui:DurationToStringConverter}}"
-                                     Command="{Binding OpenOnGitHub}"
-                                     Foreground="{DynamicResource GitHubVsToolWindowText}"
-                                     Opacity="0.75"
-                                     DockPanel.Dock="Left"  />
+                             Command="{Binding OpenOnGitHub}"
+                             Foreground="{DynamicResource GitHubVsToolWindowText}"
+                             Opacity="0.75" />
                 <Border Background="{DynamicResource VsBrush.InfoBackground}"
                         BorderBrush="{DynamicResource VsBrush.AccentPale}"
                         BorderThickness="1"
                         CornerRadius="3"
                         Padding="2 1"
-                        DockPanel.Dock="Left" 
                         Visibility="{Binding IsPending, Converter={ui:BooleanToVisibilityConverter}, FallbackValue=Collapsed}">
-                    <TextBlock FontSize="10">Pending</TextBlock>
+                  <TextBlock FontSize="10">Pending</TextBlock>
                 </Border>
-                <ui:GitHubActionLink Content="Delete"
-                                     Command="{Binding Delete}"
-                                     Foreground="{DynamicResource GitHubVsToolWindowText}"
-                                     Opacity="0.75"
-                                     HorizontalAlignment="Right"
-                                     DockPanel.Dock="Right"/>
+              </StackPanel>
+
+              <StackPanel Orientation="Horizontal" HorizontalAlignment="Right" DockPanel.Dock="Right"
+                          Visibility="{Binding CanEditOrDelete, Converter={ui:BooleanToVisibilityConverter}}">
                 <ui:GitHubActionLink Content="Edit"
                                      Command="{Binding BeginEdit}"
                                      Foreground="{DynamicResource GitHubVsToolWindowText}"
-                                     Opacity="0.75" 
-                                     HorizontalAlignment="Right"
-                                     DockPanel.Dock="Right" />
-            </DockPanel>
+                                     Opacity="0.75" />
+                <ui:GitHubActionLink Content="Delete"
+                                     Command="{Binding Delete}"
+                                     Foreground="{DynamicResource GitHubVsToolWindowText}"
+                                     Opacity="0.75"/>
+              </StackPanel>
 
+            </DockPanel>
 
             <markdig:MarkdownViewer Grid.Column="1" Grid.Row="1" 
-                                    Margin="0 2 0 0"
-                                    Foreground="{DynamicResource VsBrush.WindowText}"
-                                    Markdown="{Binding Body}"/>
+                                          Margin="0 2 0 0"
+                                          Foreground="{DynamicResource VsBrush.WindowText}"
+                                          Markdown="{Binding Body}"/>
         </StackPanel>
 
         <!-- Displays edit view or a reply placeholder-->