Fix tests

Author: shana

test/TrackingCollectionTests/Properties/AssemblyInfo.cs

@@ -36,4 +36,4 @@
 [assembly: AssemblyVersion("1.0.0.0")]
 [assembly: AssemblyFileVersion("1.0.0.0")]
 
-[assembly: Timeout(2000)]
+[assembly: Timeout(2 /*minutes*/ *60*1000)]

test/UnitTests/GitHub.App/ViewModels/Dialog/RepositoryCloneViewModelTests.cs

@@ -14,6 +14,7 @@
 using GitHub.Factories;
 using GitHub.Primitives;
 using GitHub.ViewModels.Dialog;
+using System.Diagnostics;
 
 public class RepositoryCloneViewModelTests
 {
@@ -104,14 +105,14 @@ public async Task StartsTrueBecomesFalseWhenCompleted()
             repoSubject.OnNext(Substitute.For<IRemoteRepositoryModel>());
             repoSubject.OnNext(Substitute.For<IRemoteRepositoryModel>());
 
-            await done.Timeout(TimeSpan.FromMilliseconds(500));
+            await done.Timeout(TimeSpan.FromMilliseconds(Timeout));
             done = null;
 
             Assert.True(vm.IsBusy);
 
             repoSubject.OnCompleted();
 
-            await col.OriginalCompleted.Timeout(TimeSpan.FromMilliseconds(Timeout));;
+            await col.OriginalCompleted.Timeout(TimeSpan.FromMilliseconds(Timeout));
 
             // we need to wait slightly because the subscription OnComplete in the model
             // runs right after the above await finishes, which means the assert
@@ -211,7 +212,7 @@ public void IsFalseWhenFailed()
         }
 
         [Test]
-        public void IsTrueWhenLoadingCompleteNotFailedAndNoRepositories()
+        public async Task IsTrueWhenLoadingCompleteNotFailedAndNoRepositories()
         {
             var repoSubject = new Subject<IRemoteRepositoryModel>();
             var modelService = Substitute.For<IModelService>();
@@ -226,6 +227,9 @@ public void IsTrueWhenLoadingCompleteNotFailedAndNoRepositories()
 
             repoSubject.OnCompleted();
 
+            // we need to delay slightly because the subscribers listening for OnComplete
+            // need to run before the assert is checked
+            await Task.Delay(100);
             Assert.True(vm.NoRepositoriesFound);
         }
     }
@@ -273,7 +277,7 @@ public void IsFalseIfLoadingReposFails()
         }
 
         [Test]
-        public void IsFalseWhenLoadingCompleteNotFailedAndNoRepositories()
+        public async Task IsFalseWhenLoadingCompleteNotFailedAndNoRepositories()
         {
             var repoSubject = new Subject<IRemoteRepositoryModel>();
             var modelService = Substitute.For<IModelService>();
@@ -288,6 +292,9 @@ public void IsFalseWhenLoadingCompleteNotFailedAndNoRepositories()
 
             repoSubject.OnCompleted();
 
+            // we need to delay slightly because the subscribers listening for OnComplete
+            // need to run before the assert is checked
+            await Task.Delay(100);
             Assert.False(vm.FilterTextIsEnabled);
         }
     }

test/UnitTests/Properties/AssemblyInfo.cs

@@ -12,4 +12,4 @@
 // The following GUID is for the ID of the typelib if this project is exposed to COM
 [assembly: Guid("7c0cb7e5-6c7b-4f11-8454-9e1a4747641c")]
 
-[assembly: Timeout(2000)]
+[assembly: Timeout(2 /*minutes*/ *60*1000)]