Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit 9394406

Browse files
committed
Added comment about getting ILoginManager service.
1 parent decaa29 commit 9394406

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

src/GitHub.VisualStudio/GitHubPackage.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -210,6 +210,8 @@ async Task<object> CreateService(IAsyncServiceContainer container, CancellationT
210210
}
211211
else if (serviceType == typeof(ILoginManager))
212212
{
213+
// These services are got through MEF and we will take a performance hit if ILoginManager is requested during
214+
// InitializeAsync. TODO: We can probably make LoginManager a normal MEF component rather than a service.
213215
var serviceProvider = await GetServiceAsync(typeof(IGitHubServiceProvider)) as IGitHubServiceProvider;
214216
var keychain = serviceProvider.GetService<IKeychain>();
215217
var oauthListener = serviceProvider.GetService<IOAuthCallbackListener>();

0 commit comments

Comments
 (0)