Rename repo path validation in resx to share between creation and clone

Author: Jasmine

src/GitHub.App/Resources.Designer.cs

@@ -180,13 +180,16 @@
   <data name="RepositoryCloneFailedNoSelectedRepo" xml:space="preserve">
     <value>No selected repository.</value>
   </data>
-  <data name="RepositoryClonePathInvalid" xml:space="preserve">
+  <data name="RepositoryCreationClonePathEmpty" xml:space="preserve">
+    <value>Please enter a repository path</value>
+  </data>
+  <data name="RepositoryCreationClonePathInvalid" xml:space="preserve">
     <value>Please enter a valid path</value>
   </data>
-  <data name="RepositoryClonePathInvalidCharacters" xml:space="preserve">
+  <data name="RepositoryCreationClonePathInvalidCharacters" xml:space="preserve">
     <value>Path contains invalid characters</value>
   </data>
-  <data name="RepositoryClonePathTooLong" xml:space="preserve">
+  <data name="RepositoryCreationClonePathTooLong" xml:space="preserve">
     <value>Path too long</value>
   </data>
   <data name="RepositoryCreationFailedAlreadyExists" xml:space="preserve">
@@ -198,9 +201,6 @@
   <data name="RepositoryCreationFailedQuota" xml:space="preserve">
     <value>Exceeded private repositories quota.</value>
   </data>
-  <data name="RepositoryCreationPathEmpty" xml:space="preserve">
-    <value>Please enter a repository path</value>
-  </data>
   <data name="RepositoryNameValidatorAlreadyExists" xml:space="preserve">
     <value>Repository with same name already exists at this location</value>
   </data>

src/GitHub.App/Resources.resx

@@ -93,10 +93,10 @@ public RepositoryCloneViewModel(
                 (x, y) => x.Value);
 
             BaseRepositoryPathValidator = ReactivePropertyValidator.ForObservable(baseRepositoryPath)
-                .IfNullOrEmpty(Resources.RepositoryCreationPathEmpty)
-                .IfTrue(x => x.Length > 200, Resources.RepositoryClonePathTooLong)
-                .IfContainsInvalidPathChars(Resources.RepositoryClonePathInvalidCharacters)
-                .IfPathNotRooted(Resources.RepositoryClonePathInvalid)
+                .IfNullOrEmpty(Resources.RepositoryCreationClonePathEmpty)
+                .IfTrue(x => x.Length > 200, Resources.RepositoryCreationClonePathTooLong)
+                .IfContainsInvalidPathChars(Resources.RepositoryCreationClonePathInvalidCharacters)
+                .IfPathNotRooted(Resources.RepositoryCreationClonePathInvalid)
                 .IfTrue(IsAlreadyRepoAtPath, Resources.RepositoryNameValidatorAlreadyExists);
 
             var canCloneObservable = this.WhenAny(

src/GitHub.App/ViewModels/RepositoryCloneViewModel.cs

@@ -76,10 +76,10 @@ public RepositoryCreationViewModel(
             browseForDirectoryCommand.Subscribe(_ => ShowBrowseForDirectoryDialog());
 
             BaseRepositoryPathValidator = ReactivePropertyValidator.ForObservable(this.WhenAny(x => x.BaseRepositoryPath, x => x.Value))
-                .IfNullOrEmpty("Please enter a repository path")
-                .IfTrue(x => x.Length > 200, "Path too long")
-                .IfContainsInvalidPathChars("Path contains invalid characters")
-                .IfPathNotRooted("Please enter a valid path");
+                .IfNullOrEmpty(Resources.RepositoryCreationClonePathEmpty)
+                .IfTrue(x => x.Length > 200, Resources.RepositoryCreationClonePathTooLong)
+                .IfContainsInvalidPathChars(Resources.RepositoryCreationClonePathInvalidCharacters)
+                .IfPathNotRooted(Resources.RepositoryCreationClonePathInvalid);
 
             var nonNullRepositoryName = this.WhenAny(
                 x => x.RepositoryName,