Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit 95ec3f8

Browse files
grokysgrokys
committed
Removed code analysis.
Upgrading to `<ProjectReference>` has added analyzers, so we no longer want to use the old code analysis tool.
1 parent 3453a4e commit 95ec3f8

File tree

8 files changed

+10
-223
lines changed

8 files changed

+10
-223
lines changed

‎GitHubVS.sln‎

Lines changed: 0 additions & 83 deletions
Large diffs are not rendered by default.

‎src/GitHub.InlineReviews/GitHub.InlineReviews.csproj‎

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,7 @@
2828
<IncludeDebugSymbolsInLocalVSIXDeployment>true</IncludeDebugSymbolsInLocalVSIXDeployment>
2929
<CopyBuildOutputToOutputDirectory>true</CopyBuildOutputToOutputDirectory>
3030
<CopyOutputSymbolsToOutputDirectory>true</CopyOutputSymbolsToOutputDirectory>
31-
<CodeAnalysisRuleSet>..\common\GitHubVS.ruleset</CodeAnalysisRuleSet>
32-
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
31+
<TreatWarningsAsErrors>false</TreatWarningsAsErrors>
3332
<CodeAnalysisIgnoreGeneratedCode>true</CodeAnalysisIgnoreGeneratedCode>
3433
<CreateVsixContainer>False</CreateVsixContainer>
3534
<DeployExtension>False</DeployExtension>
@@ -45,21 +44,14 @@
4544
<OutputPath>bin\Debug\</OutputPath>
4645
<TreatWarningsAsErrors>false</TreatWarningsAsErrors>
4746
</PropertyGroup>
48-
<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'DebugCodeAnalysis|AnyCPU'">
49-
<Optimize>false</Optimize>
50-
<DefineConstants>TRACE;DEBUG;CODE_ANALYSIS</DefineConstants>
51-
<ErrorReport>prompt</ErrorReport>
52-
<WarningLevel>4</WarningLevel>
53-
<RunCodeAnalysis>true</RunCodeAnalysis>
54-
<OutputPath>bin\Debug\</OutputPath>
55-
</PropertyGroup>
5647
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
5748
<Optimize>true</Optimize>
5849
<DefineConstants>TRACE</DefineConstants>
5950
<ErrorReport>prompt</ErrorReport>
6051
<WarningLevel>4</WarningLevel>
61-
<RunCodeAnalysis>true</RunCodeAnalysis>
52+
<RunCodeAnalysis>false</RunCodeAnalysis>
6253
<OutputPath>bin\Release\</OutputPath>
54+
<TreatWarningsAsErrors>false</TreatWarningsAsErrors>
6355
</PropertyGroup>
6456
<Import Project="$(SolutionDir)\src\common\signing.props" />
6557
<ItemGroup>

‎src/GitHub.StartPage/GitHub.StartPage.csproj‎

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
<IncludeDebugSymbolsInLocalVSIXDeployment>true</IncludeDebugSymbolsInLocalVSIXDeployment>
2929
<CopyBuildOutputToOutputDirectory>true</CopyBuildOutputToOutputDirectory>
3030
<CopyOutputSymbolsToOutputDirectory>true</CopyOutputSymbolsToOutputDirectory>
31-
<CodeAnalysisRuleSet>..\common\GitHubVS.ruleset</CodeAnalysisRuleSet>
3231
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
3332
<CodeAnalysisIgnoreGeneratedCode>true</CodeAnalysisIgnoreGeneratedCode>
3433
<CreateVsixContainer>False</CreateVsixContainer>
@@ -45,22 +44,12 @@
4544
<OutputPath>bin\Debug\</OutputPath>
4645
<TreatWarningsAsErrors>false</TreatWarningsAsErrors>
4746
</PropertyGroup>
48-
<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'DebugCodeAnalysis|AnyCPU'">
49-
<DebugSymbols>true</DebugSymbols>
50-
<DebugType>full</DebugType>
51-
<Optimize>false</Optimize>
52-
<DefineConstants>TRACE;DEBUG;CODE_ANALYSIS</DefineConstants>
53-
<ErrorReport>prompt</ErrorReport>
54-
<WarningLevel>4</WarningLevel>
55-
<RunCodeAnalysis>true</RunCodeAnalysis>
56-
<OutputPath>bin\Debug\</OutputPath>
57-
</PropertyGroup>
5847
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
5948
<Optimize>true</Optimize>
6049
<DefineConstants>TRACE</DefineConstants>
6150
<ErrorReport>prompt</ErrorReport>
6251
<WarningLevel>4</WarningLevel>
63-
<RunCodeAnalysis>true</RunCodeAnalysis>
52+
<RunCodeAnalysis>false</RunCodeAnalysis>
6453
<OutputPath>bin\Release\</OutputPath>
6554
</PropertyGroup>
6655
<ItemGroup>

‎src/GitHub.TeamFoundation.14/GitHub.TeamFoundation.14.csproj‎

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
<LangVersion>7.3</LangVersion>
1515
<TargetFrameworkVersion>v4.6.1</TargetFrameworkVersion>
1616
<FileAlignment>512</FileAlignment>
17-
<CodeAnalysisRuleSet>..\common\GitHubVS.ruleset</CodeAnalysisRuleSet>
1817
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
1918
<CodeAnalysisIgnoreGeneratedCode>true</CodeAnalysisIgnoreGeneratedCode>
2019
<NuGetPackageImportStamp>
@@ -31,23 +30,13 @@
3130
<OutputPath>bin\Debug\</OutputPath>
3231
<TreatWarningsAsErrors>false</TreatWarningsAsErrors>
3332
</PropertyGroup>
34-
<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'DebugCodeAnalysis|AnyCPU'">
35-
<DebugSymbols>true</DebugSymbols>
36-
<DebugType>full</DebugType>
37-
<Optimize>false</Optimize>
38-
<DefineConstants>CODE_ANALYSIS;DEBUG;TRACE;TEAMEXPLORER14</DefineConstants>
39-
<ErrorReport>prompt</ErrorReport>
40-
<WarningLevel>4</WarningLevel>
41-
<RunCodeAnalysis>true</RunCodeAnalysis>
42-
<OutputPath>bin\Debug\</OutputPath>
43-
</PropertyGroup>
4433
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
4534
<DebugType>full</DebugType>
4635
<Optimize>true</Optimize>
4736
<DefineConstants>TRACE;TEAMEXPLORER14</DefineConstants>
4837
<ErrorReport>prompt</ErrorReport>
4938
<WarningLevel>4</WarningLevel>
50-
<RunCodeAnalysis>true</RunCodeAnalysis>
39+
<RunCodeAnalysis>false</RunCodeAnalysis>
5140
<OutputPath>bin\Release\</OutputPath>
5241
<DebugSymbols>true</DebugSymbols>
5342
</PropertyGroup>

‎src/GitHub.TeamFoundation.15/GitHub.TeamFoundation.15.csproj‎

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
<LangVersion>7.3</LangVersion>
1515
<TargetFrameworkVersion>v4.6.1</TargetFrameworkVersion>
1616
<FileAlignment>512</FileAlignment>
17-
<CodeAnalysisRuleSet>..\common\GitHubVS.ruleset</CodeAnalysisRuleSet>
1817
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
1918
<CodeAnalysisIgnoreGeneratedCode>true</CodeAnalysisIgnoreGeneratedCode>
2019
<NuGetPackageImportStamp>
@@ -31,20 +30,12 @@
3130
<OutputPath>bin\Debug\</OutputPath>
3231
<TreatWarningsAsErrors>false</TreatWarningsAsErrors>
3332
</PropertyGroup>
34-
<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'DebugCodeAnalysis|AnyCPU'">
35-
<Optimize>false</Optimize>
36-
<DefineConstants>CODE_ANALYSIS;DEBUG;TRACE;TEAMEXPLORER15</DefineConstants>
37-
<ErrorReport>prompt</ErrorReport>
38-
<WarningLevel>4</WarningLevel>
39-
<RunCodeAnalysis>true</RunCodeAnalysis>
40-
<OutputPath>bin\Debug\</OutputPath>
41-
</PropertyGroup>
4233
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
4334
<Optimize>true</Optimize>
4435
<DefineConstants>TRACE;TEAMEXPLORER15</DefineConstants>
4536
<ErrorReport>prompt</ErrorReport>
4637
<WarningLevel>4</WarningLevel>
47-
<RunCodeAnalysis>true</RunCodeAnalysis>
38+
<RunCodeAnalysis>false</RunCodeAnalysis>
4839
<OutputPath>bin\Release\</OutputPath>
4940
</PropertyGroup>
5041
<Import Project="$(SolutionDir)\src\common\signing.props" />

‎src/GitHub.TeamFoundation.16/GitHub.TeamFoundation.16.csproj‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,7 @@
1414
<LangVersion>7.3</LangVersion>
1515
<TargetFrameworkVersion>v4.6.1</TargetFrameworkVersion>
1616
<FileAlignment>512</FileAlignment>
17-
<CodeAnalysisRuleSet>..\common\GitHubVS.ruleset</CodeAnalysisRuleSet>
18-
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
17+
<TreatWarningsAsErrors>false</TreatWarningsAsErrors>
1918
<CodeAnalysisIgnoreGeneratedCode>true</CodeAnalysisIgnoreGeneratedCode>
2019
<NuGetPackageImportStamp>
2120
</NuGetPackageImportStamp>
@@ -36,7 +35,7 @@
3635
<DefineConstants>TRACE;DEBUG;CODE_ANALYSIS;CODE_ANALYSIS;TEAMEXPLORER16</DefineConstants>
3736
<ErrorReport>prompt</ErrorReport>
3837
<WarningLevel>4</WarningLevel>
39-
<RunCodeAnalysis>true</RunCodeAnalysis>
38+
<RunCodeAnalysis>false</RunCodeAnalysis>
4039
<OutputPath>bin\Debug\</OutputPath>
4140
</PropertyGroup>
4241
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">

‎src/GitHub.VisualStudio/GitHub.VisualStudio.csproj‎

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@
3030
<LangVersion>7.3</LangVersion>
3131
<TargetFrameworkVersion>v4.6.1</TargetFrameworkVersion>
3232
<ZipPackageCompressionLevel>Normal</ZipPackageCompressionLevel>
33-
<CodeAnalysisRuleSet>..\common\GitHubVS.ruleset</CodeAnalysisRuleSet>
3433
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
3534
<CodeAnalysisIgnoreGeneratedCode>true</CodeAnalysisIgnoreGeneratedCode>
3635
<IncludeDebugSymbolsInVSIXContainer>true</IncludeDebugSymbolsInVSIXContainer>
@@ -51,16 +50,6 @@
5150
<DebugType>full</DebugType>
5251
<TreatWarningsAsErrors>false</TreatWarningsAsErrors>
5352
</PropertyGroup>
54-
<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'DebugCodeAnalysis|AnyCPU'">
55-
<Optimize>false</Optimize>
56-
<DefineConstants>TRACE;DEBUG;CODE_ANALYSIS</DefineConstants>
57-
<ErrorReport>prompt</ErrorReport>
58-
<WarningLevel>4</WarningLevel>
59-
<RunCodeAnalysis>true</RunCodeAnalysis>
60-
<CreateVsixContainer>True</CreateVsixContainer>
61-
<DeployExtension>True</DeployExtension>
62-
<OutputPath>..\..\build\Debug\</OutputPath>
63-
</PropertyGroup>
6453
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'DebugWithoutVsix|AnyCPU' ">
6554
<Optimize>false</Optimize>
6655
<DefineConstants>TRACE;DEBUG;CODE_ANALYSIS</DefineConstants>
@@ -76,7 +65,7 @@
7665
<DefineConstants>TRACE</DefineConstants>
7766
<ErrorReport>prompt</ErrorReport>
7867
<WarningLevel>4</WarningLevel>
79-
<RunCodeAnalysis>true</RunCodeAnalysis>
68+
<RunCodeAnalysis>false</RunCodeAnalysis>
8069
<CreateVsixContainer>True</CreateVsixContainer>
8170
<DeployExtension>True</DeployExtension>
8271
<OutputPath>..\..\build\Release\</OutputPath>
@@ -87,7 +76,7 @@
8776
<DefineConstants>TRACE</DefineConstants>
8877
<ErrorReport>prompt</ErrorReport>
8978
<WarningLevel>4</WarningLevel>
90-
<RunCodeAnalysis>true</RunCodeAnalysis>
79+
<RunCodeAnalysis>false</RunCodeAnalysis>
9180
<CreateVsixContainer>False</CreateVsixContainer>
9281
<DeployExtension>False</DeployExtension>
9382
<OutputPath>..\..\build\Release\</OutputPath>

‎src/common/GitHubVS.ruleset‎

Lines changed: 0 additions & 79 deletions
This file was deleted.

0 commit comments

Comments
 (0)