Addressing feedback

Author: StanleyGoldman

src/GitHub.App/SampleData/CommentThreadViewModelDesigner.cs

@@ -75,7 +75,7 @@ public CommentThreadViewModelDesigner()
         public IReadOnlyReactiveList<ICommentViewModel> Comments { get; }
             = new ReactiveList<ICommentViewModel>();
 
-        public IReadOnlyList<IInlineAnnotationViewModel> Annotations { get; }
+        public IReadOnlyCollection<IInlineAnnotationViewModel> Annotations { get; }
 
         public IActorViewModel CurrentUser { get; set; }
             = new ActorViewModel { Login = "shana" };

src/GitHub.App/ViewModels/CommentThreadViewModel.cs

@@ -58,7 +58,7 @@ public CommentThreadViewModel(
         public IActorViewModel CurrentUser { get; private set; }
 
         /// <inheritdoc/>
-        public IReadOnlyList<IInlineAnnotationViewModel> Annotations { get; private set; }
+        public IReadOnlyCollection<IInlineAnnotationViewModel> Annotations { get; private set; }
 
         /// <inheritdoc/>
         IReadOnlyReactiveList<ICommentViewModel> ICommentThreadViewModel.Comments => comments;
@@ -96,7 +96,7 @@ protected IDisposable AddPlaceholder(ICommentViewModel placeholder)
         /// </summary>
         /// <param name="currentUser">The current user.</param>
         /// <param name="annotations"></param>
-        protected Task InitializeAsync(ActorModel currentUser, IReadOnlyList<IInlineAnnotationViewModel> annotations)
+        protected Task InitializeAsync(ActorModel currentUser, IReadOnlyCollection<IInlineAnnotationViewModel> annotations)
         {
             Annotations = annotations;
             Guard.ArgumentNotNull(currentUser, nameof(currentUser));

src/GitHub.App/ViewModels/PullRequestReviewCommentThreadViewModel.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Collections.Generic;
 using System.ComponentModel.Composition;
 using System.Globalization;
 using System.Linq;
@@ -75,9 +76,8 @@ public bool IsNewThread
         public bool NeedsPush => needsPush.Value;
 
         /// <inheritdoc/>
-        public async Task InitializeAsync(
-            IPullRequestSession session,
-            IInlineAnnotationViewModel[] annotations,
+        public async Task InitializeAsync(IPullRequestSession session,
+            IReadOnlyCollection<IInlineAnnotationViewModel> annotations,
             IPullRequestSessionFile file,
             IInlineCommentThreadModel thread,
             bool addPlaceholder)

src/GitHub.Exports.Reactive/ViewModels/ICommentThreadViewModel.cs

@@ -41,6 +41,6 @@ public interface ICommentThreadViewModel : IViewModel
         /// <summary>
         /// Gets the annotations displayed.
         /// </summary>
-        IReadOnlyList<IInlineAnnotationViewModel> Annotations { get; }
+        IReadOnlyCollection<IInlineAnnotationViewModel> Annotations { get; }
     }
 }

src/GitHub.Exports.Reactive/ViewModels/IPullRequestReviewCommentThreadViewModel.cs

@@ -1,4 +1,5 @@
-using System.Threading.Tasks;
+using System.Collections.Generic;
+using System.Threading.Tasks;
 using GitHub.Models;
 using GitHub.Services;
 
@@ -45,14 +46,14 @@ public interface IPullRequestReviewCommentThreadViewModel : ICommentThreadViewMo
         /// Initializes the view model with data.
         /// </summary>
         /// <param name="session">The pull request session.</param>
+        /// <param name="annotations"></param>
         /// <param name="file">The file that the comment is on.</param>
         /// <param name="thread">The thread.</param>
         /// <param name="addPlaceholder">
-        /// Whether to add a placeholder comment at the end of the thread.
+        ///     Whether to add a placeholder comment at the end of the thread.
         /// </param>
-        Task InitializeAsync(
-            IPullRequestSession session,
-            IInlineAnnotationViewModel[] annotations,
+        Task InitializeAsync(IPullRequestSession session,
+            IReadOnlyCollection<IInlineAnnotationViewModel> annotations,
             IPullRequestSessionFile file,
             IInlineCommentThreadModel thread,
             bool addPlaceholder);

src/GitHub.InlineReviews/Tags/InlineCommentTagger.cs

@@ -110,8 +110,7 @@ public IEnumerable<ITagSpan<InlineCommentTag>> GetTags(NormalizedSnapshotSpanCol
                         var snapshot = span.Snapshot;
                         var snapshotLine = snapshot.GetLineFromLineNumber(line);
 
-                        IInlineCommentThreadModel thread;
-                        if (spanThreadsByLine.TryGetValue(line, out thread))
+                        if (spanThreadsByLine.TryGetValue(line, out var thread))
                         {
                             var isThreadDeleteSide = thread.DiffLineType == DiffChangeType.Delete;
                             var sidesMatch = side == DiffSide.Left && isThreadDeleteSide || side == DiffSide.Right && !isThreadDeleteSide;