Merge pull request #1177 from github/fixes/1173-create-git-credential

Create the `git:` credential on login.

Author: grokys

src/GitHub.Api/WindowsLoginCache.cs

@@ -39,8 +39,14 @@ public Task SaveLogin(string userName, string password, HostAddress hostAddress)
             Guard.ArgumentNotEmptyString(password, nameof(password));
             Guard.ArgumentNotNull(hostAddress, nameof(hostAddress));
 
+            var keyGit = GetKeyGit(hostAddress.CredentialCacheKeyHost);
             var keyHost = GetKeyHost(hostAddress.CredentialCacheKeyHost);
 
+            using (var credential = new Credential(userName, password, keyGit))
+            {
+                credential.Save();
+            }
+
             using (var credential = new Credential(userName, password, keyHost))
             {
                 credential.Save();
@@ -54,8 +60,16 @@ public Task EraseLogin(HostAddress hostAddress)
         {
             Guard.ArgumentNotNull(hostAddress, nameof(hostAddress));
 
+            var keyGit = GetKeyGit(hostAddress.CredentialCacheKeyHost);
             var keyHost = GetKeyHost(hostAddress.CredentialCacheKeyHost);
 
+            using (var credential = new Credential())
+            {
+                credential.Target = keyGit;
+                credential.Type = CredentialType.Generic;
+                credential.Delete();
+            }
+
             using (var credential = new Credential())
             {
                 credential.Target = keyHost;
@@ -66,6 +80,17 @@ public Task EraseLogin(HostAddress hostAddress)
             return Task.CompletedTask;
         }
 
+        static string GetKeyGit(string key)
+        {
+            key = FormatKey(key);
+            // it appears this is how MS expects the host key
+            if (!key.StartsWith("git:", StringComparison.Ordinal))
+                key = "git:" + key;
+            if (key.EndsWith("/", StringComparison.Ordinal))
+                key = key.Substring(0, key.Length - 1);
+            return key;
+        }
+
         static string GetKeyHost(string key)
         {
             key = FormatKey(key);