Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit 9aa3715

Browse files
committed
Stop test failing when task is canceled
NCrunch tests fail when a background task is canceled. This commit awaits and catches the TaskCanceledException.
1 parent f03b1ec commit 9aa3715

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

test/GitHub.App.UnitTests/ViewModels/Dialog/LoginToGitHubForEnterpriseViewModelTests.cs

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ public void InvalidUrlReturnsNone()
2525
}
2626

2727
[Test]
28-
public void ReturnsCheckingWhenProbeNotFinished()
28+
public async Task ReturnsCheckingWhenProbeNotFinished()
2929
{
3030
var scheduler = new TestScheduler();
3131
var caps = Substitute.For<IEnterpriseCapabilitiesService>();
@@ -37,7 +37,13 @@ public void ReturnsCheckingWhenProbeNotFinished()
3737
scheduler.AdvanceBy(TimeSpan.FromMilliseconds(500).Ticks);
3838

3939
Assert.That(EnterpriseProbeStatus.Checking, Is.EqualTo(target.ProbeStatus));
40-
task.SetCanceled();
40+
41+
try
42+
{
43+
task.SetCanceled();
44+
await task.Task;
45+
}
46+
catch (TaskCanceledException) { }
4147
}
4248

4349
[Test]
@@ -126,7 +132,7 @@ public void ReturnsUsernameAndPassword()
126132
public void GivesPrecedenceToUsernameAndPasswordOverToken()
127133
{
128134
var scheduler = new TestScheduler();
129-
var caps = CreateCapabilties(EnterpriseLoginMethods.Token |
135+
var caps = CreateCapabilties(EnterpriseLoginMethods.Token |
130136
EnterpriseLoginMethods.UsernameAndPassword |
131137
EnterpriseLoginMethods.OAuth);
132138
var target = CreateTarget(scheduler, caps);

0 commit comments

Comments
 (0)