Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit a192f69

Browse files
committed
Avoid potential ObjectDisposedException.
Don't try to update the PR list filter when the collection has been disposed.
1 parent 57faea9 commit a192f69

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

src/GitHub.App/ViewModels/GitHubPane/PullRequestListViewModel.cs

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -193,12 +193,15 @@ void UpdateFilter(PullRequestState state, IAccount ass, IAccount aut, string fil
193193
filterTextIsString = hasText && !filterTextIsNumber;
194194
}
195195

196-
pullRequests.Filter = (pullRequest, index, list) =>
197-
(!state.IsOpen.HasValue || state.IsOpen == pullRequest.IsOpen) &&
198-
(ass == null || ass.Equals(pullRequest.Assignee)) &&
199-
(aut == null || aut.Equals(pullRequest.Author)) &&
200-
(filterTextIsNumber == false || pullRequest.Number == filterPullRequestNumber) &&
201-
(filterTextIsString == false || pullRequest.Title.ToUpperInvariant().Contains(filText.ToUpperInvariant()));
196+
if (!pullRequests.Disposed)
197+
{
198+
pullRequests.Filter = (pullRequest, index, list) =>
199+
(!state.IsOpen.HasValue || state.IsOpen == pullRequest.IsOpen) &&
200+
(ass == null || ass.Equals(pullRequest.Assignee)) &&
201+
(aut == null || aut.Equals(pullRequest.Author)) &&
202+
(filterTextIsNumber == false || pullRequest.Number == filterPullRequestNumber) &&
203+
(filterTextIsString == false || pullRequest.Title.ToUpperInvariant().Contains(filText.ToUpperInvariant()));
204+
}
202205
}
203206

204207
string searchQuery;

0 commit comments

Comments
 (0)