Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit a2d0236

Browse files
committed
remove timer and move message logic to refresh method
1 parent 4025d1e commit a2d0236

File tree

1 file changed

+11
-19
lines changed

1 file changed

+11
-19
lines changed

src/GitHub.TeamFoundation.14/Home/GitHubHomeSection.cs

Lines changed: 11 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -53,25 +53,6 @@ public GitHubHomeSection(IGitHubServiceProvider serviceProvider,
5353
var openOnGitHub = ReactiveCommand.Create();
5454
openOnGitHub.Subscribe(_ => DoOpenOnGitHub());
5555
OpenOnGitHub = openOnGitHub;
56-
57-
// We want to display a welcome message but only if Team Explorer isn't
58-
// already displaying the "Install 3rd Party Tools" message and the current repo is hosted on GitHub.
59-
// To do this we need to set a timer and check in the tick as at this point the message
60-
// won't be initialized.
61-
if (!settings.HideTeamExplorerWelcomeMessage)
62-
{
63-
var timer = new DispatcherTimer();
64-
timer.Interval = new TimeSpan(10);
65-
timer.Tick += (s, e) =>
66-
{
67-
timer.Stop();
68-
if (!IsGitToolsMessageVisible() && IsVisible)
69-
{
70-
ShowWelcomeMessage();
71-
}
72-
};
73-
timer.Start();
74-
}
7556
}
7657

7758
bool IsGitToolsMessageVisible()
@@ -106,6 +87,17 @@ public override async void Refresh()
10687
IsVisible = await IsAGitHubRepo();
10788
if (IsVisible)
10889
{
90+
// We want to display a welcome message but only if Team Explorer isn't
91+
// already displaying the "Install 3rd Party Tools" message and the current repo is hosted on GitHub.
92+
// To do this we need to set a timer and check in the tick as at this point the message
93+
// won't be initialized.
94+
if (!settings.HideTeamExplorerWelcomeMessage)
95+
{
96+
if (!IsGitToolsMessageVisible())
97+
{
98+
ShowWelcomeMessage();
99+
}
100+
}
109101
IsLoggedIn = IsUserAuthenticated();
110102
}
111103
base.Refresh();

0 commit comments

Comments
 (0)