Pass JoinableTaskContext to VSGitExtFactory

Author: jcansdale

src/GitHub.TeamFoundation.14/Services/VSGitExt.cs

@@ -33,6 +33,12 @@ public class VSGitExt : IVSGitExt
         IGitExt gitExt;
         IReadOnlyList<LocalRepositoryModel> activeRepositories;
 
+        /// NOTE: Used by VSGitExtFactory.
+        public VSGitExt(IServiceProvider serviceProvider, IGitService gitService, JoinableTaskContext joinableTaskContext)
+            : this(serviceProvider, new VSUIContextFactory(), gitService, joinableTaskContext)
+        {
+        }
+
         public VSGitExt(IServiceProvider serviceProvider, IVSUIContextFactory factory, IGitService gitService,
             JoinableTaskContext joinableTaskContext)
         {

src/GitHub.VisualStudio/GitHubPackage.cs

@@ -398,7 +398,7 @@ async Task<object> CreateService(IAsyncServiceContainer container, CancellationT
             else if (serviceType == typeof(IVSGitExt))
             {
                 var vsVersion = ApplicationInfo.GetHostVersionInfo().FileMajorPart;
-                return new VSGitExtFactory(vsVersion, this, GitService.GitServiceHelper).Create();
+                return new VSGitExtFactory(vsVersion, this, GitService.GitServiceHelper, ThreadHelper.JoinableTaskContext).Create();
             }
             else if (serviceType == typeof(IGitHubToolWindowManager))
             {

src/GitHub.VisualStudio/Services/VSGitExtFactory.cs

@@ -1,7 +1,6 @@
 using System;
-using System.Reflection;
 using GitHub.Logging;
-using GitHub.VisualStudio.Base;
+using Microsoft.VisualStudio.Threading;
 using Serilog;
 
 namespace GitHub.Services
@@ -13,12 +12,14 @@ public class VSGitExtFactory
         readonly int vsVersion;
         readonly IServiceProvider serviceProvider;
         readonly IGitService gitService;
+        readonly JoinableTaskContext joinableTaskContect;
 
-        public VSGitExtFactory(int vsVersion, IServiceProvider serviceProvider, IGitService gitService)
+        public VSGitExtFactory(int vsVersion, IServiceProvider serviceProvider, IGitService gitService, JoinableTaskContext joinableTaskContect)
         {
             this.vsVersion = vsVersion;
             this.serviceProvider = serviceProvider;
             this.gitService = gitService;
+            this.joinableTaskContect = joinableTaskContect;
         }
 
         // The GitHub.TeamFoundation.* assemblies target different .NET and Visual Studio versions.
@@ -28,7 +29,7 @@ public IVSGitExt Create()
         {
             if(Type.GetType($"GitHub.VisualStudio.Base.VSGitExt, GitHub.TeamFoundation.{vsVersion}", false) is Type type)
             {
-                return (IVSGitExt)Activator.CreateInstance(type, serviceProvider, gitService);
+                return (IVSGitExt)Activator.CreateInstance(type, serviceProvider, gitService, joinableTaskContect);
             }
 
             log.Error("There is no IVSGitExt implementation for DTE version {Version}", vsVersion);