Use IReadOnlyList and keep IVSGitExt consistent with IGitExt

There's now no reason not to return a IReadOnlyList like IGitExt.ActiveRepositories.

Author: jcansdale

src/GitHub.Exports/Services/IVSGitExt.cs

@@ -6,7 +6,7 @@ namespace GitHub.Services
 {
     public interface IVSGitExt
     {
-        IEnumerable<ILocalRepositoryModel> ActiveRepositories { get; }
+        IReadOnlyList<ILocalRepositoryModel> ActiveRepositories { get; }
         event Action ActiveRepositoriesChanged;
     }
 }

src/GitHub.TeamFoundation.14/Services/VSGitExt.cs

@@ -25,7 +25,7 @@ public class VSGitExt : IVSGitExt
         readonly ILocalRepositoryModelFactory repositoryFactory;
 
         IGitExt gitService;
-        IEnumerable<ILocalRepositoryModel> activeRepositories;
+        IReadOnlyList<ILocalRepositoryModel> activeRepositories;
 
         [ImportingConstructor]
         public VSGitExt(IGitHubServiceProvider serviceProvider, IVSUIContextFactory factory, ILocalRepositoryModelFactory repositoryFactory)
@@ -101,7 +101,7 @@ void RefreshActiveRepositories()
             }
         }
 
-        public IEnumerable<ILocalRepositoryModel> ActiveRepositories
+        public IReadOnlyList<ILocalRepositoryModel> ActiveRepositories
         {
             get
             {

test/UnitTests/GitHub.TeamFoundation/VSGitExtTests.cs

@@ -152,7 +152,7 @@ public void SccProviderContextIsActive_InitializeWithActiveRepositories()
 
             var activeRepositories = target.ActiveRepositories;
 
-            Assert.That(activeRepositories.Count(), Is.EqualTo(1));
+            Assert.That(activeRepositories.Count, Is.EqualTo(1));
             repoFactory.Received(1).Create(repoPath);
         }
 
@@ -170,7 +170,7 @@ public void ExceptionRefreshingRepositories_ReturnsEmptyList()
             var activeRepositories = target.ActiveRepositories;
 
             repoFactory.Received(1).Create(repoPath);
-            Assert.That(activeRepositories.Count(), Is.EqualTo(0));
+            Assert.That(activeRepositories.Count, Is.EqualTo(0));
         }
     }