Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit a489f5d

Browse files
committed
Indicate resolved comments with an empty circle
1 parent c75b321 commit a489f5d

File tree

2 files changed

+34
-8
lines changed

2 files changed

+34
-8
lines changed

src/GitHub.InlineReviews/Tags/ShowInlineCommentAnnotationGlyph.xaml

Lines changed: 17 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,27 @@
1717
<Setter Property="Stroke" Value="{DynamicResource GitHubDiffGlyphFill.None}" />
1818
</Style>
1919
</Canvas.Resources>
20-
2120
<Ellipse Width="9"
2221
Height="9"
2322
Canvas.Top="4"
2423
Canvas.Left="6"
25-
Fill="#959DA5"
26-
Stroke="White"
27-
StrokeThickness="1" />
24+
StrokeThickness="1">
25+
<Ellipse.Resources>
26+
<Style TargetType="Ellipse">
27+
<Style.Triggers>
28+
<DataTrigger Binding="{Binding Thread.IsResolved}" Value="False">
29+
<Setter Property="Fill" Value="#959DA5" />
30+
<Setter Property="Stroke" Value="White" />
31+
</DataTrigger>
32+
33+
<DataTrigger Binding="{Binding Thread.IsResolved}" Value="True">
34+
<Setter Property="Fill" Value="Transparent" />
35+
<Setter Property="Stroke" Value="#959DA5" />
36+
</DataTrigger>
37+
</Style.Triggers>
38+
</Style>
39+
</Ellipse.Resources>
40+
</Ellipse>
2841

2942
<Rectangle Width="7"
3043
Height="7"

src/GitHub.InlineReviews/Tags/ShowInlineCommentGlyph.xaml

Lines changed: 17 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,27 @@
1616
<Setter Property="Stroke" Value="{DynamicResource GitHubDiffGlyphFill.None}" />
1717
</Style>
1818
</Canvas.Resources>
19-
2019
<Ellipse Width="9"
2120
Height="9"
2221
Canvas.Top="3.5"
2322
Canvas.Left="3.5"
24-
Fill="#959DA5"
25-
Stroke="White"
26-
StrokeThickness="1" />
23+
StrokeThickness="1">
24+
<Ellipse.Resources>
25+
<Style TargetType="Ellipse">
26+
<Style.Triggers>
27+
<DataTrigger Binding="{Binding Thread.IsResolved}" Value="False">
28+
<Setter Property="Fill" Value="#959DA5" />
29+
<Setter Property="Stroke" Value="White" />
30+
</DataTrigger>
31+
32+
<DataTrigger Binding="{Binding Thread.IsResolved}" Value="True">
33+
<Setter Property="Fill" Value="Transparent" />
34+
<Setter Property="Stroke" Value="#959DA5" />
35+
</DataTrigger>
36+
</Style.Triggers>
37+
</Style>
38+
</Ellipse.Resources>
39+
</Ellipse>
2740
</Canvas>
2841
</Viewbox>
2942
</Grid>

0 commit comments

Comments
 (0)