Fix year size dyslexia

Author: shana

src/GitHub.UI/Converters/DurationToStringConverter.cs

@@ -7,7 +7,7 @@ public class DurationToStringConverter : ValueConverterMarkupExtension<DurationT
     {
         public override object Convert(object value, Type targetType, object parameter, CultureInfo culture)
         {
-            const int year = 356;
+            const int year = 365;
             const int month = 30;
             const int day = 24;
             const int hour = 60;
@@ -17,16 +17,18 @@ public override object Convert(object value, Type targetType, object parameter,
             if (value is TimeSpan)
                 duration = (TimeSpan)value;
             else if (value is DateTime)
-                duration = DateTime.Now - (DateTime)value;
+                duration = DateTime.UtcNow - (DateTime)value;
             else if (value is DateTimeOffset)
-                duration = DateTimeOffset.Now - (DateTimeOffset)value;
+                duration = DateTimeOffset.UtcNow - (DateTimeOffset)value;
             else
                 return value;
 
             if (duration.TotalDays >= year)
                 return string.Format(culture, (int)(duration.TotalDays / year) > 1 ? Resources.years : Resources.year, (int)(duration.TotalDays / year));
+            else if (duration.TotalDays >= 360)
+                return string.Format(culture, Resources.months, 11);
             else if (duration.TotalDays >= month)
-                return string.Format(culture, (int)(duration.TotalDays / month) > 1 ? Resources.months : Resources.month, (int)(duration.TotalDays / month));
+                return string.Format(culture, (int)(duration.TotalDays / (month)) > 1 ? Resources.months : Resources.month, (int)(duration.TotalDays / (month)));
             else if (duration.TotalHours >= day)
                 return string.Format(culture, (int)(duration.TotalHours / day) > 1 ? Resources.days : Resources.day, (int)(duration.TotalHours / day));
             else if (duration.TotalMinutes >= hour)

src/UnitTests/GitHub.UI/Converters.cs

@@ -27,10 +27,10 @@ public class Converters
     [InlineData(0, 0, 0, 30, "1 month ago")]
     [InlineData(0, 0, 0, 59, "1 month ago")]
     [InlineData(0, 0, 0, 60, "2 months ago")]
-    [InlineData(0, 0, 0, 355, "11 months ago")]
-    [InlineData(0, 0, 0, 356, "1 year ago")]
-    [InlineData(0, 0, 0, 356*2-1, "1 year ago")]
-    [InlineData(0, 0, 0, 356*2, "2 years ago")]
+    [InlineData(0, 0, 0, 364, "11 months ago")]
+    [InlineData(0, 0, 0, 365, "1 year ago")]
+    [InlineData(0, 0, 0, 365*2-1, "1 year ago")]
+    [InlineData(0, 0, 0, 365*2, "2 years ago")]
     public void TimespanConversion(int sec, int min, int hou, int day, string expected)
     {
         var ts = new TimeSpan(day, hou, min, sec);