Merge pull request #683 from github/fixes/catch-startup-errors

Catch exceptions thrown in GitHubConnectSection.

Author: shana

src/GitHub.TeamFoundation.14/Connect/GitHubConnectSection.cs

@@ -216,8 +216,20 @@ async void UpdateRepositoryList(object sender, NotifyCollectionChangedEventArgs
                         HandleClonedRepo(newrepo);
 
                     isCreating = isCloning = false;
-                    var repo = await ApiFactory.Create(newrepo.CloneUrl).GetRepository();
-                    newrepo.SetIcon(repo.Private, repo.Fork);
+
+                    try
+                    {
+                        // TODO: Cache the icon state.
+                        var repo = await ApiFactory.Create(newrepo.CloneUrl).GetRepository();
+                        newrepo.SetIcon(repo.Private, repo.Fork);
+                    }
+                    catch
+                    {
+                        // GetRepository() may throw if the user doesn't have permissions to access the repo
+                        // (because the repo no longer exists, or because the user has logged in on a different
+                        // profile, or their permissions have changed remotely)
+                        // TODO: Log
+                    }
                 }
                 // looks like it's just a refresh with new stuff on the list, update the icons
                 else
@@ -228,8 +240,20 @@ async void UpdateRepositoryList(object sender, NotifyCollectionChangedEventArgs
                     {
                         if (Equals(Holder.ActiveRepo, r))
                             SelectedRepository = r;
-                        var repo = await ApiFactory.Create(r.CloneUrl).GetRepository();
-                        r.SetIcon(repo.Private, repo.Fork);
+
+                        try
+                        {
+                            // TODO: Cache the icon state.
+                            var repo = await ApiFactory.Create(r.CloneUrl).GetRepository();
+                            r.SetIcon(repo.Private, repo.Fork);
+                        }
+                        catch
+                        {
+                            // GetRepository() may throw if the user doesn't have permissions to access the repo
+                            // (because the repo no longer exists, or because the user has logged in on a different
+                            // profile, or their permissions have changed remotely)
+                            // TODO: Log
+                        }
                     });
                 }
             }