Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit aa3e3b9

Browse files
committed
Suppress CA1054/1056.
Supress URI properties/parameters should not be strings The `Uri` class kinda sucks, we prefer using strings which can be concatenated etc, or `UriString`.
1 parent ae7a1d2 commit aa3e3b9

File tree

5 files changed

+7
-1
lines changed

5 files changed

+7
-1
lines changed

src/GitHub.App/GlobalSuppressions.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,3 +16,6 @@
1616
[assembly: SuppressMessage("Microsoft.Naming", "CA1703:ResourceStringsShouldBeSpelledCorrectly", MessageId = "Git", Scope = "resource", Target = "GitHub.App.Resources.resources")]
1717
[assembly: SuppressMessage("Microsoft.Globalization", "CA1305:SpecifyIFormatProvider", MessageId = "System.String.Format(System.String,System.Object,System.Object,System.Object)", Scope = "member", Target = "GitHub.Services.PullRequestService.#CreateTempFile(System.String,System.String,System.String)")]
1818
[assembly: SuppressMessage("Microsoft.Globalization", "CA1305:SpecifyIFormatProvider", MessageId = "System.String.Format(System.String,System.Object,System.Object,System.Object)", Scope = "member", Target = "GitHub.Services.PullRequestService.#CreateTempFile(System.String,System.String,System.String,System.Text.Encoding)")]
19+
[assembly: SuppressMessage("Design", "CA1056:Uri properties should not be strings")]
20+
[assembly: SuppressMessage("Design", "CA1054:Uri parameters should not be strings")]
21+
344 Bytes
Binary file not shown.
344 Bytes
Binary file not shown.

src/GitHub.Extensions/GlobalSuppressions.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,5 @@
55

66
using System.Diagnostics.CodeAnalysis;
77

8-
[assembly: SuppressMessage("Reliability", "CA2007:Do not directly await a Task", Justification = "Discouraged for VSSDK projects.")]
8+
[assembly: SuppressMessage("Design", "CA1054:Uri parameters should not be strings")]
9+
[assembly: SuppressMessage("Design", "CA1056:Uri properties should not be strings")]

src/GitHub.TeamFoundation.14/GlobalSuppressions.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,6 @@
55

66
using System.Diagnostics.CodeAnalysis;
77

8+
[assembly: SuppressMessage("Design", "CA1054:Uri parameters should not be strings")]
9+
[assembly: SuppressMessage("Design", "CA1056:Uri properties should not be strings")]
810
[assembly: SuppressMessage("Reliability", "CA2007:Do not directly await a Task", Justification = "Discouraged for VSSDK projects.")]

0 commit comments

Comments
 (0)