Don't load the publish view until is becomes visible

Author: jcansdale

src/GitHub.VisualStudio.16/Sync/PublishSection.cs

@@ -37,14 +37,6 @@ public class PublishSection : TeamExplorerBaseSection
         public PublishSection(CompositionServices compositionServices)
         {
             this.compositionServices = compositionServices;
-
-            this.Title = "Publish to GitHub";
-            this.IsExpanded = true;
-            this.IsBusy = false;
-            this.SectionContent = new PublishView(){
-                DataContext = this
-            };
-            this.View.ParentSection = this;
         }
 
         /// <summary>
@@ -83,10 +75,10 @@ public override void Initialize(object sender, SectionInitializeEventArgs e)
                 }
             }
 
-            PublishToGitHub = new RelayCommand(o => ShowPublishDialog().Forget());
+            PublishToGitHub = new RelayCommand(o => ShowPublishDialogAsync().Forget());
         }
 
-        async Task ShowPublishDialog()
+        async Task ShowPublishDialogAsync()
         {
             var exportProvider = compositionServices.GetExportProvider();
 
@@ -153,10 +145,34 @@ void RefreshVisibility()
 
             if (IsVisible != visible)
             {
+                if (visible)
+                {
+                    // Don't initialize the view until it becomes visible
+                    EnsureSectionInitialized();
+                }
+
                 IsVisible = visible;
             }
         }
 
+        void EnsureSectionInitialized()
+        {
+            if (SectionContent == null)
+            {
+                Title = "Publish to GitHub";
+                IsExpanded = true;
+                IsBusy = false;
+
+                Assumes.NotNull(GitHub.Resources.BlurbText); // Ensure GitHub.Resourcess has been loaded before we use it from XAML
+                SectionContent = new PublishView()
+                {
+                    DataContext = this
+                };
+
+                View.ParentSection = this;
+            }
+        }
+
         bool IsSectionVisible(ITeamExplorerPage teamExplorerPage, Guid sectionId)
         {
             if (teamExplorerPage.GetSection(sectionId) is ITeamExplorerSection pushToRemoteSection)