Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit acc46cf

Browse files
committed
modify for review
1 parent 17b4ec2 commit acc46cf

File tree

3 files changed

+10
-7
lines changed

3 files changed

+10
-7
lines changed

src/GitHub.InlineReviews/Views/CommentView.xaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,8 @@
6767
CornerRadius="3"
6868
Padding="2 1"
6969
Visibility="{Binding IsPending, Converter={ui:BooleanToVisibilityConverter}, FallbackValue=Collapsed}">
70-
<TextBlock FontSize="10" Text="{x:Static prop:Resources.Pending}"></TextBlock>
71-
</Border>
70+
<TextBlock FontSize="10" Text="{x:Static prop:Resources.Pending}" />
71+
</Border>
7272
</StackPanel>
7373

7474
<StackPanel Orientation="Horizontal" HorizontalAlignment="Right" DockPanel.Dock="Right"

src/GitHub.VisualStudio/Views/Dialog/ForkRepositoryExecuteView.xaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@
5555
<ColumnDefinition Width="*" />
5656
</Grid.ColumnDefinitions>
5757
<ui:OcticonImage Grid.Column="0" Icon="repo_forked" Height="16" Width="16" />
58-
<TextBlock Margin="8 0 0 0" Grid.Column="1" TextWrapping="Wrap">Fork the repository</TextBlock>
58+
<TextBlock Margin="8 0 0 0" Grid.Column="1" TextWrapping="Wrap" Text="Fork the repository" />
5959
</Grid>
6060

6161
<Grid Margin="0 16 0 0">

test/GitHub.VisualStudio.UnitTests/Commands/OpenFromClipboardCommandTests.cs

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,13 +46,12 @@ public async Task UnknownLinkType()
4646
var activeRepositoryDir = "activeRepositoryDir";
4747
var vsServices = Substitute.For<IVSServices>();
4848
var target = CreateOpenFromClipboardCommand(vsServices: vsServices, contextFromClipboard: context, repositoryDir: activeRepositoryDir);
49-
5049
await target.Execute(null);
51-
5250
vsServices.Received(1).ShowMessageBoxInfo(expectMessage);
5351
}
52+
5453
[Test]
55-
public async Task DifferentLocalRepository_DifferentRepositoryMessage()
54+
public async Task DifferentLocalRepository_DifferentRepositoryMessage()
5655
{
5756
await DifferentLocalRepository("targetRepositoryName", "activeRepositoryName", Resources.DifferentRepositoryMessage);
5857
}
@@ -86,16 +85,19 @@ public async Task CouldNotResolve_NoResolveDifferentOwnerMessage()
8685
{
8786
await CouldNotResolve("TargetOwner", "CurrentOwner", Resources.NoResolveDifferentOwnerMessage);
8887
}
88+
8989
[Test]
9090
public async Task CouldNotResolve_NoResolveSameOwnerMessage_SameOwner_SameOwner()
9191
{
9292
await CouldNotResolve("SameOwner", "SameOwner", Resources.NoResolveSameOwnerMessage);
9393
}
94+
9495
[Test]
9596
public async Task CouldNotResolve_NoResolveSameOwnerMessage_sameowner_SAMEOWNER()
9697
{
9798
await CouldNotResolve("sameowner", "SAMEOWNER", Resources.NoResolveSameOwnerMessage);
9899
}
100+
99101
public async Task CouldNotResolve(string targetOwner, string currentOwner, string expectMessage)
100102
{
101103
var repositoryDir = "repositoryDir";
@@ -147,8 +149,9 @@ public async Task NoChangesInWorkingDirectory()
147149
[Test]
148150
public async Task HasChangesInWorkingDirectorye_ChangesInWorkingDirectoryMessage()
149151
{
150-
await HasChangesInWorkingDirectory(false, Resources.ChangesInWorkingDirectoryMessage, 1, 1);
152+
await HasChangesInWorkingDirectory(false, Resources.ChangesInWorkingDirectoryMessage, 1, 1);
151153
}
154+
152155
[TestCase(true, null, 1, 0)]
153156
public async Task HasChangesInWorkingDirectory(bool annotateFileSupported, string message,
154157
int receivedTryAnnotateFile, int receivedTryOpenFile)

0 commit comments

Comments
 (0)