Switch to CheckRunId

Author: StanleyGoldman

src/GitHub.App/SampleData/PullRequestAnnotationsViewModelDesigner.cs

@@ -16,7 +16,7 @@ public sealed class PullRequestAnnotationsViewModelDesigner : PanePageViewModelB
         public ILocalRepositoryModel LocalRepository { get; set; }
         public string RemoteRepositoryOwner { get; set; }
         public int PullRequestNumber { get; set; } = 123;
-        public int CheckRunId { get; set; }
+        public string CheckRunId { get; set; }
         public ReactiveCommand<Unit, Unit> NavigateToPullRequest { get; }
         public string PullRequestTitle { get; } = "Fixing stuff in this PR";
         public string CheckSuiteName { get; } = "Awesome Check Suite";
@@ -61,7 +61,7 @@ public sealed class PullRequestAnnotationsViewModelDesigner : PanePageViewModelB
         };
 
         public Task InitializeAsync(ILocalRepositoryModel localRepository, IConnection connection, string owner, string repo,
-            int pullRequestNumber, int checkRunId)
+            int pullRequestNumber, string checkRunId)
         {
             return Task.CompletedTask;
         }

src/GitHub.App/SampleData/PullRequestCheckViewModelDesigner.cs

@@ -22,7 +22,7 @@ public sealed class PullRequestCheckViewModelDesigner : ViewModelBase, IPullRequ
 
         public PullRequestCheckType CheckType { get; set; } = PullRequestCheckType.ChecksApi;
 
-        public int CheckRunId { get; set; }
+        public string CheckRunId { get; set; }
 
         public bool HasAnnotations { get; } = true;
     }

src/GitHub.App/ViewModels/GitHubPane/GitHubPaneViewModel.cs

@@ -272,7 +272,7 @@ public async Task NavigateTo(Uri uri)
                 var owner = match.Groups["owner"].Value;
                 var repo = match.Groups["repo"].Value;
                 var number = int.Parse(match.Groups["number"].Value);
-                var id = int.Parse(match.Groups["id"].Value);
+                var id = match.Groups["id"].Value;
 
                 await ShowPullRequestCheckRun(owner, repo, number, id);
             }
@@ -330,7 +330,7 @@ public Task ShowPullRequestReviews(string owner, string repo, int number, string
         }
 
         /// <inheritdoc/>
-        public Task ShowPullRequestCheckRun(string owner, string repo, int number, int checkRunId)
+        public Task ShowPullRequestCheckRun(string owner, string repo, int number, string checkRunId)
         {
             Guard.ArgumentNotNull(owner, nameof(owner));
             Guard.ArgumentNotNull(repo, nameof(repo));

src/GitHub.App/ViewModels/GitHubPane/PullRequestAnnotationsViewModel.cs

@@ -41,7 +41,7 @@ public PullRequestAnnotationsViewModel(IPullRequestSessionManager sessionManager
 
         /// <inheritdoc/>
         public async Task InitializeAsync(ILocalRepositoryModel localRepository, IConnection connection, string owner,
-            string repo, int pullRequestNumber, int checkRunId)
+            string repo, int pullRequestNumber, string checkRunId)
         {
             if (repo != localRepository.Name)
             {
@@ -75,7 +75,7 @@ public async Task InitializeAsync(ILocalRepositoryModel localRepository, IConnec
         public int PullRequestNumber { get; private set; }
 
         /// <inheritdoc/>
-        public int CheckRunId { get; private set; }
+        public string CheckRunId { get; private set; }
 
         /// <inheritdoc/>
         public ReactiveCommand<Unit, Unit> NavigateToPullRequest { get; private set; }
@@ -119,7 +119,7 @@ void Load(PullRequestDetailModel pullRequest)
                 var checkSuiteRun = pullRequest
                     .CheckSuites.SelectMany(checkSuite => checkSuite.CheckRuns
                             .Select(checkRun => new{checkSuite, checkRun}))
-                    .First(arg => arg.checkRun.DatabaseId == CheckRunId);
+                    .First(arg => arg.checkRun.CheckRunId == CheckRunId);
 
                 CheckSuiteName = checkSuiteRun.checkSuite.ApplicationName;
                 CheckRunName = checkSuiteRun.checkRun.Name;

src/GitHub.App/ViewModels/GitHubPane/PullRequestCheckViewModel.cs

@@ -94,7 +94,7 @@ public static IEnumerable<IPullRequestCheckViewModel> Build(IViewViewModelFactor
 
                     var pullRequestCheckViewModel = (PullRequestCheckViewModel)viewViewModelFactory.CreateViewModel<IPullRequestCheckViewModel>();
                     pullRequestCheckViewModel.CheckType = PullRequestCheckType.ChecksApi;
-                    pullRequestCheckViewModel.CheckRunId = checkRunModel.DatabaseId;
+                    pullRequestCheckViewModel.CheckRunId = checkRunModel.CheckRunId;
                     pullRequestCheckViewModel.HasAnnotations = checkRunModel.Annotations?.Any() ?? false;
                     pullRequestCheckViewModel.Title = checkRunModel.Name;
                     pullRequestCheckViewModel.Description = checkRunModel.Summary;
@@ -143,7 +143,7 @@ private void DoOpenDetailsUrl()
         public PullRequestCheckType CheckType { get; private set; }
 
         /// <inheritdoc/>
-        public int CheckRunId { get; private set; }
+        public string CheckRunId { get; private set; }
 
         /// <inheritdoc/>
         public bool HasAnnotations { get; private set; }

src/GitHub.Exports.Reactive/ViewModels/GitHubPane/IPullRequestAnnotationsViewModel.cs

@@ -39,7 +39,7 @@ public interface IPullRequestAnnotationsViewModel : IPanePageViewModel
         /// <summary>
         /// Gets the id of the check run.
         /// </summary>
-        int CheckRunId { get; }
+        string CheckRunId { get; }
 
         /// <summary>
         /// Gets the name of the check run.
@@ -76,6 +76,6 @@ Task InitializeAsync(
             string owner,
             string repo,
             int pullRequestNumber,
-            int checkRunId);
+            string checkRunId);
     }
 }

src/GitHub.Exports.Reactive/ViewModels/GitHubPane/IPullRequestCheckViewModel.cs

@@ -44,7 +44,7 @@ public interface IPullRequestCheckViewModel: IViewModel
         /// <summary>
         /// Gets the id of the check run.
         /// </summary>
-        int CheckRunId { get; }
+        string CheckRunId { get; }
 
         /// <summary>
         /// Gets a flag to show this check run has annotations.

src/GitHub.Exports/Models/CheckRunModel.cs

@@ -46,6 +46,6 @@ public class CheckRunModel
         /// <summary>
         /// The database id of a Check Run.
         /// </summary>
-        public int DatabaseId { get; set; }
+        public string CheckRunId { get; set; }
     }
 }

src/GitHub.Exports/ViewModels/GitHubPane/IGitHubPaneViewModel.cs

@@ -97,8 +97,8 @@ public interface IGitHubPaneViewModel : IViewModel
         /// <param name="owner">The repository owner.</param>
         /// <param name="repo">The repository name.</param>
         /// <param name="number">The pull rqeuest number.</param>
-        /// <param name="checkRunId">The check run number.</param>
-        Task ShowPullRequestCheckRun(string owner, string repo, int number, int checkRunId);
+        /// <param name="checkRunId">The check run id.</param>
+        Task ShowPullRequestCheckRun(string owner, string repo, int number, string checkRunId);
 
         /// <summary>
         /// Shows the pull requests reviews authored by a user.

src/GitHub.InlineReviews/Services/PullRequestSessionService.cs

@@ -787,9 +787,9 @@ async Task<LastCommitAdapter> GetPullRequestLastCommitAdapter(HostAddress addres
                                           CheckRuns = suite.CheckRuns(null, null, null, null, null).AllPages(10)
                                               .Select(run => new CheckRunModel
                                               {
+                                                  CheckRunId = run.Id.Value,
                                                   Conclusion = run.Conclusion.FromGraphQl(),
                                                   Status = run.Status.FromGraphQl(),
-                                                  DatabaseId = run.DatabaseId.Value,
                                                   Name = run.Name,
                                                   DetailsUrl = run.Permalink,
                                                   Summary = run.Summary,