Merge pull request #2134 from github/fixes/supress-warnings

jcansdale · web-flow · commit ae5962f3a740 · 2018-12-14T15:36:44.000Z
Suppress CA warnings where it makes sense.
diff --git a/src/CredentialManagement/NativeMethods.cs b/src/CredentialManagement/NativeMethods.cs
@@ -4,6 +4,10 @@
 using System.Text;
 using Microsoft.Win32.SafeHandles;
 
+#pragma warning disable CA1034 // Nested types should not be visible
+#pragma warning disable CA1051 // Do not declare visible instance fields
+#pragma warning disable CA1707 // Identifiers should not contain underscores
+
 namespace GitHub.Authentication.CredentialManagement
 {
     public static class NativeMethods
diff --git a/src/GitHub.Api/GlobalSuppressions.cs b/src/GitHub.Api/GlobalSuppressions.cs
@@ -0,0 +1,9 @@
+﻿// This file is used by Code Analysis to maintain SuppressMessage 
+// attributes that are applied to this project.
+// Project-level suppressions either have no target or are given 
+// a specific target and scoped to a namespace, type, member, etc.
+
+using System.Diagnostics.CodeAnalysis;
+
+[assembly: SuppressMessage("Reliability", "CA2007:Do not directly await a Task", Justification = "Discouraged for VSSDK projects.")]
+
diff --git a/src/GitHub.App/Collections/VirtualizingList.cs b/src/GitHub.App/Collections/VirtualizingList.cs
@@ -12,6 +12,10 @@
 using GitHub.Logging;
 using Serilog;
 
+#pragma warning disable CA1010 // Collections should implement generic interface
+#pragma warning disable CA1033 // Interface methods should be callable by child types
+#pragma warning disable CA1710 // Identifiers should have correct suffix
+
 namespace GitHub.Collections
 {
     /// <summary>
diff --git a/src/GitHub.App/Collections/VirtualizingListCollectionView.cs b/src/GitHub.App/Collections/VirtualizingListCollectionView.cs
@@ -4,6 +4,10 @@
 using System.Collections.Specialized;
 using System.Windows.Data;
 
+#pragma warning disable CA1010 // Collections should implement generic interface
+#pragma warning disable CA1033 // Interface methods should be callable by child types
+#pragma warning disable CA1710 // Identifiers should have correct suffix
+
 namespace GitHub.Collections
 {
     /// <summary>
diff --git a/src/GitHub.App/GlobalSuppressions.cs b/src/GitHub.App/GlobalSuppressions.cs
@@ -1,12 +1,3 @@
-using System.Diagnostics.CodeAnalysis;
-
-[assembly: SuppressMessage("Microsoft.Performance", "CA1822:MarkMembersAsStatic", Scope = "member", Target = "GitHub.ViewModels.CreateRepoViewModel.#ResetState()")]
-[assembly: SuppressMessage("Microsoft.Naming", "CA1703:ResourceStringsShouldBeSpelledCorrectly", MessageId = "Git", Scope = "resource", Target = "GitHub.Resources.resources")]
-[assembly: SuppressMessage("Microsoft.Performance", "CA1800:DoNotCastUnnecessarily", Scope = "member", Target = "GitHub.Caches.CredentialCache.#InsertObject`1(System.String,!!0,System.Nullable`1<System.DateTimeOffset>)")]
-[assembly: SuppressMessage("Microsoft.Naming", "CA1703:ResourceStringsShouldBeSpelledCorrectly", MessageId = "Git", Scope = "resource", Target = "GitHub.App.Resources.resources")]
-[assembly: SuppressMessage("Microsoft.Globalization", "CA1305:SpecifyIFormatProvider", MessageId = "System.String.Format(System.String,System.Object,System.Object,System.Object)", Scope = "member", Target = "GitHub.Services.PullRequestService.#CreateTempFile(System.String,System.String,System.String)")]
-[assembly: SuppressMessage("Microsoft.Globalization", "CA1305:SpecifyIFormatProvider", MessageId = "System.String.Format(System.String,System.Object,System.Object,System.Object)", Scope = "member", Target = "GitHub.Services.PullRequestService.#CreateTempFile(System.String,System.String,System.String,System.Text.Encoding)")]
-
 // This file is used by Code Analysis to maintain SuppressMessage 
 // attributes that are applied to this project.
 // Project-level suppressions either have no target or are given 
@@ -16,3 +7,13 @@
 // Code Analysis results, point to "Suppress Message", and click 
 // "In Suppression File".
 // You do not need to add suppressions to this file manually.
+
+using System.Diagnostics.CodeAnalysis;
+
+[assembly: SuppressMessage("Microsoft.Performance", "CA1822:MarkMembersAsStatic", Scope = "member", Target = "GitHub.ViewModels.CreateRepoViewModel.#ResetState()")]
+[assembly: SuppressMessage("Microsoft.Naming", "CA1703:ResourceStringsShouldBeSpelledCorrectly", MessageId = "Git", Scope = "resource", Target = "GitHub.Resources.resources")]
+[assembly: SuppressMessage("Microsoft.Performance", "CA1800:DoNotCastUnnecessarily", Scope = "member", Target = "GitHub.Caches.CredentialCache.#InsertObject`1(System.String,!!0,System.Nullable`1<System.DateTimeOffset>)")]
+[assembly: SuppressMessage("Microsoft.Naming", "CA1703:ResourceStringsShouldBeSpelledCorrectly", MessageId = "Git", Scope = "resource", Target = "GitHub.App.Resources.resources")]
+[assembly: SuppressMessage("Microsoft.Globalization", "CA1305:SpecifyIFormatProvider", MessageId = "System.String.Format(System.String,System.Object,System.Object,System.Object)", Scope = "member", Target = "GitHub.Services.PullRequestService.#CreateTempFile(System.String,System.String,System.String)")]
+[assembly: SuppressMessage("Microsoft.Globalization", "CA1305:SpecifyIFormatProvider", MessageId = "System.String.Format(System.String,System.Object,System.Object,System.Object)", Scope = "member", Target = "GitHub.Services.PullRequestService.#CreateTempFile(System.String,System.String,System.String,System.Text.Encoding)")]
+[assembly: SuppressMessage("Reliability", "CA2007:Do not directly await a Task", Justification = "Discouraged for VSSDK projects.")]
diff --git a/src/GitHub.App/Services/ErrorMessageTranslator.cs b/src/GitHub.App/Services/ErrorMessageTranslator.cs
@@ -7,6 +7,7 @@
 using ReactiveUI.Legacy;
 
 #pragma warning disable CS0618 // Type or member is obsolete
+#pragma warning disable CA1034 // Nested types should not be visible
 
 namespace GitHub.Services
 {
diff --git a/src/GitHub.App/Services/ModelService.cs b/src/GitHub.App/Services/ModelService.cs
@@ -22,6 +22,8 @@
 using Serilog;
 using static Octokit.GraphQL.Variable;
 
+#pragma warning disable CA1034 // Nested types should not be visible
+
 namespace GitHub.Services
 {
     [Export(typeof(IModelService))]
diff --git a/src/GitHub.App/sqlite-net/SQLite.cs b/src/GitHub.App/sqlite-net/SQLite.cs
@@ -54,6 +54,23 @@
 #endif
 
 #pragma warning disable 1591 // XML Doc Comments
+#pragma warning disable CA1018 // Mark attributes with AttributeUsageAttribute
+#pragma warning disable CA1032 // Implement standard exception constructors
+#pragma warning disable CA1034 // Nested types should not be visible
+#pragma warning disable CA1051 // Do not declare visible instance fields
+#pragma warning disable CA1052 // Static holder types should be Static or NotInheritable
+#pragma warning disable CA1060 // Move pinvokes to native methods class
+#pragma warning disable CA1304 // Specify CultureInfo
+#pragma warning disable CA1305 // Specify IFormatProvider
+#pragma warning disable CA1401 // P/Invokes should not be visible
+#pragma warning disable CA1710 // Identifiers should have correct suffix
+#pragma warning disable CA1720 // Identifier contains type name
+#pragma warning disable CA1806 // Do not ignore method results
+#pragma warning disable CA1819 // Properties should not return arrays
+#pragma warning disable CA2101 // Specify marshaling for P/Invoke string arguments
+#pragma warning disable CA2200 // Rethrow to preserve stack details.
+#pragma warning disable CA2208 // Instantiate argument exceptions correctly
+#pragma warning disable CA2237 // Mark ISerializable types with serializable
 
 namespace SQLite
 {
diff --git a/src/GitHub.App/sqlite-net/SQLiteAsync.cs b/src/GitHub.App/sqlite-net/SQLiteAsync.cs
@@ -28,6 +28,10 @@
 using System.Threading;
 using System.Threading.Tasks;
 
+#pragma warning disable CA1001 // Types that own disposable fields should be disposable
+#pragma warning disable CA1200 // Avoid using cref tags with a prefix
+#pragma warning disable CA1720 // Identifier contains type name
+
 namespace SQLite
 {
     /// <summary>
diff --git a/src/GitHub.Exports.Reactive/GlobalSuppressions.cs b/src/GitHub.Exports.Reactive/GlobalSuppressions.cs
diff --git a/src/GitHub.Exports.Reactive/Helpers/ExceptionHelper.cs b/src/GitHub.Exports.Reactive/Helpers/ExceptionHelper.cs
@@ -3,6 +3,8 @@
 using System.Globalization;
 using System.Reactive.Linq;
 
+#pragma warning disable CA1720 // Identifier contains type name
+
 namespace GitHub.Helpers
 {
     public static class ExceptionHelper
diff --git a/src/GitHub.Exports/Extensions/PropertyNotifierExtensions.cs b/src/GitHub.Exports/Extensions/PropertyNotifierExtensions.cs
@@ -1,5 +1,7 @@
 ﻿using System.Runtime.CompilerServices;
 
+#pragma warning disable CA1030 // Use events where appropriate
+
 namespace GitHub.VisualStudio.Helpers
 {
     public static class PropertyNotifierExtensions
diff --git a/src/GitHub.Exports/GlobalSuppressions.cs b/src/GitHub.Exports/GlobalSuppressions.cs
diff --git a/src/GitHub.Exports/Helpers/INotifyPropertySource.cs b/src/GitHub.Exports/Helpers/INotifyPropertySource.cs
@@ -1,4 +1,6 @@
-﻿namespace GitHub.VisualStudio.Helpers
+﻿#pragma warning disable CA1030 // Use events where appropriate
+
+namespace GitHub.VisualStudio.Helpers
 {
     public interface INotifyPropertySource
     {
diff --git a/src/GitHub.Exports/Models/DiffUtilities.cs b/src/GitHub.Exports/Models/DiffUtilities.cs
@@ -5,6 +5,8 @@
 using System.Diagnostics.CodeAnalysis;
 using GitHub.Extensions;
 
+#pragma warning disable CA1034 // Nested types should not be visible
+
 namespace GitHub.Models
 {
     public static class DiffUtilities
diff --git a/src/GitHub.Exports/Models/UsageModel.cs b/src/GitHub.Exports/Models/UsageModel.cs
@@ -1,5 +1,8 @@
 ﻿using System;
 
+#pragma warning disable CA1034 // Nested types should not be visible
+#pragma warning disable CA1720 // Identifier contains type name
+
 namespace GitHub.Models
 {
     public class UsageModel
diff --git a/src/GitHub.Exports/Services/INotificationService.cs b/src/GitHub.Exports/Services/INotificationService.cs
@@ -1,5 +1,6 @@
 using System;
 using System.Windows.Input;
+#pragma warning disable CA1720 // Identifier contains type name
 
 namespace GitHub.Services
 {
diff --git a/src/GitHub.Exports/Settings/Guids.cs b/src/GitHub.Exports/Settings/Guids.cs
@@ -22,7 +22,7 @@ public static class Guids
         public const string TeamExplorerInstall3rdPartyGitTools = "DF785C7C-8454-4836-9686-D1C4A01D0BB9";
 
         // UIContexts
-        public const string UIContext_Git = "565515AD-F4C1-4D59-BC14-AE77396DDDD7";
+        public const string GitContextPkgString = "565515AD-F4C1-4D59-BC14-AE77396DDDD7";
 
         // Guids defined in GitHub.VisualStudio.vsct
         public const string guidGitHubPkgString = "c3d3dc68-c977-411f-b3e8-03b0dccf7dfc";
diff --git a/src/GitHub.Exports/UI/Octicon.cs b/src/GitHub.Exports/UI/Octicon.cs
@@ -1,5 +1,7 @@
 using System;
 
+#pragma warning disable CA1707 // Identifiers should not contain underscores
+
 namespace GitHub.UI
 {
     public enum Octicon
diff --git a/src/GitHub.Extensions.Reactive/RxuiLegacy/Errors.cs b/src/GitHub.Extensions.Reactive/RxuiLegacy/Errors.cs
@@ -337,11 +337,13 @@ public static IDisposable OverrideHandlersForTesting(Func<UserError, RecoveryOpt
     }
 
 #pragma warning disable 618
+#pragma warning disable CA1032 // Implement standard exception constructors
+#pragma warning disable CA2237 // Mark ISerializable types with serializable
     /// <summary>
     /// This Exception will be thrown when a UserError is not handled by any
     /// of the registered handlers.
     /// </summary>
-    public class UnhandledUserErrorException : Exception 
+    public class UnhandledUserErrorException : Exception
     {
         public UnhandledUserErrorException(UserError error) : base(error.ErrorMessage, error.InnerException)
         {
@@ -350,6 +352,8 @@ public UnhandledUserErrorException(UserError error) : base(error.ErrorMessage, e
 
         public UserError ReportedError { get; protected set; }
     }
+#pragma warning restore CA2237 // Mark ISerializable types with serializable
+#pragma warning restore CA1032 // Implement standard exception constructors
 #pragma warning restore 618
 
     /// <summary>
diff --git a/src/GitHub.Extensions.Reactive/RxuiLegacy/ReactiveCommand.cs b/src/GitHub.Extensions.Reactive/RxuiLegacy/ReactiveCommand.cs
@@ -16,6 +16,11 @@
 using System.Windows.Input;
 using Splat;
 
+#pragma warning disable CA1030 // Use events where appropriate
+#pragma warning disable CA1063 // Implement IDisposable Correctly
+#pragma warning disable CA1816 // Dispose methods should call SuppressFinalize
+#pragma warning disable CA2214 // Do not call overridable methods in constructors
+
 namespace ReactiveUI.Legacy
 {
     [Obsolete("This type is obsolete and will be removed in a future version of ReactiveUI. Please switch to using ReactiveUI.ReactiveCommand instead.")]
diff --git a/src/GitHub.Extensions/GlobalSuppressions.cs b/src/GitHub.Extensions/GlobalSuppressions.cs
@@ -0,0 +1,8 @@
+﻿// This file is used by Code Analysis to maintain SuppressMessage 
+// attributes that are applied to this project.
+// Project-level suppressions either have no target or are given 
+// a specific target and scoped to a namespace, type, member, etc.
+
+using System.Diagnostics.CodeAnalysis;
+
+[assembly: SuppressMessage("Reliability", "CA2007:Do not directly await a Task", Justification = "Discouraged for VSSDK projects.")]
diff --git a/src/GitHub.InlineReviews/Commands/ToggleInlineCommentMarginCommand.cs b/src/GitHub.InlineReviews/Commands/ToggleInlineCommentMarginCommand.cs
@@ -3,13 +3,13 @@
 using System.ComponentModel.Composition;
 using GitHub.Commands;
 using GitHub.Services;
+using GitHub.Extensions;
 using GitHub.VisualStudio;
 using GitHub.InlineReviews.Margins;
 using GitHub.Services.Vssdk.Commands;
 using Microsoft.VisualStudio.TextManager.Interop;
 using Microsoft.VisualStudio;
 using Microsoft.VisualStudio.Editor;
-using GitHub.Extensions;
 
 namespace GitHub.InlineReviews.Commands
 {
diff --git a/src/GitHub.InlineReviews/GlobalSuppressions.cs b/src/GitHub.InlineReviews/GlobalSuppressions.cs
@@ -3,6 +3,7 @@
 // attributes that are applied to this project.
 // Project-level suppressions either have no target or are given 
 // a specific target and scoped to a namespace, type, member, etc.
+using System.Diagnostics.CodeAnalysis;
 
-[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Style", "VSTHRD200:Use \"Async\" suffix for async methods")]
-
+[assembly: SuppressMessage("Style", "VSTHRD200:Use \"Async\" suffix for async methods")]
+[assembly: SuppressMessage("Reliability", "CA2007:Do not directly await a Task", Justification = "Discouraged for VSSDK projects.")]
diff --git a/src/GitHub.InlineReviews/InlineReviewsPackage.cs b/src/GitHub.InlineReviews/InlineReviewsPackage.cs
@@ -18,7 +18,7 @@ namespace GitHub.InlineReviews
 {
     [PackageRegistration(UseManagedResourcesOnly = true, AllowsBackgroundLoading = true)]
     [Guid(Guids.InlineReviewsPackageId)]
-    [ProvideAutoLoad(Guids.UIContext_Git, PackageAutoLoadFlags.BackgroundLoad)]
+    [ProvideAutoLoad(Guids.GitContextPkgString, PackageAutoLoadFlags.BackgroundLoad)]
     [ProvideMenuResource("Menus.ctmenu", 1)]
     public class InlineReviewsPackage : AsyncPackage
     {
@@ -59,7 +59,7 @@ async Task InitializeMenus()
 
             await JoinableTaskFactory.SwitchToMainThreadAsync();
             var menuService = (IMenuCommandService)(await GetServiceAsync(typeof(IMenuCommandService)));
-            Assumes.Present(componentModel);
+            Assumes.Present(menuService);
 
             menuService.AddCommands(commands);
         }
diff --git a/src/GitHub.InlineReviews/Margins/InlineCommentMarginProvider.cs b/src/GitHub.InlineReviews/Margins/InlineCommentMarginProvider.cs
@@ -37,7 +37,7 @@ public InlineCommentMarginProvider(
             this.tagAggregatorFactory = tagAggregatorFactory;
             this.peekService = peekService;
 
-            uiContext = UIContext.FromUIContextGuid(new Guid(Guids.UIContext_Git));
+            uiContext = UIContext.FromUIContextGuid(new Guid(Guids.GitContextPkgString));
         }
 
         public IWpfTextViewMargin CreateMargin(IWpfTextViewHost wpfTextViewHost, IWpfTextViewMargin parent)
diff --git a/src/GitHub.InlineReviews/Margins/PullRequestFileMarginProvider.cs b/src/GitHub.InlineReviews/Margins/PullRequestFileMarginProvider.cs
@@ -42,7 +42,7 @@ public PullRequestFileMarginProvider(
             this.packageSettings = packageSettings;
             this.usageTracker = usageTracker;
 
-            uiContext = UIContext.FromUIContextGuid(new Guid(Guids.UIContext_Git));
+            uiContext = UIContext.FromUIContextGuid(new Guid(Guids.GitContextPkgString));
         }
 
         /// <summary>
diff --git a/src/GitHub.InlineReviews/PullRequestStatusBarPackage.cs b/src/GitHub.InlineReviews/PullRequestStatusBarPackage.cs
@@ -12,7 +12,7 @@ namespace GitHub.InlineReviews
 {
     [Guid(Guids.PullRequestStatusPackageId)]
     [PackageRegistration(UseManagedResourcesOnly = true, AllowsBackgroundLoading = true)]
-    [ProvideAutoLoad(Guids.UIContext_Git, PackageAutoLoadFlags.BackgroundLoad)]
+    [ProvideAutoLoad(Guids.GitContextPkgString, PackageAutoLoadFlags.BackgroundLoad)]
     public class PullRequestStatusBarPackage : AsyncPackage
     {
         /// <summary>
diff --git a/src/GitHub.Services.Vssdk/Commands/VsCommandBase.cs b/src/GitHub.Services.Vssdk/Commands/VsCommandBase.cs
@@ -4,6 +4,8 @@
 using GitHub.Commands;
 using Microsoft.VisualStudio.Shell;
 
+#pragma warning disable CA1033 // Interface methods should be callable by child types
+
 namespace GitHub.Services.Vssdk.Commands
 {
     /// <summary>
diff --git a/src/GitHub.Services.Vssdk/Services/TippingService.cs b/src/GitHub.Services.Vssdk/Services/TippingService.cs
@@ -75,11 +75,15 @@ void RequestCalloutDisplay(Guid clientId, Guid calloutId, string title, string m
         }
     }
 
+#pragma warning disable CA1715 // Identifiers should have correct prefix
+#pragma warning disable CA1040 // Avoid empty interfaces
     [Guid("DCCC6A2B-F300-4DA1-92E1-8BF4A5BCA795")]
     [InterfaceType(ComInterfaceType.InterfaceIsIUnknown)]
     [TypeIdentifier]
     [ComImport]
     public interface SVsTippingService
     {
     }
+#pragma warning restore CA1040 // Avoid empty interfaces
+#pragma warning restore CA1715 // Identifiers should have correct prefix
 }
diff --git a/src/GitHub.StartPage/GlobalSuppressions.cs b/src/GitHub.StartPage/GlobalSuppressions.cs
@@ -4,5 +4,7 @@
 // Project-level suppressions either have no target or are given 
 // a specific target and scoped to a namespace, type, member, etc.
 
-[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Style", "VSTHRD200:Use \"Async\" suffix for async methods")]
+using System.Diagnostics.CodeAnalysis;
 
+[assembly: SuppressMessage("Reliability", "CA2007:Do not directly await a Task", Justification = "Discouraged for VSSDK projects.")]
+[assembly: SuppressMessage("Style", "VSTHRD200:Use \"Async\" suffix for async methods")]
diff --git a/src/GitHub.TeamFoundation.14/GitHub.TeamFoundation.14.csproj b/src/GitHub.TeamFoundation.14/GitHub.TeamFoundation.14.csproj
@@ -79,6 +79,7 @@
     <Reference Include="WindowsBase" />
   </ItemGroup>
   <ItemGroup>
+    <Compile Include="GlobalSuppressions.cs" />
     <Compile Include="Services\VSGitExt.cs" />
     <Compile Include="Home\ForkNavigationItem.cs" />
     <Compile Include="RegistryHelper.cs" />
diff --git a/src/GitHub.TeamFoundation.14/GlobalSuppressions.cs b/src/GitHub.TeamFoundation.14/GlobalSuppressions.cs
@@ -0,0 +1,8 @@
+﻿// This file is used by Code Analysis to maintain SuppressMessage 
+// attributes that are applied to this project.
+// Project-level suppressions either have no target or are given 
+// a specific target and scoped to a namespace, type, member, etc.
+
+using System.Diagnostics.CodeAnalysis;
+
+[assembly: SuppressMessage("Reliability", "CA2007:Do not directly await a Task", Justification = "Discouraged for VSSDK projects.")]
diff --git a/src/GitHub.TeamFoundation.15/GitHub.TeamFoundation.15.csproj b/src/GitHub.TeamFoundation.15/GitHub.TeamFoundation.15.csproj
@@ -77,6 +77,9 @@
     <Reference Include="WindowsBase" />
   </ItemGroup>
   <ItemGroup>
+    <Compile Include="..\GitHub.TeamFoundation.14\GlobalSuppressions.cs">
+      <Link>GlobalSuppressions.cs</Link>
+    </Compile>
     <Compile Include="..\GitHub.TeamFoundation.14\Home\ForkNavigationItem.cs">
       <Link>Home\ForkNavigationItem.cs</Link>
     </Compile>
diff --git a/src/GitHub.TeamFoundation.16/GitHub.TeamFoundation.16.csproj b/src/GitHub.TeamFoundation.16/GitHub.TeamFoundation.16.csproj
@@ -85,6 +85,9 @@
     <Reference Include="WindowsBase" />
   </ItemGroup>
   <ItemGroup>
+    <Compile Include="..\GitHub.TeamFoundation.14\GlobalSuppressions.cs">
+      <Link>GlobalSuppressions.cs</Link>
+    </Compile>
     <Compile Include="..\GitHub.TeamFoundation.14\Home\ForkNavigationItem.cs">
       <Link>Home\ForkNavigationItem.cs</Link>
     </Compile>
diff --git a/src/GitHub.UI.Reactive/Validation/ReactiveValidatableObject.cs b/src/GitHub.UI.Reactive/Validation/ReactiveValidatableObject.cs
@@ -11,6 +11,8 @@
 using GitHub.Services;
 using GitHub.Extensions;
 
+#pragma warning disable CA1018 // Mark attributes with AttributeUsageAttribute
+
 namespace GitHub.Validation
 {
     public class ReactiveValidatableObject : ReactiveObject, IDataErrorInfo
diff --git a/src/GitHub.UI/Controls/ImageButton.cs b/src/GitHub.UI/Controls/ImageButton.cs
@@ -1,6 +1,8 @@
 ﻿using System.Windows;
 using System.Windows.Media;
 
+#pragma warning disable CA1720 // Identifier contains type name
+
 namespace GitHub.UI
 {
     public class ImageButton : DependencyObject
diff --git a/src/GitHub.UI/Helpers/LoadingResourceDictionary.cs b/src/GitHub.UI/Helpers/LoadingResourceDictionary.cs
diff --git a/src/GitHub.UI/Helpers/SharedDictionaryManager.cs b/src/GitHub.UI/Helpers/SharedDictionaryManager.cs
diff --git a/src/GitHub.VisualStudio.UI/Constants.cs b/src/GitHub.VisualStudio.UI/Constants.cs
diff --git a/src/GitHub.VisualStudio.UI/GlobalSuppressions.cs b/src/GitHub.VisualStudio.UI/GlobalSuppressions.cs
diff --git a/src/GitHub.VisualStudio.UI/Helpers/ThemeDictionaryManager.cs b/src/GitHub.VisualStudio.UI/Helpers/ThemeDictionaryManager.cs
diff --git a/src/GitHub.VisualStudio/Commands/OpenFromClipboardCommand.cs b/src/GitHub.VisualStudio/Commands/OpenFromClipboardCommand.cs
diff --git a/src/GitHub.VisualStudio/GitContextPackage.cs b/src/GitHub.VisualStudio/GitContextPackage.cs
diff --git a/src/GitHub.VisualStudio/GitHubPackage.cs b/src/GitHub.VisualStudio/GitHubPackage.cs
diff --git a/src/GitHub.VisualStudio/GlobalSuppressions.cs b/src/GitHub.VisualStudio/GlobalSuppressions.cs
diff --git a/test/Helpers/GlobalSuppressions.cs b/test/Helpers/GlobalSuppressions.cs

Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,7 @@`
`7`	`7`	`using ReactiveUI.Legacy;`
`8`	`8`
`9`	`9`	`#pragma warning disable CS0618 // Type or member is obsolete`
	`10`	`+#pragma warning disable CA1034 // Nested types should not be visible`
`10`	`11`
`11`	`12`	`namespace GitHub.Services`
`12`	`13`	`{`
Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,8 @@`
`22`	`22`	`using Serilog;`
`23`	`23`	`using static Octokit.GraphQL.Variable;`
`24`	`24`
	`25`	`+#pragma warning disable CA1034 // Nested types should not be visible`
	`26`	`+`
`25`	`27`	`namespace GitHub.Services`
`26`	`28`	`{`
`27`	`29`	`[Export(typeof(IModelService))]`