Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit aea6f73

Browse files
authored
Merge pull request #1768 from github/donokuda/pr-list-polish
PR list polish: Move comment count to the right
2 parents d2379e3 + 02fa2ed commit aea6f73

File tree

1 file changed

+51
-35
lines changed

1 file changed

+51
-35
lines changed

src/GitHub.VisualStudio/Views/GitHubPane/PullRequestListItemView.xaml

Lines changed: 51 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,9 @@
3030

3131
<Grid>
3232
<Image HorizontalAlignment="Left"
33-
Stretch="None"
34-
Opacity="0.2"
35-
Visibility="{Binding Converter={ghfvs:EqualsToVisibilityConverter {x:Null}}}">
33+
Stretch="None"
34+
Opacity="0.2"
35+
Visibility="{Binding Converter={ghfvs:EqualsToVisibilityConverter {x:Null}}}">
3636
<Image.Source>
3737
<DrawingImage>
3838
<DrawingImage.Drawing>
@@ -50,41 +50,57 @@
5050
</Image.Source>
5151
</Image>
5252

53-
<DockPanel Visibility="{Binding Converter={ghfvs:NullToVisibilityConverter}}">
54-
<views:ActorAvatarView DockPanel.Dock="Left"
55-
ViewModel="{Binding Author}"
56-
Margin="0,1,10,0"
57-
Width="30"
58-
Height="30"
59-
VerticalAlignment="Top"/>
53+
<Grid Visibility="{Binding Converter={ghfvs:NullToVisibilityConverter}}">
54+
<Grid.ColumnDefinitions>
55+
<ColumnDefinition Width="Auto" />
56+
<ColumnDefinition Width="*" />
57+
</Grid.ColumnDefinitions>
58+
<views:ActorAvatarView
59+
Grid.Column="0"
60+
ViewModel="{Binding Author}"
61+
Margin="0,1,4,0"
62+
Width="32"
63+
Height="32"
64+
VerticalAlignment="Top"/>
6065

61-
<ghfvs:OcticonImage DockPanel.Dock="Right"
62-
Background="Transparent"
63-
Icon="git_pull_request"
64-
ToolTip="This is the current branch"
65-
VerticalAlignment="Stretch"
66-
Visibility="{Binding IsCurrent, Converter={ghfvs:BooleanToVisibilityConverter}}"/>
66+
<StackPanel Grid.Column="1">
67+
<TextBlock DockPanel.Dock="Left"
68+
TextTrimming="CharacterEllipsis"
69+
Text="{Binding Title}">
70+
<TextBlock.Style>
71+
<Style TargetType="TextBlock">
72+
<Style.Triggers>
73+
<DataTrigger Binding="{Binding IsCurrent}" Value="True">
74+
<Setter Property="FontWeight" Value="Bold"/>
75+
</DataTrigger>
76+
</Style.Triggers>
77+
</Style>
78+
</TextBlock.Style>
79+
</TextBlock>
6780

68-
<TextBlock DockPanel.Dock="Top"
69-
Margin="0,-1,5,0"
70-
Text="{Binding Title}"
71-
TextTrimming="CharacterEllipsis"/>
81+
<Grid>
82+
<Grid.ColumnDefinitions>
83+
<ColumnDefinition Width="*" />
84+
<ColumnDefinition Width="Auto" />
85+
</Grid.ColumnDefinitions>
86+
<StackPanel Grid.Column="0" Orientation="Horizontal">
87+
<TextBlock Opacity="0.5" Margin="0 0 4 0">
88+
<Run Text="{Binding Number, Mode=OneWay, StringFormat=#{0}}"/>
89+
</TextBlock>
7290

73-
<StackPanel DockPanel.Dock="Top"
74-
Margin="0,2,5,0"
75-
Orientation="Horizontal"
76-
Opacity="0.5">
77-
<TextBlock>
78-
<Run Text="{Binding Number, Mode=OneWay, StringFormat=#{0}}"/>
79-
<Run Text="{Binding UpdatedAt, Converter={ghfvs:DurationToStringConverter}, Mode=OneWay}"/>
80-
by
81-
<Run Text="{Binding Author.Login, Mode=OneWay}"/>
82-
</TextBlock>
83-
<TextBlock Margin="4 0" Visibility="{Binding CommentCount, Converter={ghfvs:CountToVisibilityConverter}}">
84-
<ghfvs:OcticonImage Icon="comment" Width="16" Height="16" Margin="0 0 0 -4"/>
85-
<Run Text="{Binding CommentCount, Mode=OneWay}" BaselineAlignment="Top"/>
86-
</TextBlock>
91+
<TextBlock Opacity="0.5" TextTrimming="CharacterEllipsis">
92+
<Run Text="updated"/>
93+
<Run Text="{Binding UpdatedAt, Converter={ghfvs:DurationToStringConverter}, Mode=OneWay}"/>
94+
by
95+
<Run Text="{Binding Author.Login, Mode=OneWay}"/>
96+
</TextBlock>
97+
</StackPanel>
98+
99+
<TextBlock Opacity="0.5" Grid.Column="2" HorizontalAlignment="Right" VerticalAlignment="Center" Margin="8 0 0 0" Visibility="{Binding CommentCount, Converter={ghfvs:CountToVisibilityConverter}}"> <ghfvs:OcticonImage Icon="comment" Width="12" Height="12" Margin="0 0 0 -2"/>
100+
<Run Text="{Binding CommentCount, Mode=OneWay}" BaselineAlignment="Bottom"/>
101+
</TextBlock>
102+
</Grid>
87103
</StackPanel>
88-
</DockPanel>
104+
</Grid>
89105
</Grid>
90106
</UserControl>

0 commit comments

Comments
 (0)