Wait for probe up be finished in unit tests.

Author: grokys

src/GitHub.App/ViewModels/Dialog/LoginToGitHubForEnterpriseViewModel.cs

@@ -65,7 +65,7 @@ public LoginToGitHubForEnterpriseViewModel(
             this.WhenAnyValue(x => x.EnterpriseUrl, x => x.EnterpriseUrlValidator.ValidationResult)
                 .Throttle(TimeSpan.FromMilliseconds(500), scheduler)
                 .ObserveOn(RxApp.MainThreadScheduler)
-                .Subscribe(x => EnterpriseUrlChanged(x.Item1, x.Item2?.IsValid ?? false));
+                .Subscribe(x => UpdatingProbeStatus = EnterpriseUrlChanged(x.Item1, x.Item2?.IsValid ?? false));
 
             NavigateLearnMore = ReactiveCommand.CreateAsyncObservable(_ =>
             {
@@ -122,13 +122,19 @@ public IReactiveCommand<Unit> NavigateLearnMore
             get;
         }
 
+        public Task UpdatingProbeStatus
+        {
+            get;
+            private set;
+        }
+
         protected override async Task ResetValidation()
         {
             EnterpriseUrl = null;
             await EnterpriseUrlValidator.ResetAsync();
         }
 
-        async void EnterpriseUrlChanged(string url, bool valid)
+        async Task EnterpriseUrlChanged(string url, bool valid)
         {
             if (!valid)
             {

test/GitHub.App.UnitTests/ViewModels/Dialog/LoginToGitHubForEnterpriseViewModelTests.cs

@@ -47,7 +47,7 @@ public async Task ReturnsCheckingWhenProbeNotFinished()
         }
 
         [Test]
-        public void ReturnsValidWhenProbeReturnsOk()
+        public async Task ReturnsValidWhenProbeReturnsOk()
         {
             var scheduler = new TestScheduler();
             var caps = CreateCapabilties(EnterpriseProbeResult.Ok);
@@ -56,12 +56,13 @@ public void ReturnsValidWhenProbeReturnsOk()
             target.EnterpriseUrl = "https://foo.bar";
             scheduler.AdvanceBy(TimeSpan.FromMilliseconds(500).Ticks);
             scheduler.Stop();
+            await target.UpdatingProbeStatus;
 
             Assert.That(EnterpriseProbeStatus.Valid, Is.EqualTo(target.ProbeStatus));
         }
 
         [Test]
-        public void ReturnsInvalidWhenProbeReturnsFailed()
+        public async Task ReturnsInvalidWhenProbeReturnsFailed()
         {
             var scheduler = new TestScheduler();
             var caps = CreateCapabilties(EnterpriseProbeResult.Failed);
@@ -70,12 +71,13 @@ public void ReturnsInvalidWhenProbeReturnsFailed()
             target.EnterpriseUrl = "https://foo.bar";
             scheduler.AdvanceBy(TimeSpan.FromMilliseconds(500).Ticks);
             scheduler.Stop();
+            await target.UpdatingProbeStatus;
 
             Assert.That(EnterpriseProbeStatus.Invalid, Is.EqualTo(target.ProbeStatus));
         }
 
         [Test]
-        public void ReturnsInvalidWhenProbeReturnsNotFound()
+        public async Task ReturnsInvalidWhenProbeReturnsNotFound()
         {
             var scheduler = new TestScheduler();
             var caps = CreateCapabilties(EnterpriseProbeResult.NotFound);
@@ -84,6 +86,7 @@ public void ReturnsInvalidWhenProbeReturnsNotFound()
             target.EnterpriseUrl = "https://foo.bar";
             scheduler.AdvanceBy(TimeSpan.FromMilliseconds(500).Ticks);
             scheduler.Stop();
+            await target.UpdatingProbeStatus;
 
             Assert.That(EnterpriseProbeStatus.Invalid, Is.EqualTo(target.ProbeStatus));
         }