Merge pull request #1472 from github/fixes/log-at-correct-levels

Log things at appropriate levels

Author: shana

src/GitHub.App/Api/ApiClient.cs

@@ -157,7 +157,7 @@ static string GetMachineNameSafe()
             }
             catch (Exception e)
             {
-                log.Information(e, "Failed to retrieve host name using `DNS.GetHostName`");
+                log.Warning(e, "Failed to retrieve host name using `DNS.GetHostName`");
                 try
                 {
                     return Environment.MachineName;

src/GitHub.App/Services/TeamExplorerContext.cs

@@ -65,7 +65,7 @@ void Refresh()
                 {
                     // Ignore when ActiveRepositories is empty and solution hasn't changed.
                     // https://github.com/github/VisualStudio/issues/1421
-                    log.Information("Ignoring no ActiveRepository when solution hasn't changed");
+                    log.Debug("Ignoring no ActiveRepository when solution hasn't changed");
                 }
                 else
                 {
@@ -76,22 +76,22 @@ void Refresh()
 
                     if (newRepositoryPath != repositoryPath)
                     {
-                        log.Information("Fire PropertyChanged event for ActiveRepository");
+                        log.Debug("Fire PropertyChanged event for ActiveRepository");
                         ActiveRepository = repo;
                     }
                     else if (newBranchName != branchName)
                     {
-                        log.Information("Fire StatusChanged event when BranchName changes for ActiveRepository");
+                        log.Debug("Fire StatusChanged event when BranchName changes for ActiveRepository");
                         StatusChanged?.Invoke(this, EventArgs.Empty);
                     }
                     else if (newHeadSha != headSha)
                     {
-                        log.Information("Fire StatusChanged event when HeadSha changes for ActiveRepository");
+                        log.Debug("Fire StatusChanged event when HeadSha changes for ActiveRepository");
                         StatusChanged?.Invoke(this, EventArgs.Empty);
                     }
                     else if (newTrackedSha != trackedSha)
                     {
-                        log.Information("Fire StatusChanged event when TrackedSha changes for ActiveRepository");
+                        log.Debug("Fire StatusChanged event when TrackedSha changes for ActiveRepository");
                         StatusChanged?.Invoke(this, EventArgs.Empty);
                     }
 

src/GitHub.App/ViewModels/Dialog/LoginTabViewModel.cs

@@ -200,7 +200,7 @@ void HandleError(Exception ex)
 
             if (ex.IsCriticalException()) return;
 
-            log.Information(ex, "Error logging into '{BaseUri}' as '{UsernameOrEmail}'", BaseUri, UsernameOrEmail);
+            log.Error(ex, "Error logging into '{BaseUri}' as '{UsernameOrEmail}'", BaseUri, UsernameOrEmail);
             if (ex is Octokit.ForbiddenException)
             {
                 Error = new UserError(Resources.LoginFailedForbiddenMessage, ex.Message);

src/GitHub.TeamFoundation.14/Connect/GitHubConnectSection.cs

@@ -360,9 +360,7 @@ void ShowNotification(ILocalRepositoryModel newrepo, string msg)
                     }
                 })
             );
-#if DEBUG
-            log.Information("Notification");
-#endif
+            log.Debug("Notification");
         }
 
         async Task RefreshRepositories()
@@ -496,12 +494,10 @@ void TrackState(object sender, PropertyChangedEventArgs e)
             {
                 if (machine.PermittedTriggers.Contains(e.PropertyName))
                 {
-#if DEBUG
-                    log.Information("{PropertyName} title:{Title} busy:{IsBusy}",
+                    log.Debug("{PropertyName} title:{Title} busy:{IsBusy}",
                         e.PropertyName,
                         ((ITeamExplorerSection)sender).Title,
                         ((ITeamExplorerSection)sender).IsBusy);
-#endif
                     machine.Fire(e.PropertyName);
                 }
             }

src/GitHub.TeamFoundation.14/Services/VSGitExt.cs

@@ -55,7 +55,7 @@ public VSGitExt(IGitHubServiceProvider serviceProvider, IVSUIContextFactory fact
             {
                 // If we're not in the UIContext or TryInitialize fails, have another go when the UIContext changes.
                 context.UIContextChanged += ContextChanged;
-                log.Information("VSGitExt will be initialized later");
+                log.Debug("VSGitExt will be initialized later");
                 InitializeTask = Task.CompletedTask;
             }
         }
@@ -69,7 +69,7 @@ void ContextChanged(object sender, VSUIContextChangedEventArgs e)
                 // Refresh ActiveRepositories on background thread so we don't delay UI context change.
                 InitializeTask = Task.Run(() => RefreshActiveRepositories());
                 context.UIContextChanged -= ContextChanged;
-                log.Information("Initialized VSGitExt on UIContextChanged");
+                log.Debug("Initialized VSGitExt on UIContextChanged");
             }
         }
 
@@ -86,11 +86,11 @@ bool TryInitialize()
                     }
                 };
 
-                log.Information("Found IGitExt service and initialized VSGitExt");
+                log.Debug("Found IGitExt service and initialized VSGitExt");
                 return true;
             }
 
-            log.Information("Couldn't find IGitExt service");
+            log.Error("Couldn't find IGitExt service");
             return false;
         }