Fix pending reviews.

Author: grokys

src/GitHub.App/ViewModels/PullRequestReviewCommentThreadViewModel.cs

@@ -106,7 +106,12 @@ await vm.InitializeAsync(
             if (addPlaceholder)
             {
                 var vm = factory.CreateViewModel<IPullRequestReviewCommentViewModel>();
-                await vm.InitializeAsPlaceholderAsync(session, this, false).ConfigureAwait(true);
+
+                await vm.InitializeAsPlaceholderAsync(
+                    session,
+                    this,
+                    review.State == PullRequestReviewState.Pending,
+                    false).ConfigureAwait(true);
 
                 var (key, secondaryKey) = GetDraftKeys(vm);
                 var draft = await DraftStore.GetDraft<PullRequestReviewCommentDraft>(key, secondaryKey).ConfigureAwait(true);
@@ -140,7 +145,7 @@ public async Task InitializeNewAsync(
             IsNewThread = true;
 
             var vm = factory.CreateViewModel<IPullRequestReviewCommentViewModel>();
-            await vm.InitializeAsPlaceholderAsync(session, this, isEditing).ConfigureAwait(false);
+            await vm.InitializeAsPlaceholderAsync(session, this, session.HasPendingReview, isEditing).ConfigureAwait(false);
 
             var (key, secondaryKey) = GetDraftKeys(vm);
             var draft = await DraftStore.GetDraft<PullRequestReviewCommentDraft>(key, secondaryKey).ConfigureAwait(true);

src/GitHub.App/ViewModels/PullRequestReviewCommentViewModel.cs

@@ -67,6 +67,7 @@ public async Task InitializeAsync(
         public async Task InitializeAsPlaceholderAsync(
             IPullRequestSession session,
             ICommentThreadViewModel thread,
+            bool isPending,
             bool isEditing)
         {
             Guard.ArgumentNotNull(session, nameof(session));
@@ -77,6 +78,7 @@ await InitializeAsync(
                 null,
                 isEditing ? CommentEditState.Editing : CommentEditState.Placeholder).ConfigureAwait(true);
             this.session = session;
+            IsPending = isPending;
         }
 
         /// <inheritdoc/>
@@ -101,7 +103,7 @@ async Task DoStartReview()
 
             try
             {
-                await session.StartReview().ConfigureAwait(false);
+                await session.StartReview().ConfigureAwait(true);
                 await CommitEdit.Execute();
             }
             finally

src/GitHub.Exports.Reactive/ViewModels/IPullRequestReviewCommentViewModel.cs

@@ -55,10 +55,12 @@ Task InitializeAsync(
         /// </summary>
         /// <param name="session">The pull request session.</param>
         /// <param name="thread">The thread that the comment is a part of.</param>
+        /// <param name="isPending">Whether the comment thread is a pending review thread.</param>
         /// <param name="isEditing">Whether to start the placeholder in edit mode.</param>
         Task InitializeAsPlaceholderAsync(
             IPullRequestSession session,
             ICommentThreadViewModel thread,
+            bool isPending,
             bool isEditing);
     }
 }

test/GitHub.App.UnitTests/ViewModels/PullRequestReviewCommentViewModelTests.cs

@@ -56,7 +56,7 @@ public async Task CanBeExecutedForPlaceholders()
                 var commentService = Substitute.For<ICommentService>();
                 var target = new PullRequestReviewCommentViewModel(commentService);
 
-                await target.InitializeAsPlaceholderAsync(session, thread, false);
+                await target.InitializeAsPlaceholderAsync(session, thread, false, false);
 
                 Assert.That(target.BeginEdit.CanExecute(new object()), Is.True);
             }
@@ -100,7 +100,7 @@ public async Task CannotBeExecutedForPlaceholders()
                 var commentService = Substitute.For<ICommentService>();
                 var target = new PullRequestReviewCommentViewModel(commentService);
 
-                await target.InitializeAsPlaceholderAsync(session, thread, false);
+                await target.InitializeAsPlaceholderAsync(session, thread, false, false);
 
                 Assert.That(target.Delete.CanExecute(new object()), Is.False);
             }