Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit b58ae5b

Browse files
Fixing tests
1 parent 09da406 commit b58ae5b

File tree

1 file changed

+17
-8
lines changed

1 file changed

+17
-8
lines changed

test/GitHub.InlineReviews.UnitTests/Services/PullRequestSessionTests.cs

Lines changed: 17 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ namespace GitHub.InlineReviews.UnitTests.Services
2020
public class PullRequestSessionTests
2121
{
2222
const int PullRequestNumber = 5;
23+
const string PullRequestNodeId = "pull_request_id";
2324
const string RepoUrl = "https://foo.bar/owner/repo";
2425
const string FilePath = "test.cs";
2526

@@ -514,16 +515,15 @@ public class ThePostReviewCommentMethod
514515
[Test]
515516
public async Task PostsToCorrectForkWithNoPendingReview()
516517
{
517-
var service = Substitute.For<IPullRequestSessionService>();
518+
var service = CreateService();
518519
var target = CreateTarget(service, "fork", "owner", false);
519520

520521
await target.PostReviewComment("New Comment", "COMMIT_ID", "file.cs", new DiffChunk[0], 1);
521522

522523
await service.Received(1).PostStandaloneReviewComment(
523524
target.LocalRepository,
524-
"owner",
525525
target.User,
526-
PullRequestNumber,
526+
PullRequestNodeId,
527527
"New Comment",
528528
"COMMIT_ID",
529529
"file.cs",
@@ -533,24 +533,23 @@ await service.Received(1).PostStandaloneReviewComment(
533533
[Test]
534534
public async Task PostsReplyToCorrectForkWithNoPendingReview()
535535
{
536-
var service = Substitute.For<IPullRequestSessionService>();
536+
var service = CreateService();
537537
var target = CreateTarget(service, "fork", "owner", false);
538538

539539
await target.PostReviewComment("New Comment", 1, "node1");
540540

541541
await service.Received(1).PostStandaloneReviewCommentReply(
542542
target.LocalRepository,
543-
"owner",
544543
target.User,
545-
PullRequestNumber,
544+
PullRequestNodeId,
546545
"New Comment",
547546
1);
548547
}
549548

550549
[Test]
551550
public async Task PostsToCorrectForkWithPendingReview()
552551
{
553-
var service = Substitute.For<IPullRequestSessionService>();
552+
var service = CreateService();
554553
var target = CreateTarget(service, "fork", "owner", true);
555554

556555
await target.PostReviewComment("New Comment", "COMMIT_ID", "file.cs", new DiffChunk[0], 1);
@@ -568,7 +567,7 @@ await service.Received(1).PostPendingReviewComment(
568567
[Test]
569568
public async Task PostsReplyToCorrectForkWithPendingReview()
570569
{
571-
var service = Substitute.For<IPullRequestSessionService>();
570+
var service = CreateService();
572571
var target = CreateTarget(service, "fork", "owner", true);
573572

574573
await target.PostReviewComment("New Comment", 1, "node1");
@@ -581,6 +580,16 @@ await service.Received(1).PostPendingReviewCommentReply(
581580
"node1");
582581
}
583582

583+
static IPullRequestSessionService CreateService()
584+
{
585+
var service = Substitute.For<IPullRequestSessionService>();
586+
587+
service.GetGraphQLPullRequestId(Arg.Any<ILocalRepositoryModel>(), Arg.Any<string>(), Arg.Any<int>())
588+
.Returns(PullRequestNodeId);
589+
590+
return service;
591+
}
592+
584593
PullRequestSession CreateTarget(
585594
IPullRequestSessionService service,
586595
string localRepositoryOwner,

0 commit comments

Comments
 (0)