Fix broken Browser service.

grokys · grokys · commit b7cf3dfdbff0 · 2019-01-10T12:04:00.000+01:00
ba83824 changed `Browser.cs` to add a call to `ThreadHelper.ThrowIfNotOnUIThread();`. However it _also_ erroneously changed the code to not return the result of `service.CreateExternalWebBrowser` to the caller, breaking the browser on VS2015.
diff --git a/src/GitHub.VisualStudio/Helpers/Browser.cs b/src/GitHub.VisualStudio/Helpers/Browser.cs
@@ -44,7 +44,7 @@ public void OpenUrl(Uri uri)
                 int result = ErrorHandler.CallWithCOMConvention(() =>
                 {
                     ThreadHelper.ThrowIfNotOnUIThread();
-                    service.CreateExternalWebBrowser((uint)createFlags, resolution, uri.AbsoluteUri);
+                    return service.CreateExternalWebBrowser((uint)createFlags, resolution, uri.AbsoluteUri);
                 });
 
                 if (ErrorHandler.Succeeded(result))

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ public void OpenUrl(Uri uri)`
`44`	`44`	`int result = ErrorHandler.CallWithCOMConvention(() =>`
`45`	`45`	`{`
`46`	`46`	`ThreadHelper.ThrowIfNotOnUIThread();`
`47`		`- service.CreateExternalWebBrowser((uint)createFlags, resolution, uri.AbsoluteUri);`
	`47`	`+ return service.CreateExternalWebBrowser((uint)createFlags, resolution, uri.AbsoluteUri);`
`48`	`48`	`});`
`49`	`49`
`50`	`50`	`if (ErrorHandler.Succeeded(result))`