Use VsCommand in GitHub.VisualStudio.

And remove old menu framework-related code.

Author: grokys

src/GitHub.App/ViewModels/GitHubPane/GitHubPaneViewModel.cs

@@ -50,6 +50,7 @@ public sealed class GitHubPaneViewModel : ViewModelBase, IGitHubPaneViewModel, I
         readonly ReactiveCommand<Unit> refresh;
         readonly ReactiveCommand<Unit> showPullRequests;
         readonly ReactiveCommand<object> openInBrowser;
+        readonly ReactiveCommand<object> help;
         readonly SemaphoreSlim initializing = new SemaphoreSlim(1);
         bool initialized;
         IViewModel content;
@@ -157,6 +158,13 @@ public GitHubPaneViewModel(
                 if (url != null) browser.OpenUrl(url);
             });
 
+            help = ReactiveCommand.Create();
+            help.Subscribe(_ =>
+            {
+                browser.OpenUrl(new Uri(GitHubUrls.Documentation));
+                usageTracker.IncrementCounter(x => x.NumberOfGitHubPaneHelpClicks).Forget();
+            });
+
             navigator.WhenAnyObservable(x => x.Content.NavigationRequested)
                 .Subscribe(x => NavigateTo(x).Forget());
 
@@ -231,13 +239,7 @@ public async Task InitializeAsync(IServiceProvider paneServiceProvider)
                 BindNavigatorCommand(menuService, PkgCmdIDList.forwardCommand, navigator.NavigateForward);
                 BindNavigatorCommand(menuService, PkgCmdIDList.refreshCommand, refresh);
                 BindNavigatorCommand(menuService, PkgCmdIDList.githubCommand, openInBrowser);
-
-                paneServiceProvider.AddCommandHandler(Guids.guidGitHubToolbarCmdSet, PkgCmdIDList.helpCommand,
-                     (_, __) =>
-                     {
-                         browser.OpenUrl(new Uri(GitHubUrls.Documentation));
-                         usageTracker.IncrementCounter(x => x.NumberOfGitHubPaneHelpClicks).Forget();
-                     });
+                BindNavigatorCommand(menuService, PkgCmdIDList.helpCommand, help);
             }
             finally
             {

src/GitHub.Exports/Commands/IAddConnectionCommand.cs

@@ -0,0 +1,11 @@
+using System;
+
+namespace GitHub.Commands
+{
+    /// <summary>
+    /// Opens the login dialog to add a new connection to Team Explorer.
+    /// </summary>
+    public interface IAddConnectionCommand : IVsCommand
+    {
+    }
+}

src/GitHub.Exports/Commands/IBlameLinkCommand.cs

@@ -0,0 +1,12 @@
+using System;
+
+namespace GitHub.Commands
+{
+    /// <summary>
+    /// Opens the blame view for the currently selected text on GitHub.com or an Enterprise
+    /// instance.
+    /// </summary>
+    public interface IBlameLinkCommand : IVsCommand
+    {
+    }
+}

src/GitHub.Exports/Commands/ICopyLinkCommand.cs

@@ -0,0 +1,12 @@
+using System;
+
+namespace GitHub.Commands
+{
+    /// <summary>
+    /// Copies a link to the clipboard of the currently selected text on GitHub.com or an
+    /// Enterprise instance.
+    /// </summary>
+    public interface ICopyLinkCommand : IVsCommand
+    {
+    }
+}

src/GitHub.Exports/Commands/ICreateGistCommand.cs

@@ -0,0 +1,11 @@
+using System;
+
+namespace GitHub.Commands
+{
+    /// <summary>
+    /// Creates a gist from the currently selected text.
+    /// </summary>
+    public interface ICreateGistCommand : IVsCommand
+    {
+    }
+}

src/GitHub.Exports/Commands/IOpenLinkCommand.cs

@@ -0,0 +1,11 @@
+using System;
+
+namespace GitHub.Commands
+{
+    /// <summary>
+    /// Opens the currently selected text on GitHub.com or an Enterprise instance.
+    /// </summary>
+    public interface IOpenLinkCommand : IVsCommand
+    {
+    }
+}

src/GitHub.Exports/Commands/IOpenPullRequestsCommand.cs

@@ -0,0 +1,11 @@
+using System;
+
+namespace GitHub.Commands
+{
+    /// <summary>
+    /// Opens the GitHub pane and shows the pull request list.
+    /// </summary>
+    public interface IOpenPullRequestsCommand : IVsCommand
+    {
+    }
+}

src/GitHub.Exports/Commands/IShowCurrentPullRequestCommand.cs

@@ -0,0 +1,14 @@
+using System;
+
+namespace GitHub.Commands
+{
+    /// <summary>
+    /// Opens the GitHub pane and shows the currently checked out pull request.
+    /// </summary>
+    /// <remarks>
+    /// Does nothing if there is no checked out pull request.
+    /// </remarks>
+    public interface IShowCurrentPullRequestCommand : IVsCommand
+    {
+    }
+}

src/GitHub.Exports/Commands/IShowGitHubPaneCommand.cs

@@ -0,0 +1,11 @@
+using System;
+
+namespace GitHub.Commands
+{
+    /// <summary>
+    /// Opens the GitHub pane.
+    /// </summary>
+    public interface IShowGitHubPaneCommand : IVsCommand
+    {
+    }
+}

src/GitHub.Exports/Exports/ExportMetadata.cs

@@ -1,10 +1,7 @@
 using System;
 using System.ComponentModel.Composition;
 using System.Diagnostics.CodeAnalysis;
-using System.Linq;
-using System.Reflection;
 using System.Windows;
-using GitHub.VisualStudio;
 
 namespace GitHub.Exports
 {
@@ -45,21 +42,6 @@ public ExportViewForAttribute(Type viewModelType)
         public string ViewModelType { get; }
     }
 
-    /// <summary>
-    /// A MEF export attribute that defines an export of type <see cref="IMenuHandler"/> with
-    /// <see cref="MenuType"/> metadata.
-    /// </summary>
-    [MetadataAttribute]
-    [AttributeUsage(AttributeTargets.Class, AllowMultiple = false)]
-    public sealed class ExportMenuAttribute : ExportAttribute
-    {
-        public ExportMenuAttribute() : base(typeof(IMenuHandler))
-        {
-        }
-
-        public MenuType MenuType { get; set; }
-    }
-
     /// <summary>
     /// Defines a MEF metadata view that matches <see cref="ExportViewModelForAttribute"/> and
     /// <see cref="ExportViewForAttribute"/>.
@@ -73,35 +55,4 @@ public interface IViewModelMetadata
         [SuppressMessage("Microsoft.Performance", "CA1819:PropertiesShouldNotReturnArrays")]
         string[] ViewModelType { get; }
     }
-
-    /// <summary>
-    /// Defines a MEF metadata view that matches <see cref="ExportMenuAttribute"/>.
-    /// </summary>
-    /// <remarks>
-    /// For more information see the Metadata and Metadata views section at
-    /// https://msdn.microsoft.com/en-us/library/ee155691(v=vs.110).aspx#Anchor_3
-    /// </remarks>
-    public interface IMenuMetadata
-    {
-        MenuType MenuType { get; }
-    }
-
-    public static class ExportMetadataAttributeExtensions
-    {
-        public static bool IsMenuType(this IMenuHandler c, MenuType type)
-        {
-            return c.GetType().GetCustomAttributesData().Any(attr => IsMenuType(attr, type));
-        }
-
-        static bool IsMenuType(CustomAttributeData attributeData, MenuType type)
-        {
-            if (attributeData.NamedArguments == null)
-            {
-                throw new GitHubLogicException("attributeData.NamedArguments may not be null");
-            }
-
-            return attributeData.AttributeType == typeof(ExportMenuAttribute)
-                && (MenuType)attributeData.NamedArguments[0].TypedValue.Value == type;
-        }
-    }
 }