Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit b8f21cc

Browse files
committed
Use ToUpperInvariant not ToUpper(CultureInfo)
Misc formatting cleanup.
1 parent ea571d4 commit b8f21cc

File tree

5 files changed

+7
-8
lines changed

5 files changed

+7
-8
lines changed

src/GitHub.App/ViewModels/GitHubPane/IssueListViewModelBase.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,7 @@ void FilterChanged()
253253

254254
if (numberFilter == 0)
255255
{
256-
stringFilter = SearchQuery.ToUpper(CultureInfo.CurrentCulture);
256+
stringFilter = SearchQuery.ToUpperInvariant();
257257
}
258258
}
259259
else
@@ -281,7 +281,7 @@ bool FilterItem(object o)
281281
}
282282
else
283283
{
284-
result = item.Title.ToUpper(CultureInfo.InvariantCulture).Contains(stringFilter);
284+
result = item.Title.ToUpperInvariant().Contains(stringFilter);
285285
}
286286
}
287287
}

src/GitHub.App/ViewModels/GitHubPane/PullRequestDetailViewModel.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ public PullRequestDetailViewModel(
131131
SubscribeOperationError(SyncSubmodules);
132132

133133
OpenOnGitHub = ReactiveCommand.Create(DoOpenDetailsUrl);
134-
134+
135135
ShowReview = ReactiveCommand.Create<IPullRequestReviewSummaryViewModel>(DoShowReview);
136136

137137
ShowAnnotations = ReactiveCommand.Create<IPullRequestCheckViewModel>(DoShowAnnotations);
@@ -350,7 +350,7 @@ public async Task Load(PullRequestDetailModel pullRequest)
350350
Body = !string.IsNullOrWhiteSpace(pullRequest.Body) ? pullRequest.Body : Resources.NoDescriptionProvidedMarkdown;
351351
Reviews = PullRequestReviewSummaryViewModel.BuildByUser(Session.User, pullRequest).ToList();
352352

353-
Checks = (IReadOnlyList<IPullRequestCheckViewModel>) PullRequestCheckViewModel.Build(viewViewModelFactory, pullRequest)?.ToList() ?? Array.Empty<IPullRequestCheckViewModel>();
353+
Checks = (IReadOnlyList<IPullRequestCheckViewModel>)PullRequestCheckViewModel.Build(viewViewModelFactory, pullRequest)?.ToList() ?? Array.Empty<IPullRequestCheckViewModel>();
354354

355355
await Files.InitializeAsync(Session);
356356

src/GitHub.Exports/Models/DiffUtilities.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
using System;
22
using System.IO;
3+
using System.Globalization;
34
using System.Collections.Generic;
45
using System.Text.RegularExpressions;
56
using System.Diagnostics.CodeAnalysis;
67
using GitHub.Extensions;
7-
using System.Globalization;
88

99
#pragma warning disable CA1034 // Nested types should not be visible
1010

src/GitHub.Exports/Settings/Guids.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ public static class Guids
2323
public const string GitSccProviderId = "11B8E6D7-C08B-4385-B321-321078CDD1F8";
2424
public const string TeamExplorerInstall3rdPartyGitTools = "DF785C7C-8454-4836-9686-D1C4A01D0BB9";
2525

26-
2726
// UIContexts
2827
public const string GitContextPkgString = "565515AD-F4C1-4D59-BC14-AE77396DDDD7";
2928

src/GitHub.UI.Reactive/Controls/TwoFactorInput.xaml.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ public TwoFactorInput()
4242
six
4343
};
4444

45-
foreach(var textBox in TextBoxes)
45+
foreach (var textBox in TextBoxes)
4646
{
4747
SetupTextBox(textBox);
4848
}
@@ -151,7 +151,7 @@ private void SetupTextBox(TextBox textBox)
151151
textBox.SelectAll();
152152
}
153153
};
154-
154+
155155
textBox.TextChanged += (sender, args) =>
156156
{
157157
SetValue(TextProperty, String.Join("", GetTwoFactorCode()));

0 commit comments

Comments
 (0)