Renamed OpenPROnGitHub to OpenPullRequestOnGitHub

Author: jcansdale

src/GitHub.App/SampleData/PullRequestListViewModelDesigner.cs

@@ -76,6 +76,6 @@ public PullRequestListViewModelDesigner()
 
         public ReactiveCommand<object> OpenPullRequest { get; }
         public ReactiveCommand<object> CreatePullRequest { get; }
-        public ReactiveCommand<object> OpenPROnGitHub { get; }
+        public ReactiveCommand<object> OpenPullRequestOnGitHub { get; }
     }
 }

src/GitHub.App/ViewModels/PullRequestListViewModel.cs

@@ -112,8 +112,8 @@ public PullRequestListViewModel(
             CreatePullRequest = ReactiveCommand.Create();
             CreatePullRequest.Subscribe(_ => DoCreatePullRequest());
 
-            OpenPROnGitHub = ReactiveCommand.Create();
-            OpenPROnGitHub.Subscribe(x => DoOpenPROnGitHub((int)x));
+            OpenPullRequestOnGitHub = ReactiveCommand.Create();
+            OpenPullRequestOnGitHub.Subscribe(x => DoOpenPROnGitHub((int)x));
 
             constructing = false;
         }
@@ -276,7 +276,7 @@ public IAccount EmptyUser
         public ReactiveCommand<object> OpenPullRequest { get; }
         public ReactiveCommand<object> CreatePullRequest { get; }
 
-        public ReactiveCommand<object> OpenPROnGitHub { get; }
+        public ReactiveCommand<object> OpenPullRequestOnGitHub { get; }
 
         bool disposed;
         protected void Dispose(bool disposing)

src/GitHub.Exports.Reactive/ViewModels/IPullRequestListViewModel.cs

@@ -41,6 +41,6 @@ public interface IPullRequestListViewModel : IViewModel, ICanNavigate, IHasBusy
         IAccount SelectedAssignee { get; set; }
         ReactiveCommand<object> OpenPullRequest { get; }
         ReactiveCommand<object> CreatePullRequest { get; }
-        ReactiveCommand<object> OpenPROnGitHub { get; }
+        ReactiveCommand<object> OpenPullRequestOnGitHub { get; }
     }
 }

src/GitHub.VisualStudio/UI/Views/Controls/PullRequestListItem.xaml

@@ -108,7 +108,7 @@
         </Grid.ColumnDefinitions>
         <Button x:Name="prHashtagLink"
                 Grid.Column="0"
-                Command="{Binding ViewModel.OpenPROnGitHub, RelativeSource={RelativeSource FindAncestor, AncestorType={x:Type local:PullRequestListView}}}"
+                Command="{Binding ViewModel.OpenPullRequestOnGitHub, RelativeSource={RelativeSource FindAncestor, AncestorType={x:Type local:PullRequestListView}}}"
                 CommandParameter="{Binding Number}"
                 Content="{Binding Number}"
                 ToolTip="{x:Static prop:Resources.OpenPROnGitHubToolTip}"

src/UnitTests/GitHub.App/ViewModels/PullRequestListViewModelTests.cs

@@ -93,7 +93,7 @@ public void ResettingAuthorToNoneShouldNotTriggerFilter()
 
         [Theory]
         [InlineData("https://github.com/owner/repo", 666, "https://github.com/owner/repo/pull/666")]
-        public void OpenPROnGitHubShouldOpenBrowser(string cloneUrl, int pullNumber, string expectUrl)
+        public void OpenPullRequestOnGitHubShouldOpenBrowser(string cloneUrl, int pullNumber, string expectUrl)
         {
             var repositoryHost = CreateRepositoryHost();
             var repository = Substitute.For<ILocalRepositoryModel>();
@@ -103,7 +103,7 @@ public void OpenPROnGitHubShouldOpenBrowser(string cloneUrl, int pullNumber, str
             prViewModel.SelectedRepository = Substitute.For<IRemoteRepositoryModel>();
             prViewModel.SelectedRepository.CloneUrl.Returns(new UriString(cloneUrl));
 
-            prViewModel.OpenPROnGitHub.Execute(pullNumber);
+            prViewModel.OpenPullRequestOnGitHub.Execute(pullNumber);
 
             browser.ReceivedWithAnyArgs(1).OpenUrl(new Uri(expectUrl));
         }