Stop hardcoding db index keys and change the format to not clash

Author: shana

src/GitHub.App/Caches/CacheIndex.cs

@@ -10,6 +10,11 @@ namespace GitHub.Caches
 {
     public class CacheIndex
     {
+        public const string PRPrefix = "index:pr";
+        public const string RepoPrefix = "index:repos";
+        public const string GitIgnoresPrefix = "index:ignores";
+        public const string LicensesPrefix = "index:licenses";
+
         public static CacheIndex Create(string key)
         {
             return new CacheIndex { IndexKey = key };

src/GitHub.App/Services/ModelService.cs

@@ -39,7 +39,7 @@ public ModelService(IApiClient apiClient, IBlobCache hostCache, IAvatarProvider
         public IObservable<GitIgnoreItem> GetGitIgnoreTemplates()
         {
             return Observable.Defer(() =>
-                hostCache.GetAndFetchLatestFromIndex("global|ignores", () =>
+                hostCache.GetAndFetchLatestFromIndex(CacheIndex.GitIgnoresPrefix, () =>
                         GetGitIgnoreTemplatesFromApi(),
                         item => { },
                         TimeSpan.FromMinutes(1),
@@ -56,7 +56,7 @@ public IObservable<GitIgnoreItem> GetGitIgnoreTemplates()
         public IObservable<LicenseItem> GetLicenses()
         {
             return Observable.Defer(() =>
-                hostCache.GetAndFetchLatestFromIndex("global|licenses", () =>
+                hostCache.GetAndFetchLatestFromIndex(CacheIndex.LicensesPrefix, () =>
                         GetLicensesFromApi(),
                         item => { },
                         TimeSpan.FromMinutes(1),
@@ -144,7 +144,7 @@ public ITrackingCollection<IPullRequestModel> GetPullRequests(ISimpleRepositoryM
             // and replaces it instead of appending, so items get refreshed in-place as they come in.
 
             var keyobs = GetUserFromCache()
-                .Select(user => string.Format(CultureInfo.InvariantCulture, "{0}|{1}|pr", user.Login, repo.Name));
+                .Select(user => string.Format(CultureInfo.InvariantCulture, "{0}|{1}:{2}", CacheIndex.PRPrefix, user.Login, repo.Name));
 
             var source = Observable.Defer(() => keyobs
                 .SelectMany(key =>

src/UnitTests/GitHub.App/Models/ModelServiceTests.cs

@@ -72,7 +72,7 @@ public async Task CanRetrieveAndCacheGitIgnores()
             for (int i = 0; i < data.Length; i++)
                 Assert.Equal(data[i], fetched[i].Name);
 
-            var indexKey = "global|ignores";
+            var indexKey = CacheIndex.GitIgnoresPrefix;
             var cached = await cache.GetObject<CacheIndex>(indexKey);
             Assert.Equal(3, cached.Keys.Count);
 
@@ -104,7 +104,7 @@ public async Task CanRetrieveAndCacheLicenses()
             for (int i = 0; i < data.Length; i++)
                 Assert.Equal(data[i].Name, fetched[i].Name);
 
-            var indexKey = "global|licenses";
+            var indexKey = CacheIndex.LicensesPrefix;
             var cached = await cache.GetObject<CacheIndex>(indexKey);
             Assert.Equal(2, cached.Keys.Count);