Rename CreateCurrentBranchModel to GetBranch

Author: jcansdale

src/GitHub.App/SampleData/GitServiceDesigner.cs

@@ -9,7 +9,7 @@ namespace GitHub.SampleData
     class GitServiceDesigner : IGitService
     {
         public ILocalRepositoryModel CreateLocalRepositoryModel(string localPath) => null;
-        public IBranch CreateCurrentBranchModel(ILocalRepositoryModel model) => null;
+        public IBranch GetBranch(ILocalRepositoryModel model) => null;
         public Task<string> GetLatestPushedSha(string path, string remote = "origin") => Task.FromResult<string>(null);
         public UriString GetRemoteUri(IRepository repo, string remote = "origin") => null;
         public IRepository GetRepository(string path) => null;

src/GitHub.App/ViewModels/GitHubPane/PullRequestCreationViewModel.cs

@@ -142,7 +142,7 @@ public async Task InitializeAsync(ILocalRepositoryModel repository, IConnection
         {
             modelService = await modelServiceFactory.CreateAsync(connection);
             activeLocalRepo = repository;
-            SourceBranch = gitService.CreateCurrentBranchModel(repository);
+            SourceBranch = gitService.GetBranch(repository);
 
             var obs = modelService.ApiClient.GetRepository(repository.Owner, repository.Name)
                 .Select(r => new RemoteRepositoryModel(r))
@@ -212,7 +212,7 @@ async Task LoadInitialState(string draftKey)
 
         void LoadDescriptionFromCommits()
         {
-            SourceBranch = gitService.CreateCurrentBranchModel(activeLocalRepo);
+            SourceBranch = gitService.GetBranch(activeLocalRepo);
 
             var uniqueCommits = this.WhenAnyValue(
                 x => x.SourceBranch,

src/GitHub.App/ViewModels/GitHubPane/PullRequestDetailViewModel.cs

@@ -405,7 +405,7 @@ public async Task Load(PullRequestDetailModel pullRequest)
 
                 var localBranches = await pullRequestsService.GetLocalBranches(LocalRepository, pullRequest).ToList();
 
-                var currentBranch = gitService.CreateCurrentBranchModel(LocalRepository);
+                var currentBranch = gitService.GetBranch(LocalRepository);
                 IsCheckedOut = localBranches.Contains(currentBranch);
 
                 if (IsCheckedOut)

src/GitHub.Exports/Services/GitService.cs

@@ -52,7 +52,7 @@ public ILocalRepositoryModel CreateLocalRepositoryModel(string localPath)
             return model;
         }
 
-        public IBranch CreateCurrentBranchModel(ILocalRepositoryModel model)
+        public IBranch GetBranch(ILocalRepositoryModel model)
         {
             var localPath = model.LocalPath;
             using (var repo = GetRepository(localPath))

src/GitHub.Exports/Services/IGitService.cs

@@ -19,7 +19,7 @@ public interface IGitService
         /// </summary>
         /// <param name="model">The <see cref="ILocalRepositoryModel" /> to create a current branch model for.</param>
         /// <returns>A new branch model.</returns>
-        IBranch CreateCurrentBranchModel(ILocalRepositoryModel model);
+        IBranch GetBranch(ILocalRepositoryModel model);
 
         /// <summary>
         /// Returns the URL of the remote for the specified <see cref="repository"/>. If the repository

src/GitHub.VisualStudio/Commands/OpenFromClipboardCommand.cs

@@ -99,7 +99,7 @@ public override async Task Execute(string url)
             if (hasChanges)
             {
                 // TODO: What if this returns null because we're not on a branch?
-                var currentBranch = gitService.Value.CreateCurrentBranchModel(activeRepository);
+                var currentBranch = gitService.Value.GetBranch(activeRepository);
                 var branchName = currentBranch.Name;
 
                 // AnnotateFile expects a branch name so we use the current branch

test/GitHub.App.UnitTests/ViewModels/GitHubPane/PullRequestCreationViewModelTests.cs

@@ -97,7 +97,7 @@ static TestData PrepareTestData(
         var targetRepo = targetRepoOwner == sourceRepoOwner ? sourceRepo : sourceRepo.Parent;
         var targetBranch = targetBranchName != targetRepo.DefaultBranch.Name ? new BranchModel(targetBranchName, targetRepo) : targetRepo.DefaultBranch;
 
-        gitService.CreateCurrentBranchModel(activeRepo).Returns(sourceBranch);
+        gitService.GetBranch(activeRepo).Returns(sourceBranch);
         api.GetRepository(Args.String, Args.String).Returns(Observable.Return(githubRepo));
         ms.ApiClient.Returns(api);
 

test/GitHub.App.UnitTests/ViewModels/GitHubPane/PullRequestDetailViewModelTests.cs

@@ -553,7 +553,7 @@ static Tuple<PullRequestDetailViewModel, IPullRequestService> CreateTargetAndSer
             var repository = Substitute.For<ILocalRepositoryModel>();
             var currentBranchModel = new BranchModel(currentBranch, repository);
             var gitService = Substitute.For<IGitService>();
-            gitService.CreateCurrentBranchModel(repository).Returns(currentBranchModel);
+            gitService.GetBranch(repository).Returns(currentBranchModel);
             repository.CloneUrl.Returns(new UriString(Uri.ToString()));
             repository.LocalPath.Returns(@"C:\projects\ThisRepo");
             repository.Name.Returns("repo");

test/GitHub.TeamFoundation.UnitTests/VSGitExtTests.cs

@@ -311,7 +311,7 @@ public ILocalRepositoryModel CreateLocalRepositoryModel(string localPath)
             return result;
         }
 
-        public IBranch CreateCurrentBranchModel(ILocalRepositoryModel model) => throw new NotImplementedException();
+        public IBranch GetBranch(ILocalRepositoryModel model) => throw new NotImplementedException();
         public Task<string> GetLatestPushedSha(string path, string remote = "origin") => throw new NotImplementedException();
         public UriString GetRemoteUri(IRepository repo, string remote = "origin") => throw new NotImplementedException();
         public IRepository GetRepository(string path) => throw new NotImplementedException();

test/GitHub.VisualStudio.UnitTests/Commands/OpenFromClipboardCommandTests.cs

@@ -197,7 +197,7 @@ static OpenFromClipboardCommand CreateOpenFromClipboardCommand(
             var gitService = Substitute.For<IGitService>();
             var currentBranch = Substitute.For<IBranch>();
             currentBranch.Name.Returns(currentBranchName);
-            gitService.CreateCurrentBranchModel(activeRepository).Returns(currentBranch);
+            gitService.GetBranch(activeRepository).Returns(currentBranch);
             if (resolveBlobResult != null)
             {
                 gitHubContextService.ResolveBlob(repositoryDir, contextFromClipboard).Returns(resolveBlobResult.Value);