Merge pull request #1183 from github/fixes/1168-readonly-temp-files

jcansdale · web-flow · commit bcdf132a7d01 · 2017-08-22T09:47:32.000+01:00
Don't make temp files readonly.
diff --git a/src/GitHub.App/Services/PullRequestService.cs b/src/GitHub.App/Services/PullRequestService.cs
@@ -446,7 +446,6 @@ static string CreateTempFile(string fileName, string commitSha, string contents,
 
             Directory.CreateDirectory(tempDir);
             File.WriteAllText(tempFile, contents, encoding);
-            File.SetAttributes(tempFile, FileAttributes.ReadOnly);
             return tempFile;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -446,7 +446,6 @@ static string CreateTempFile(string fileName, string commitSha, string contents,`
`446`	`446`
`447`	`447`	`Directory.CreateDirectory(tempDir);`
`448`	`448`	`File.WriteAllText(tempFile, contents, encoding);`
`449`		`- File.SetAttributes(tempFile, FileAttributes.ReadOnly);`
`450`	`449`	`return tempFile;`
`451`	`450`	`}`
`452`	`451`