Fix CA errors.

Author: grokys

src/GitHub.App/SampleData/PullRequestReviewViewModelDesigner.cs

@@ -1,12 +1,14 @@
 using System;
 using System.Collections.Generic;
+using System.Diagnostics.CodeAnalysis;
 using System.Threading.Tasks;
 using GitHub.Models;
 using GitHub.ViewModels.GitHubPane;
 using ReactiveUI;
 
 namespace GitHub.SampleData
 {
+    [ExcludeFromCodeCoverage]
     public class PullRequestReviewViewModelDesigner : PanePageViewModelBase, IPullRequestReviewViewModel
     {
         public PullRequestReviewViewModelDesigner()
@@ -67,19 +69,5 @@ public PullRequestReviewViewModelDesigner()
         public IPullRequestModel PullRequestModel { get; set; }
         public string RemoteRepositoryOwner { get; set; }
         public string StateDisplay { get; set; }
-
-        public Task InitializeAsync(
-            ILocalRepositoryModel localRepository,
-            string owner,
-            IPullRequestModel pullRequest,
-            long pullRequestReviewId)
-        {
-            throw new NotImplementedException();
-        }
-
-        public Task Load(IPullRequestModel pullRequest)
-        {
-            throw new NotImplementedException();
-        }
     }
 }

src/GitHub.App/SampleData/PullRequestUserReviewsViewModelDesigner.cs

@@ -1,12 +1,14 @@
 using System;
 using System.Collections.Generic;
+using System.Diagnostics.CodeAnalysis;
 using System.Threading.Tasks;
 using GitHub.Models;
 using GitHub.ViewModels.GitHubPane;
 using ReactiveUI;
 
 namespace GitHub.SampleData
 {
+    [ExcludeFromCodeCoverage]
     public class PullRequestUserReviewsViewModelDesigner : PanePageViewModelBase, IPullRequestUserReviewsViewModel
     {
         public PullRequestUserReviewsViewModelDesigner()
@@ -68,10 +70,5 @@ public Task InitializeAsync(ILocalRepositoryModel localRepository, IConnection c
         {
             return Task.CompletedTask;
         }
-
-        public Task Load(IAccount user, IPullRequestModel pullRequest)
-        {
-            return Task.CompletedTask;
-        }
     }
 }

src/GitHub.App/ViewModels/GitHubPane/PullRequestReviewFileCommentViewModel.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Diagnostics.CodeAnalysis;
 using System.Reactive;
 using GitHub.Extensions;
 using GitHub.Models;
@@ -12,7 +13,9 @@ namespace GitHub.ViewModels.GitHubPane
     /// </summary>
     public class PullRequestReviewFileCommentViewModel : IPullRequestReviewFileCommentViewModel
     {
+        [SuppressMessage("Microsoft.Performance", "CA1823:AvoidUnusedPrivateFields", Justification = "This will be used in a later PR")]
         readonly IPullRequestEditorService editorService;
+        [SuppressMessage("Microsoft.Performance", "CA1823:AvoidUnusedPrivateFields", Justification = "This will be used in a later PR")]
         readonly IPullRequestSession session;
         readonly IPullRequestReviewCommentModel model;
 

src/GitHub.App/ViewModels/GitHubPane/PullRequestReviewViewModel.cs

@@ -14,10 +14,6 @@ namespace GitHub.ViewModels.GitHubPane
     /// </summary>
     public class PullRequestReviewViewModel : ViewModelBase, IPullRequestReviewViewModel
     {
-        static readonly ILogger log = LogManager.ForContext<PullRequestReviewViewModel>();
-
-        readonly IPullRequestEditorService editorService;
-        readonly IPullRequestSession session;
         bool isExpanded;
 
         /// <summary>
@@ -37,9 +33,6 @@ public PullRequestReviewViewModel(
             Guard.ArgumentNotNull(session, nameof(session));
             Guard.ArgumentNotNull(model, nameof(model));
 
-            this.editorService = editorService;
-            this.session = session;
-
             Model = model;
             Body = string.IsNullOrWhiteSpace(Model.Body) ? null : Model.Body;
             StateDisplay = ToString(Model.State);

src/GitHub.App/ViewModels/GitHubPane/PullRequestUserReviewsViewModel.cs

@@ -139,22 +139,22 @@ public override async Task Refresh()
         }
 
         /// <inheritdoc/>
-        async Task Load(IAccount user, IPullRequestModel pullRequest)
+        async Task Load(IAccount author, IPullRequestModel pullRequest)
         {
             IsBusy = true;
 
             try
             {
                 session = await sessionManager.GetSession(pullRequest);
-                User = user;
+                User = author;
                 PullRequestTitle = pullRequest.Title;
 
                 var reviews = new List<IPullRequestReviewViewModel>();
                 var isFirst = true;
 
                 foreach (var review in pullRequest.Reviews.OrderByDescending(x => x.SubmittedAt))
                 {
-                    if (review.User.Login == user.Login &&
+                    if (review.User.Login == author.Login &&
                         review.State != PullRequestReviewState.Pending)
                     {
                         var vm = new PullRequestReviewViewModel(editorService, session, pullRequest, review);