Make sure publish form goes away when it's done

We now track completion state of the publish repo process
so that we can fire Done() only when it's actually done...
otherwise the observable subscriptions waiting for things
to be done will get disposed after the first publish attempt,
and if that fails, well, subscriptions are completed and disposed
so the form stops reacting to anything else.

Author: shana

src/GitHub.App/Controllers/UIController.cs

@@ -150,9 +150,9 @@ public IObservable<bool> ListenToCompletionState()
         void End(bool success)
         {
             uiProvider.RemoveService(typeof(IConnection));
+            transition.OnCompleted();
             completion.OnNext(success);
             completion.OnCompleted();
-            transition.OnCompleted();
         }
 
         void RunView(UIViewType viewType)

src/GitHub.UI.Reactive/Controls/SimpleViewUserControl.cs

@@ -43,18 +43,27 @@ public SimpleViewUserControl()
 
         protected void NotifyDone()
         {
+            if (disposed)
+                return;
+
             close.OnNext(null);
             close.OnCompleted();
         }
 
         protected void NotifyCancel()
         {
+            if (disposed)
+                return;
+
             cancel.OnNext(null);
             cancel.OnCompleted();
         }
 
         protected void NotifyIsBusy(bool busy)
         {
+            if (disposed)
+                return;
+
             isBusy.OnNext(busy);
         }
 

src/GitHub.VisualStudio/TeamExplorer/Sync/GitHubPublishSection.cs

@@ -119,11 +119,8 @@ void ShowPublish()
             var creation = ui.SelectFlow(UIControllerFlow.Publish);
             ui.ListenToCompletionState().Subscribe(done =>
             {
-                if (done)
-                {
-                    IsVisible = false;
-                    ServiceProvider.TryGetService<ITeamExplorer>()?.NavigateToPage(new Guid(TeamExplorerPageIds.Home), null);
-                }
+                IsVisible = false;
+                ServiceProvider.TryGetService<ITeamExplorer>()?.NavigateToPage(new Guid(TeamExplorerPageIds.Home), null);
             });
 
             creation.Subscribe(c =>

src/GitHub.VisualStudio/UI/Views/Controls/RepositoryPublishControl.xaml.cs

@@ -46,9 +46,7 @@ public RepositoryPublishControl()
 
                 ViewModel.PublishRepository.Subscribe(state =>
                 {
-                    if (state == ProgressState.Fail)
-                        NotifyCancel();
-                    else
+                    if (state == ProgressState.Success)
                         NotifyDone();
                 });