Make PullRequestDetailViewModel sealed

jcansdale · jcansdale · commit c3d5335b42f1 · 2017-12-01T16:15:52.000Z
Keep CA happy by making AutoDispose static.
diff --git a/src/GitHub.App/ViewModels/PullRequestDetailViewModel.cs b/src/GitHub.App/ViewModels/PullRequestDetailViewModel.cs
@@ -26,7 +26,7 @@ namespace GitHub.ViewModels
     /// </summary>
     [ExportViewModel(ViewType = UIViewType.PRDetail)]
     [PartCreationPolicy(CreationPolicy.NonShared)]
-    public class PullRequestDetailViewModel : PanePageViewModelBase, IPullRequestDetailViewModel, IDisposable
+    public sealed class PullRequestDetailViewModel : PanePageViewModelBase, IPullRequestDetailViewModel, IDisposable
     {
         static readonly ILogger log = LogManager.ForContext<PullRequestDetailViewModel>();
 
@@ -86,7 +86,7 @@ public void Dispose()
         }
 
         // HACK: This is a workaround for models not being automatically disposed.
-        class AutoDispose
+        static class AutoDispose
         {
             static IDisposable previous;
 

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ namespace GitHub.ViewModels`
`26`	`26`	`/// </summary>`
`27`	`27`	`[ExportViewModel(ViewType = UIViewType.PRDetail)]`
`28`	`28`	`[PartCreationPolicy(CreationPolicy.NonShared)]`
`29`		`- public class PullRequestDetailViewModel : PanePageViewModelBase, IPullRequestDetailViewModel, IDisposable`
	`29`	`+ public sealed class PullRequestDetailViewModel : PanePageViewModelBase, IPullRequestDetailViewModel, IDisposable`
`30`	`30`	`{`
`31`	`31`	`static readonly ILogger log = LogManager.ForContext<PullRequestDetailViewModel>();`
`32`	`32`
`@@ -86,7 +86,7 @@ public void Dispose()`
`86`	`86`	`}`
`87`	`87`
`88`	`88`	`// HACK: This is a workaround for models not being automatically disposed.`
`89`		`- class AutoDispose`
	`89`	`+ static class AutoDispose`
`90`	`90`	`{`
`91`	`91`	`static IDisposable previous;`
`92`	`92`