nameof is not exactly unique and the two tests can race and clash

shana · shana · commit c6e909026bdc · 2015-10-28T12:30:20.000+01:00
diff --git a/src/UnitTests/GitHub.App/Caches/CredentialCacheTests.cs b/src/UnitTests/GitHub.App/Caches/CredentialCacheTests.cs
@@ -172,7 +172,7 @@ public class TheInvalidateMethod
         [Fact]
         public async Task InvalidatesTheCredential()
         {
-            const string key = nameof(InvalidatesTheCredential);
+            const string key = "TheInvalidateMethod.InvalidatesTheCredential";
             using (var credentialCache = new CredentialCache())
             {
                 var credential = Tuple.Create("somebody", "somebody's secret");
@@ -211,7 +211,7 @@ public class TheInvalidateObjectMethod
         [Fact]
         public async Task InvalidatesTheCredential()
         {
-            const string key = nameof(InvalidatesTheCredential);
+            const string key = "TheInvalidateObjectMethod.InvalidatesTheCredential";
             using (var credentialCache = new CredentialCache())
             {
                 var credential = Tuple.Create("somebody", "somebody's secret");

Original file line number	Diff line number	Diff line change
`@@ -172,7 +172,7 @@ public class TheInvalidateMethod`
`172`	`172`	`[Fact]`
`173`	`173`	`public async Task InvalidatesTheCredential()`
`174`	`174`	`{`
`175`		`- const string key = nameof(InvalidatesTheCredential);`
	`175`	`+ const string key = "TheInvalidateMethod.InvalidatesTheCredential";`
`176`	`176`	`using (var credentialCache = new CredentialCache())`
`177`	`177`	`{`
`178`	`178`	`var credential = Tuple.Create("somebody", "somebody's secret");`
`@@ -211,7 +211,7 @@ public class TheInvalidateObjectMethod`
`211`	`211`	`[Fact]`
`212`	`212`	`public async Task InvalidatesTheCredential()`
`213`	`213`	`{`
`214`		`- const string key = nameof(InvalidatesTheCredential);`
	`214`	`+ const string key = "TheInvalidateObjectMethod.InvalidatesTheCredential";`
`215`	`215`	`using (var credentialCache = new CredentialCache())`
`216`	`216`	`{`
`217`	`217`	`var credential = Tuple.Create("somebody", "somebody's secret");`